When converting strings to float/double, there are two use cases:
- The string came from the user. Then we should respect the current locale, so that the number gets understood in the way the user is used to, i.e., with the right decimal separator.
- The string came from a config file or other machine readable source. Then the number format can probably be assumed to use
.as the decimal separator, so we have to parse the string without taking the current locale into account.
This commit fixes some places, for example that the page size of exported PDFs was wrong. There are still a bunch of other uses of std::strtod, std::stod, std::istringstream and similar that need to be reviewed.
When reviewing this MR, please double check that I didn't break anything by mistaking user strings with system strings.