惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

B
Blog
Microsoft Security Blog
Microsoft Security Blog
Jina AI
Jina AI
博客园 - 叶小钗
J
Java Code Geeks
博客园 - 聂微东
博客园 - 司徒正美
大猫的无限游戏
大猫的无限游戏
阮一峰的网络日志
阮一峰的网络日志
V
V2EX
美团技术团队
WordPress大学
WordPress大学
M
MIT News - Artificial intelligence
雷峰网
雷峰网
酷 壳 – CoolShell
酷 壳 – CoolShell
GbyAI
GbyAI
罗磊的独立博客
T
The Blog of Author Tim Ferriss
aimingoo的专栏
aimingoo的专栏
T
Tailwind CSS Blog
The Cloudflare Blog
Stack Overflow Blog
Stack Overflow Blog
N
Netflix TechBlog - Medium
小众软件
小众软件

Martin Owens activity

Martin Owens deleted project branch average-color-divide at Inkscape / inkscape Fix divide-by-zero crash when using calligraphy tool (d34276f8) · Commits · Inkscape / inkscape · GitLab Fix divide-by-zero crash when using calligraphy tool (!7923) · Merge requests · Inkscape / inkscape · GitLab Add selection file to bypass Windows command length limits (correction) (865df7a5) · Commits · Inkscape / inkscape · GitLab Draft: Fix AppImage crashing during save on older distros (!7922) · Merge requests · Inkscape / inkscape · GitLab e71fa7f8e0858aab87b7fc0814a30a8c88da9b43 to fe225a6b9e1042c7221d95173be22a02b3725337 · Martin Owens / inkscape · GitLab 403 Forbidden on Inkscape web server (#693) · Issues · Inkscape / inkscape-web · GitLab 403 Forbidden on Inkscape web server (#13509) · Issues · Inkscape / Inbox · GitLab Add selection file to bypass Windows command length limits (correction) (!7917) · 合并请求 · Inkscape / inkscape · GitLab Non-vertical axonometric axis implementation (!7912) · Merge requests · Inkscape / inkscape · GitLab Update split mode on tab switch (!7915) · Merge requests · Inkscape / inkscape · GitLab inset/offset as app functions so they can be used from CLI (!7914) · Merge requests · Inkscape / inkscape · GitLab Performace regresion in last month (#5879) · Issues · Inkscape / inkscape · GitLab [Regression] Right-aligned text has a new gap in 1.4.4 (#6130) · Issues · Inkscape / inkscape · GitLab [Regression] Right-aligned text has a new gap in 1.4.4 (#13498) · Issues · Inkscape / Inbox · GitLab c503804e014994d611de1b225bee8158c06448a8 to a4588d8ead1e7049b90c5a126962746ed286ab17 · Inkscape / inkscape-web · GitLab Validate the extensions of signature file uploads (a4588d8e) · 提交 · Inkscape / inkscape-web · GitLab Allow color conversions using static arrays instead of just vectors (e71fa7f8) · 提交 · Martin Owens / inkscape · GitLab Speed up ungroup on thousands of items (!7908) · Merge requests · Inkscape / inkscape · GitLab Incorrect handling of FontMatrix and transformation matrices with internal PDF import (#4845) · Issues · Inkscape / inkscape · GitLab Handling edge case of negative fonts in PDF (59040229) · 提交 · Inkscape / inkscape · GitLab Handling edge case of negative fonts in PDF (!7911) · 合并请求 · Inkscape / inkscape · GitLab Allow color conversions using static arrays instead of just vectors (33e65d1b) · Commits · Martin Owens / inkscape · GitLab a9672ea1dff483b5b3aa8c6b5d88cd223001bef5 to 512a5e57602ac52e1d35782a7dcebae04262b2b8 · Martin Owens / inkscape · GitLab Add selection file to bypass Windows command length limits (!7905) · 合并请求 · Inkscape / inkscape · GitLab Revert Pango label changes (1.4.x) (!7907) · 合并请求 · Inkscape / inkscape · GitLab Crash on selecting a `<text>` object without a `<tspan>` inside (#5462) · Issues · Inkscape / inkscape · GitLab Fix breakage with Ubuntu 26.04 CI (!7904) · 合并请求 · Inkscape / inkscape · GitLab c673fdd5148253276826d4eda3951daaefb82607 to 356b31383ba324396a225686613236484305533d · Martin Owens / inkscape · GitLab Revert Text tool cursor changes (1.4.x) (!7903) · 合并请求 · Inkscape / inkscape · GitLab
Allow color conversions using static arrays instead of ju...
Martin Owens · 2026-05-04 · via Martin Owens activity
Commit 9be5f867 authored by Martin Owens's avatar Martin Owens 🕘
Browse files
Most color conversion will be done with std::vectors of doubles
but to speed up and provide compile time checks for color converting
on Surfaces we want the ability to take an array directly at some
but not all of the various levels.

Formalise the interface for ProfileSpace and the Convertable type
using a self-referential templating pattern.

Move most conversion code to static functions and make as agnostic
to the array type as possible, allowing for convertors to use them
directly without expensive vector types.
+0 −3
Original line number Diff line number Diff line
@@ -15,7 +15,6 @@ set(colors_unit_SRC
	spaces/cmyk.cpp
	spaces/components.cpp
	spaces/gamut.cpp
	spaces/gray.cpp
	spaces/hsl.cpp
	spaces/hsluv.cpp
	spaces/hsv.cpp
@@ -24,8 +23,6 @@ set(colors_unit_SRC
	spaces/linear-rgb.cpp
	spaces/luv.cpp
	spaces/ok-color.cpp
	spaces/okhsl.cpp
	spaces/okhsv.cpp
	spaces/oklab.cpp
	spaces/oklch.cpp
	spaces/named.cpp
+8 −0
Original line number Diff line number Diff line
@@ -26,6 +26,14 @@ public:

    bool do_transform(std::vector<double> &io) const;

    template <typename In, typename Out>
    bool do_transform(In const &i, Out &o)
    {
        assert(i.size() >= _channels_in && o.size() >= _channels_out);
        cmsDoTransform(_handle, &i.front(), &o.front(), 1);
        return true;
    }

private:

    int _channels_in;
+1 −1
Original line number Diff line number Diff line
@@ -159,7 +159,7 @@ bool Color::convert(Color const &other)
 */
bool Color::convert(std::shared_ptr<Space::AnySpace> to_space)
{
    if (!to_space || !to_space->isValid()) {
    if (!to_space || !to_space->hasValidCmsProfile()) {
        return false;
    }

+1 −1
Original line number Diff line number Diff line
@@ -147,7 +147,7 @@ std::optional<Color> DocumentCMS::parse(std::string const &value) const
        }
        auto space = _spaces.find(cms_name)->second;

        if (!space->isValid()) {
        if (!space->hasValidCmsProfile()) {
            for (int i = 2; i >= 0; i--) {
                // Assume RGB fallback data if three doubles. Else black.
                values.insert(values.begin(), fallback.size() == 3 ? fallback[i] : 0.0);
+5 −7
Original line number Diff line number Diff line
@@ -20,18 +20,16 @@ namespace Inkscape::Colors::Space {
 * be used in color pickers or store data in a color field. Instead it's purely used
 * for converting a surface of pixels into a luminosity mask while rendering.
 */
class Alpha : public AnySpace
class Alpha : public ProfileSpace<true>
{
public:
    Alpha(): AnySpace(Type::Alpha, 0, "Alpha", "Alpha", "") {}
    Alpha()
        : ProfileSpace(Type::Alpha, 0, "Alpha", "Alpha", "")
    {}

    bool isDirect() const override { return true; }
    std::shared_ptr<Colors::CMS::Profile> const getProfile() const override;

    std::string toString(std::vector<double> const &values, bool opacity) const override
    {
        return "";
    }
    std::string toString(std::vector<double> const &values, bool opacity) const override { return ""; }
};

} // namespace Inkscape::Colors::Space