Poppler's getString() et al now return &std::string and not
*GooString. So functions that expected *Goostring have been
modified to accept std::string, with wrappers for backwards
compatibility

Fixes #6090

This looks like a copy&paste oversight. As a result, copying
to the clipboard sometimes randomly ran the odf export code for
the povray mime type, resulting in weird behaviour.

karliss1 authored Apr 18, 2026 and karliss1 committed Apr 17, 2026

Long term storage of raw pointers for  objects which might have been erased by the time shape builder finishes is problematic.

Fixes #6101

This allows the paint server code to be unit tested in later versions. There are some limitations
to this refactoring including use of virtual functions instead of casting so we can use templates
in renderers.

ll SPObjects must implement their virtual functions, so the base classes all return empty objects
where possible and this pushed the design in a certain direction for some calls.

 * Move sp-gradient spread, units and vector to sp-paint-server-data.h
 * Move mesh gradient patches data from display/drawing-paintserver to sp-paint-server-data
 * Allow SPPaintServer to be used as a template class in a renderer by providing data from sp-paint-server-data in a consistant way from the base class using virtual functions.
 * Add getPaintType and enum class to decide what type of paint server we have instead of cast
 * Add SPGradient virtual for gathering geometric gradient data for Lienar and Radial gradients
 * Add SPMeshGradient virtual for gathering mesh patches data for the Mesh gradient
 * Pack gradient geometric data into SPGradientVector and return in getGradientVector
 * Harmonize const and API between Mesh Gradients and Linear/Radial Gradients
 * Move add create_drawing_paintserver calls to display/drawing-paintserver in a single call
 * Remove `mg` MeshGradient pointer from MeshArray and remove back-linking. This indicates bad
   API design for some of these calls as the functions used mg and had little to do with the MeshArray
   but for now we just push the MeshGradient object back in as an argument.
 * Change drawing-paintserver constructors to take paint-server-data objects instead of individual arguments.

Remove remaining uses of SCALE24_TO_FLOAT and FROM_FLOAT macros which were only
used for SPIFloat and can easily be folded into the object itself.

Harmonize the default data type use with SPIEnum, SPILength and SPIFontSize
this allows the rendering engine nr-style.cpp to use the right rendering value
which is always the computed value and not need to think about the internal
implementation of the style variable between `value`, `computed` and will allow
these variable to be made private in the future.

Mikekov: Add `as_double` and `as_enum` getter functions for the new explicit interface.

Vaibhav Malik authored Apr 19, 2026 and Vaibhav Malik committed Apr 20, 2026

* In the multi-color autotrace mode, max scans is used to set the
  `color_count` value. It determines the number of colors a color bitmap
  is reduced to. The allowed values are 1 to 256.

* The crash occurred because of incrementing scans value by 1 in
  multi-color autotrace mode while invoking setColorCount. Since, the
  maximum value allowed for the scan adjustment is 256, this'd result in
  color count being set to 257. Hence, resulting in a crash because of
  out of range value.

Fixes: #5475

Nagata Parama Aptana authored Apr 17, 2026 and Willy (Wen-Wei) Kao committed Apr 21, 2026

Use boost intrusive multiset instead of std::list, now insert takes O(log n)
instead of O(n) with n number of items on canvas. Erase remains O(1).

No more memory allocation or failure paths on cache insertion
at the expense of slightly larger DrawingItem struct.

Ayan Das authored Jan 20, 2026 and karliss1 committed Apr 21, 2026

In 'transform_rotate', 'transform_rotate_step', and 'transform_rotate_screen' multiply the rotation angle by 'yaxisdir()' to ensures the visual rotation the action (CW vs CCW).
calculate the visual angle' relative to 'yaxisdir()' for generating the Undo History message.

Fixes: #5992

Added isDirect to Colors::Space::* which tells us if a color space is
backed by a single icc profile, and no other processing steps with some
public method cleanups.

Removed Lab toXYZ and fromXYZ which were orphaned by previous commit.

Reformatted CairoTransform into generic SurfaceTransform so it can work
with any memory surface of pixels and in a greater number of data formats.

Split out CMS transform class from SurfaceTransforms and use a base class
Allowing for different assumptions with formatting and alpha premultiplication.

Add a forward.h header to make including color namespaces easier and cleaner.

Clean up generic testing utils for VectorIs Add colors and some better flexibility
for arrays and vectors in testing.

This color space allows surfaces to be converted to luminosity masks
and varius other useful alpha related filtering for the new rendering
engine.

We use lcms2 to hold the gray scale profile for quicker conversions.

The transform-cms is modified so it can cope with outputs which do
not have an allpha channel of their own. Tests for this are added.

To support more color channels, and greater flexibility in our rendering
engine, this new code impliments a new API for accessing pixel data in a
cairo surface and expands it's capabilities so that they can work with
floating point pixel data as well as CMYKA (5 channel) interpolations.

The new interface makes heavy use of compile time templating for channel count
and cairo surface formats.

The primary use of this API is for filters. Each filter which depends on
non-cairo functionality is recoded to use this new API and split out from
their svg filter primitive and display object files so they can be unit tested.

Threading and dispatch pool are held as light copies until the refactoring is
completed and we can copy them to a central utility instead.

Assistance from PBS (squashed):

* Use requires instead of run-time checks.
* Use more modern _v/_t instead of ::value/::type.
* Fix const T* memory() calling itself in infinite loop.
* Make some functions static (_primary_pos, _bilinear_interpolate).
* Make _transform std::optional.
* Convert G_BYTE_ORDER == G_LITTLE_ENDIAN to if constexpr, revealing
  missing glib.h header.
* Use safemod for wrapping.

To contain the multiple cairo surfaces and integrate with the pixel access code
a new Surface class is made that stores references to cairo surfaces.

PixelAccess objects of the right format can be run with filters to control the
surface at a pixel by pixel level.

A host of new tests are adding for each of the filters to make sure PixelAccess
integration is correct for each one of them.

Other Changes

 * Add forward declaration to colors API to smooth importing

We wrap the cairo context with our own multi-context engine
which keeps track of the color space, can paint multi-surface
CMYK rasters onto each other as well as translate between
Inkscape geom, path objects to cairo instructions.

Added many tests for each of the functionalities in cairo context
drawing.

Add README to explain the local code structures.

The stack mostly backs onto PixelFilters, but also onto the Surface
and Context where upstream functionality can provide the output.

The ColorSpace for the filter primitives are tied into the rendering
process so filters are rendered in the correct space.

Drawing options are refactored to be more concise for future use.

This copy from display allows the differences to be seen more easily.

display/drawing* -> renderer/drawing/drawing*
display/surface* -> renderer/drawing/drawing-area* (might not be needed)
display/tags* -> renderer/drawing/drawing-item-tags*
display/nr-style* -> renderer/drawing/drawing-style*

The process used for this refactoring was a light touch on the logic. But
the namespaces, and somme processes that were incompatible with the new
surface and pixel filters had to be changed.

The RenderContext was changed to DrawingOptions to better express what it is
and the various options from filters and other parts of the pipeline were
added so they aren't being passed around in addition.

Pull in all uses of SPStyle into the DrawingStyle parsing and remove DrawingItem
style variables to provide consistancy and remove duplication.