- Fix the custom colors to actually work in the first place, due to some Uint/Color confusions about how to handle the prefs (this is its own commit, for easier review)
- Use one preference, not two for custom icon colors.
- Rename the checkbox to be clearer ("Change icon colors")
- Hide controls if that checkbox is disabled
- Reorganize the controls to be better aligned with each other
By and large, this fixes #4897 (closed) (certainly the toplevel request of hiding the widgets when not enabled).
Issues remaining:
- Sometimes, a quick change of color is not picked up by Inkscape until you close and re-open the preference dialog. If you slide around on the color bars, the changes will be noticed. Though sometimes (but not always) it seems like a quick change is missed. I don't know exactly what it's about, but didn't want to spend too much time on this unrelated (but real) issue.
- The UX ticket asked for two changes I didn't take the time to implement:
- "show it only for themes that supports it (have a CSS file)"
- "refresh button resets colors from css" (this one doesn't seem so important, you can just unselect and reselect the "change icon colors" checkbox)
- These both could be done later. But I figured fixing it to work and reorganizing it to be a lot clearer was already a big win.