惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

J
Java Code Geeks
F
Fortinet All Blogs
Martin Fowler
Martin Fowler
M
MIT News - Artificial intelligence
G
Google Developers Blog
P
Proofpoint News Feed
Recent Announcements
Recent Announcements
MyScale Blog
MyScale Blog
D
DataBreaches.Net
Stack Overflow Blog
Stack Overflow Blog
月光博客
月光博客
爱范儿
爱范儿
罗磊的独立博客
腾讯CDC
Hugging Face - Blog
Hugging Face - Blog
博客园 - 叶小钗
Vercel News
Vercel News
酷 壳 – CoolShell
酷 壳 – CoolShell
B
Blog
C
Check Point Blog
美团技术团队
宝玉的分享
宝玉的分享
Microsoft Security Blog
Microsoft Security Blog
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix commitments extractor model selection (#75347) · open...
vignesh07 · 2026-05-01 · via Recent Commits to openclaw:main

@@ -1,6 +1,7 @@

11

import { randomUUID } from "node:crypto";

22

import path from "node:path";

33

import { resolveAgentWorkspaceDir } from "../agents/agent-scope.js";

4+

import { resolveDefaultModelForAgent } from "../agents/model-selection.js";

45

import { runEmbeddedPiAgent, type EmbeddedPiRunResult } from "../agents/pi-embedded.js";

56

import type { OpenClawConfig } from "../config/config.js";

67

import { resolveStateDir } from "../config/paths.js";

@@ -41,12 +42,14 @@ export type CommitmentExtractionRuntime = {

4142

};

42434344

const log = createSubsystemLogger("commitments");

45+

const TERMINAL_EXTRACTION_FAILURE_COOLDOWN_MS = 15 * 60_000;

44464547

let runtime: CommitmentExtractionRuntime = {};

4648

let queue: Array<Omit<CommitmentExtractionItem, "existingPending"> & { cfg?: OpenClawConfig }> = [];

4749

let timer: TimerHandle | null = null;

4850

let draining = false;

4951

let queueOverflowWarned = false;

52+

let terminalFailureCooldownUntilByAgent = new Map<string, number>();

50535154

function shouldDisableBackgroundExtractionForTests(): boolean {

5255

if (runtime.forceInTests) {

@@ -82,6 +85,7 @@ export function resetCommitmentExtractionRuntimeForTests(): void {

8285

timer = null;

8386

draining = false;

8487

queueOverflowWarned = false;

88+

terminalFailureCooldownUntilByAgent = new Map();

8589

}

86908791

function buildItemId(params: CommitmentExtractionEnqueueInput, nowMs: number): string {

@@ -95,14 +99,19 @@ function isUsefulText(value: string | undefined): boolean {

959996100

export function enqueueCommitmentExtraction(input: CommitmentExtractionEnqueueInput): boolean {

97101

const resolved = resolveCommitmentsConfig(input.cfg);

102+

const nowMs = input.nowMs ?? Date.now();

103+

const agentId = normalizeOptionalString(input.agentId) ?? "";

104+

const sessionKey = normalizeOptionalString(input.sessionKey) ?? "";

105+

const channel = normalizeOptionalString(input.channel) ?? "";

98106

if (

99107

!resolved.enabled ||

100108

shouldDisableBackgroundExtractionForTests() ||

109+

(agentId ? nowMs < (terminalFailureCooldownUntilByAgent.get(agentId) ?? 0) : false) ||

101110

!isUsefulText(input.userText) ||

102111

!isUsefulText(input.assistantText) ||

103-

!input.agentId.trim() ||

104-

!input.sessionKey.trim() ||

105-

!input.channel.trim()

112+

!agentId ||

113+

!sessionKey ||

114+

!channel

106115

) {

107116

return false;

108117

}

@@ -116,14 +125,13 @@ export function enqueueCommitmentExtraction(input: CommitmentExtractionEnqueueIn

116125

}

117126

return false;

118127

}

119-

const nowMs = input.nowMs ?? Date.now();

120128

queue.push({

121129

itemId: buildItemId(input, nowMs),

122130

nowMs,

123131

timezone: resolveCommitmentTimezone(input.cfg),

124-

agentId: input.agentId.trim(),

125-

sessionKey: input.sessionKey.trim(),

126-

channel: input.channel.trim(),

132+

agentId,

133+

sessionKey,

134+

channel,

127135

...(input.accountId?.trim() ? { accountId: input.accountId.trim() } : {}),

128136

...(input.to?.trim() ? { to: input.to.trim() } : {}),

129137

...(input.threadId?.trim() ? { threadId: input.threadId.trim() } : {}),

@@ -145,6 +153,33 @@ export function enqueueCommitmentExtraction(input: CommitmentExtractionEnqueueIn

145153

return true;

146154

}

147155156+

function isTerminalExtractionError(error: unknown): boolean {

157+

const message = error instanceof Error ? error.message : String(error);

158+

return (

159+

/\bNo API key found\b/i.test(message) ||

160+

/\bUnknown model\b/i.test(message) ||

161+

/\bAuth profile credentials are missing or expired\b/i.test(message) ||

162+

/\bOAuth token refresh failed\b/i.test(message) ||

163+

/\bmissing credential\b/i.test(message) ||

164+

/\bmissing credentials\b/i.test(message) ||

165+

/\bmissing_api_key\b/i.test(message) ||

166+

/\binvalid_grant\b/i.test(message)

167+

);

168+

}

169+170+

function openTerminalFailureCooldown(agentId: string, error: unknown): void {

171+

terminalFailureCooldownUntilByAgent.set(

172+

agentId,

173+

Date.now() + TERMINAL_EXTRACTION_FAILURE_COOLDOWN_MS,

174+

);

175+

queue = queue.filter((item) => item.agentId !== agentId);

176+

log.warn("commitment extraction disabled temporarily after terminal model/auth failure", {

177+

agentId,

178+

cooldownMs: TERMINAL_EXTRACTION_FAILURE_COOLDOWN_MS,

179+

error: String(error),

180+

});

181+

}

182+148183

function resolveExtractionSessionFile(agentId: string, runId: string): string {

149184

return path.join(

150185

resolveStateDir(),

@@ -176,6 +211,7 @@ async function defaultExtractBatch(params: {

176211

}

177212

const resolved = resolveCommitmentsConfig(cfg);

178213

const runId = `commitments-${randomUUID()}`;

214+

const modelRef = resolveDefaultModelForAgent({ cfg, agentId: first.agentId });

179215

const result = await runEmbeddedPiAgent({

180216

sessionId: runId,

181217

sessionKey: `agent:${first.agentId}:commitments:${runId}`,

@@ -184,6 +220,8 @@ async function defaultExtractBatch(params: {

184220

sessionFile: resolveExtractionSessionFile(first.agentId, runId),

185221

workspaceDir: resolveAgentWorkspaceDir(cfg, first.agentId),

186222

config: cfg,

223+

provider: modelRef.provider,

224+

model: modelRef.model,

187225

prompt: buildCommitmentExtractionPrompt({ cfg, items: params.items }),

188226

disableTools: true,

189227

thinkLevel: "off",

@@ -225,7 +263,15 @@ export async function drainCommitmentExtractionQueue(): Promise<number> {

225263

const batch = queue.splice(0, resolved.extraction.batchMaxItems);

226264

const items = await hydrateBatch(batch);

227265

const extractor = runtime.extractBatch ?? defaultExtractBatch;

228-

const result = await extractor({ cfg: firstCfg, items });

266+

let result: CommitmentExtractionBatchResult;

267+

try {

268+

result = await extractor({ cfg: firstCfg, items });

269+

} catch (error) {

270+

if (isTerminalExtractionError(error)) {

271+

openTerminalFailureCooldown(items[0]?.agentId ?? "", error);

272+

}

273+

throw error;

274+

}

229275

await persistCommitmentExtractionResult({

230276

cfg: firstCfg,

231277

items,