惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

L
LangChain Blog
S
SegmentFault 最新的问题
V
Visual Studio Blog
J
Java Code Geeks
宝玉的分享
宝玉的分享
美团技术团队
博客园 - Franky
酷 壳 – CoolShell
酷 壳 – CoolShell
H
Hackread – Cybersecurity News, Data Breaches, AI and More
有赞技术团队
有赞技术团队
量子位
Martin Fowler
Martin Fowler
MyScale Blog
MyScale Blog
Google DeepMind News
Google DeepMind News
Jina AI
Jina AI
博客园 - 叶小钗
月光博客
月光博客
P
Proofpoint News Feed
D
DataBreaches.Net
Blog — PlanetScale
Blog — PlanetScale
博客园_首页
腾讯CDC
Microsoft Azure Blog
Microsoft Azure Blog
Stack Overflow Blog
Stack Overflow Blog

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(slack): keep typing indicators for message-tool repli...
steipete · 2026-05-02 · via Recent Commits to openclaw:main

@@ -17,6 +17,8 @@ const startSlackStreamMock = vi.fn(async () => ({

1717

pendingText: "",

1818

}));

1919

const stopSlackStreamMock = vi.fn(async () => {});

20+

const reactSlackMessageMock = vi.fn(async () => {});

21+

const removeSlackReactionMock = vi.fn(async () => {});

2022

class TestSlackStreamNotDeliveredError extends Error {

2123

readonly pendingText: string;

2224

readonly slackCode: string;

@@ -32,6 +34,14 @@ let mockedBlockStreamingEnabled: boolean | undefined = false;

3234

let capturedReplyOptions: { disableBlockStreaming?: boolean } | undefined;

3335

let mockedReplyThreadTs: string | undefined = THREAD_TS;

3436

let mockedReplyThreadTsSequence: Array<string | undefined> | undefined;

37+

let capturedTyping:

38+

| {

39+

start: () => Promise<void>;

40+

stop?: () => Promise<void>;

41+

onStartError: (err: unknown) => void;

42+

onStopError?: (err: unknown) => void;

43+

}

44+

| undefined;

3545

let mockedDispatchSequence: Array<{

3646

kind: "tool" | "block" | "final";

3747

payload: {

@@ -62,28 +72,36 @@ function createDraftStreamStub() {

6272

}

63736474

function createPreparedSlackMessage(params?: {

75+

cfg?: Record<string, unknown>;

76+

ctxPayload?: Record<string, unknown>;

6577

message?: Partial<{

6678

channel: string;

6779

ts: string;

6880

thread_ts?: string;

6981

user: string;

7082

}>;

7183

replyToMode?: "off" | "first" | "all" | "batched";

84+

setSlackThreadStatus?: (params: {

85+

channelId: string;

86+

threadTs?: string;

87+

status: string;

88+

}) => Promise<void>;

89+

typingReaction?: string;

7290

}) {

7391

return {

7492

ctx: {

75-

cfg: {},

93+

cfg: params?.cfg ?? {},

7694

runtime: {},

7795

botToken: "xoxb-test",

7896

app: { client: { chat: { postMessage: postMessageMock } } },

7997

teamId: "T1",

8098

textLimit: 4000,

81-

typingReaction: "",

99+

typingReaction: params?.typingReaction ?? "",

82100

removeAckAfterReply: false,

83101

historyLimit: 0,

84102

channelHistories: new Map(),

85103

allowFrom: [],

86-

setSlackThreadStatus: async () => undefined,

104+

setSlackThreadStatus: params?.setSlackThreadStatus ?? (async () => undefined),

87105

},

88106

account: {

89107

accountId: "default",

@@ -106,6 +124,7 @@ function createPreparedSlackMessage(params?: {

106124

replyTarget: "channel:C123",

107125

ctxPayload: {

108126

MessageThreadId: THREAD_TS,

127+

...params?.ctxPayload,

109128

},

110129

turn: {

111130

storePath: "/tmp/slack-sessions.json",

@@ -149,12 +168,29 @@ vi.mock("../conversation.runtime.js", () => ({

149168

}));

150169151170

vi.mock("openclaw/plugin-sdk/channel-reply-pipeline", () => ({

152-

createChannelReplyPipeline: () => ({

153-

typingCallbacks: {

154-

onIdle: vi.fn(),

155-

},

156-

onModelSelected: undefined,

157-

}),

171+

createChannelReplyPipeline: (params: {

172+

typing?: {

173+

start: () => Promise<void>;

174+

stop?: () => Promise<void>;

175+

onStartError: (err: unknown) => void;

176+

onStopError?: (err: unknown) => void;

177+

};

178+

}) => {

179+

capturedTyping = params.typing;

180+

return {

181+

...(params.typing

182+

? {

183+

typingCallbacks: {

184+

onReplyStart: params.typing.start,

185+

onIdle: () => {

186+

void params.typing?.stop?.();

187+

},

188+

},

189+

}

190+

: {}),

191+

onModelSelected: undefined,

192+

};

193+

},

158194

resolveChannelSourceReplyDeliveryMode: (params: {

159195

cfg?: { messages?: { groupChat?: { visibleReplies?: string } } };

160196

ctx?: { ChatType?: string };

@@ -220,8 +256,8 @@ vi.mock("openclaw/plugin-sdk/text-runtime", () => ({

220256

}));

221257222258

vi.mock("../../actions.js", () => ({

223-

reactSlackMessage: async () => {},

224-

removeSlackReaction: async () => {},

259+

reactSlackMessage: reactSlackMessageMock,

260+

removeSlackReaction: removeSlackReactionMock,

225261

}));

226262227263

vi.mock("../../draft-stream.js", () => ({

@@ -370,9 +406,12 @@ describe("dispatchPreparedSlackMessage preview fallback", () => {

370406

appendSlackStreamMock.mockReset();

371407

startSlackStreamMock.mockReset();

372408

stopSlackStreamMock.mockReset();

409+

reactSlackMessageMock.mockReset();

410+

removeSlackReactionMock.mockReset();

373411

mockedNativeStreaming = false;

374412

mockedBlockStreamingEnabled = false;

375413

capturedReplyOptions = undefined;

414+

capturedTyping = undefined;

376415

mockedReplyThreadTs = THREAD_TS;

377416

mockedReplyThreadTsSequence = undefined;

378417

mockedDispatchSequence = [{ kind: "final", payload: { text: FINAL_REPLY_TEXT } }];

@@ -439,6 +478,48 @@ describe("dispatchPreparedSlackMessage preview fallback", () => {

439478

expect(capturedReplyOptions?.disableBlockStreaming).toBe(true);

440479

});

441480481+

it("keeps Slack typing callbacks when channel replies are message-tool-only", async () => {

482+

const setSlackThreadStatus = vi.fn(async () => undefined);

483+484+

await dispatchPreparedSlackMessage(

485+

createPreparedSlackMessage({

486+

cfg: { messages: { groupChat: { visibleReplies: "message_tool" } } },

487+

ctxPayload: { ChatType: "channel" },

488+

setSlackThreadStatus,

489+

typingReaction: "hourglass_flowing_sand",

490+

}),

491+

);

492+493+

expect(capturedTyping).toBeDefined();

494+

expect(capturedReplyOptions?.disableBlockStreaming).toBe(true);

495+496+

await capturedTyping?.start();

497+

await capturedTyping?.stop?.();

498+499+

expect(setSlackThreadStatus).toHaveBeenCalledWith({

500+

channelId: "C123",

501+

threadTs: THREAD_TS,

502+

status: "is typing...",

503+

});

504+

expect(setSlackThreadStatus).toHaveBeenCalledWith({

505+

channelId: "C123",

506+

threadTs: THREAD_TS,

507+

status: "",

508+

});

509+

expect(reactSlackMessageMock).toHaveBeenCalledWith(

510+

"C123",

511+

"171234.111",

512+

"hourglass_flowing_sand",

513+

expect.objectContaining({ token: "xoxb-test" }),

514+

);

515+

expect(removeSlackReactionMock).toHaveBeenCalledWith(

516+

"C123",

517+

"171234.111",

518+

"hourglass_flowing_sand",

519+

expect.objectContaining({ token: "xoxb-test" }),

520+

);

521+

});

522+442523

it("escapes Slack mrkdwn in tool progress preview labels", async () => {

443524

const draftStream = createDraftStreamStub();

444525

createSlackDraftStreamMock.mockReturnValueOnce(draftStream);