惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

D
DataBreaches.Net
IT之家
IT之家
博客园_首页
博客园 - 【当耐特】
V
V2EX
Apple Machine Learning Research
Apple Machine Learning Research
G
Google Developers Blog
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
Recent Announcements
Recent Announcements
F
Fortinet All Blogs
GbyAI
GbyAI
腾讯CDC
H
Hackread – Cybersecurity News, Data Breaches, AI and More
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
I
InfoQ
H
Help Net Security
T
Tailwind CSS Blog
B
Blog RSS Feed
Martin Fowler
Martin Fowler
人人都是产品经理
人人都是产品经理
The Cloudflare Blog
博客园 - 叶小钗
雷峰网
雷峰网
量子位

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(mattermost): keep bare @mention with empty body inste...
iloveleon19 · 2026-06-16 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -1,6 +1,6 @@

11

// Mattermost tests cover monitor helpers plugin behavior.

22

import { describe, expect, it } from "vitest";

3-

import { normalizeMention } from "./monitor-helpers.js";

3+

import { normalizeMention, shouldDropEmptyMattermostBody } from "./monitor-helpers.js";

44
55

describe("normalizeMention", () => {

66

it("returns trimmed text when no mention provided", () => {

@@ -81,3 +81,106 @@ describe("normalizeMention", () => {

8181

expect(result).toBe(" code line 1\n code line 2");

8282

});

8383

});

84+
85+

describe("shouldDropEmptyMattermostBody", () => {

86+

it("drops a non-mention message that normalizes to an empty body", () => {

87+

expect(

88+

shouldDropEmptyMattermostBody({

89+

bodyText: "",

90+

rawText: " ",

91+

botUsername: "openclaw",

92+

}),

93+

).toBe(true);

94+

});

95+
96+

it("keeps a message that still has body text", () => {

97+

expect(

98+

shouldDropEmptyMattermostBody({

99+

bodyText: "hello",

100+

rawText: "hello",

101+

botUsername: "openclaw",

102+

}),

103+

).toBe(false);

104+

});

105+
106+

it("keeps a bare mention in a group", () => {

107+

expect(

108+

shouldDropEmptyMattermostBody({

109+

bodyText: "",

110+

rawText: "@openclaw",

111+

botUsername: "openclaw",

112+

}),

113+

).toBe(false);

114+

});

115+
116+

it("keeps a bare mention in a direct message", () => {

117+

expect(

118+

shouldDropEmptyMattermostBody({

119+

bodyText: "",

120+

rawText: "@OpenClaw",

121+

botUsername: "openclaw",

122+

}),

123+

).toBe(false);

124+

});

125+
126+

it("drops an empty body when the bot username is unknown", () => {

127+

expect(

128+

shouldDropEmptyMattermostBody({

129+

bodyText: "",

130+

rawText: "@someoneelse",

131+

botUsername: undefined,

132+

}),

133+

).toBe(true);

134+

});

135+
136+

it("drops a blank post even when a generic mention pattern matched it", () => {

137+

expect(

138+

shouldDropEmptyMattermostBody({

139+

bodyText: "",

140+

rawText: "",

141+

botUsername: "openclaw",

142+

}),

143+

).toBe(true);

144+

});

145+
146+

it("drops a bot mention with only a Unicode control residual", () => {

147+

expect(

148+

shouldDropEmptyMattermostBody({

149+

bodyText: "\u0085",

150+

rawText: "@openclaw\u0085",

151+

botUsername: "openclaw",

152+

}),

153+

).toBe(true);

154+

});

155+
156+

it("drops a bot mention with only a combining-mark residual", () => {

157+

expect(

158+

shouldDropEmptyMattermostBody({

159+

bodyText: "\ufe0f",

160+

rawText: "@openclaw\ufe0f",

161+

botUsername: "openclaw",

162+

}),

163+

).toBe(true);

164+

});

165+
166+

it.each([

167+

"@openclaw @openclaw",

168+

"@openclaw\n@openclaw",

169+

"@openclaw\n",

170+

"\n@openclaw",

171+

"@openclaw\r\n",

172+

"@openclaw\u2028",

173+

"@openclaw\u2029",

174+

"\v@openclaw\f",

175+

"@openclaw\u00a0",

176+

"\u2003@openclaw",

177+

])("drops an invalid empty-body candidate: %j", (rawText) => {

178+

expect(

179+

shouldDropEmptyMattermostBody({

180+

bodyText: "",

181+

rawText,

182+

botUsername: "openclaw",

183+

}),

184+

).toBe(true);

185+

});

186+

});

Original file line numberDiff line numberDiff line change

@@ -1,6 +1,7 @@

11

// Mattermost helper module supports monitor helpers behavior.

22

import { formatInboundFromLabel as formatInboundFromLabelShared } from "openclaw/plugin-sdk/channel-inbound";

33

import { resolveThreadSessionKeys as resolveThreadSessionKeysShared } from "openclaw/plugin-sdk/routing";

4+

import { normalizeLowercaseStringOrEmpty } from "openclaw/plugin-sdk/string-coerce-runtime";

45

import { rawDataToString } from "openclaw/plugin-sdk/webhook-ingress";

56
67

export { rawDataToString };

@@ -53,3 +54,16 @@ export function normalizeMention(text: string, mention: string | undefined): str

5354
5455

return normalizedLines.map((line) => line.text).join("\n");

5556

}

57+
58+

export function shouldDropEmptyMattermostBody(params: {

59+

bodyText: string;

60+

rawText: string;

61+

botUsername?: string | null;

62+

}): boolean {

63+

if (/[^\p{White_Space}\p{Cc}\p{Cf}\p{M}]/u.test(params.bodyText)) {

64+

return false;

65+

}

66+

const botUsername = normalizeLowercaseStringOrEmpty(params.botUsername ?? "");

67+

const bareMention = params.rawText.match(/^[ \t]*(@\S+)[ \t]*$/u)?.[1];

68+

return !botUsername || normalizeLowercaseStringOrEmpty(bareMention ?? "") !== `@${botUsername}`;

69+

}

Original file line numberDiff line numberDiff line change

@@ -445,6 +445,54 @@ describe("mattermost inbound user posts", () => {

445445

expect(ctx?.Provider).toBe("mattermost");

446446

});

447447
448+

it("dispatches a bare bot mention whose body is empty after normalization as a wake event", async () => {

449+

const socket = new FakeWebSocket();

450+

const abortController = new AbortController();

451+

mockState.abortController = abortController;

452+
453+

const monitor = monitorMattermostProvider({

454+

config: testConfig,

455+

runtime: testRuntime(),

456+

abortSignal: abortController.signal,

457+

webSocketFactory: () => socket,

458+

});

459+
460+

await vi.waitFor(() => {

461+

expect(socket.openListenerCount).toBeGreaterThan(0);

462+

});

463+

socket.emitOpen();

464+
465+

await socket.emitMessage({

466+

event: "posted",

467+

data: {

468+

channel_id: "chan-1",

469+

channel_name: "town-square",

470+

channel_display_name: "Town Square",

471+

sender_name: "alice",

472+

post: JSON.stringify({

473+

id: "post-bare-mention",

474+

channel_id: "chan-1",

475+

user_id: "user-1",

476+

message: "@openclaw",

477+

create_at: 1_714_000_000_001,

478+

}),

479+

},

480+

broadcast: {

481+

channel_id: "chan-1",

482+

user_id: "user-1",

483+

},

484+

});

485+

socket.emitClose(1000);

486+

await monitor;

487+
488+

expect(mockState.dispatchReplyFromConfig).toHaveBeenCalledTimes(1);

489+

const ctx = mockState.dispatchReplyFromConfig.mock.calls.at(0)?.[0].ctx;

490+

expect(ctx?.BodyForAgent).toBe("@openclaw");

491+

expect(ctx?.MessageSid).toBe("post-bare-mention");

492+

expect(ctx?.OriginatingChannel).toBe("mattermost");

493+

expect(ctx?.Provider).toBe("mattermost");

494+

});

495+
448496

it("merges Mattermost progress preview updates and clears after message-tool delivery", async () => {

449497

const socket = new FakeWebSocket();

450498

const abortController = new AbortController();

Original file line numberDiff line numberDiff line change

@@ -69,6 +69,7 @@ import {

6969

formatInboundFromLabel,

7070

normalizeMention,

7171

resolveThreadSessionKeys,

72+

shouldDropEmptyMattermostBody,

7273

} from "./monitor-helpers.js";

7374

import { resolveOncharPrefixes, stripOncharPrefix } from "./monitor-onchar.js";

7475

import { createMattermostMonitorResources, type MattermostMediaInfo } from "./monitor-resources.js";

@@ -1332,7 +1333,8 @@ export async function monitorMattermostProvider(opts: MonitorMattermostOpts = {}

13321333

normalizeOptionalString(payload.data?.sender_name) ??

13331334

normalizeOptionalString((await resolveUserInfo(senderId))?.username) ??

13341335

senderId;

1335-

const rawText = normalizeOptionalString(post.message) ?? "";

1336+

const rawPostText = typeof post.message === "string" ? post.message : "";

1337+

const rawText = normalizeOptionalString(rawPostText) ?? "";

13361338

const allowTextCommands = core.channel.commands.shouldHandleTextCommands({

13371339

cfg,

13381340

surface: "mattermost",

@@ -1526,12 +1528,15 @@ export async function monitorMattermostProvider(opts: MonitorMattermostOpts = {}

15261528

const bodySource = oncharTriggered ? oncharResult.stripped : rawText;

15271529

const baseText = [bodySource, mediaPlaceholder].filter(Boolean).join("\n").trim();

15281530

const bodyText = normalizeMention(baseText, botUsername);

1529-

if (!bodyText) {

1531+

if (shouldDropEmptyMattermostBody({ bodyText, rawText: rawPostText, botUsername })) {

15301532

logVerboseMessage(

1531-

`mattermost: drop group message (empty body after normalization channel=${channelId} sender=${senderId})`,

1533+

`mattermost: drop message (empty body after normalization channel=${channelId} sender=${senderId} wasMentioned=${wasMentioned})`,

15321534

);

15331535

return;

15341536

}

1537+

// Mention-only turns need non-empty agent text; the shared reply runner rejects empty

1538+

// bodies before model invocation. The guard above ensures this fallback is a bot mention.

1539+

const bodyForAgent = bodyText || rawText.trim();

15351540
15361541

core.channel.activity.record({

15371542

channel: "mattermost",

@@ -1590,7 +1595,7 @@ export async function monitorMattermostProvider(opts: MonitorMattermostOpts = {}

15901595

: undefined;

15911596

const ctxPayload = core.channel.reply.finalizeInboundContext({

15921597

Body: combinedBody,

1593-

BodyForAgent: bodyText,

1598+

BodyForAgent: bodyForAgent,

15941599

InboundHistory: inboundHistory,

15951600

RawBody: bodyText,

15961601

CommandBody: commandBody,