惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

V
V2EX
J
Java Code Geeks
月光博客
月光博客
博客园_首页
The GitHub Blog
The GitHub Blog
Vercel News
Vercel News
B
Blog RSS Feed
博客园 - 聂微东
宝玉的分享
宝玉的分享
T
Tailwind CSS Blog
Jina AI
Jina AI
S
SegmentFault 最新的问题
B
Blog
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
有赞技术团队
有赞技术团队
Hugging Face - Blog
Hugging Face - Blog
Google DeepMind News
Google DeepMind News
阮一峰的网络日志
阮一峰的网络日志
The Cloudflare Blog
量子位
Martin Fowler
Martin Fowler
博客园 - Franky
大猫的无限游戏
大猫的无限游戏
博客园 - 叶小钗

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(test): guard discord acp smoke cli args · openclaw/op...
vincentkoc · 2026-06-20 · via Recent Commits to openclaw:main

@@ -136,6 +136,26 @@ const DEFAULT_REQUEST_TIMEOUT_MS = 30_000;

136136

const DEFAULT_OPENCLAW_CLI_TIMEOUT_MS = 60_000;

137137

const DISCORD_RESPONSE_BODY_MAX_BYTES = 1024 * 1024;

138138

const WEBHOOK_CLEANUP_TIMEOUT_MS = 10_000;

139+

const BOOLEAN_OPTIONS = new Set(["--help", "-h", "--json"]);

140+

const VALUE_OPTIONS = new Set([

141+

"--channel",

142+

"--driver",

143+

"--token",

144+

"--token-prefix",

145+

"--bot-token",

146+

"--bot-token-prefix",

147+

"--agent",

148+

"--mention",

149+

"--instruction",

150+

"--timeout-ms",

151+

"--poll-ms",

152+

"--state-dir",

153+

"--openclaw-bin",

154+

]);

155+156+

class CliArgumentError extends Error {

157+

override name = "CliArgumentError";

158+

}

139159140160

function sleep(ms: number): Promise<void> {

141161

return new Promise((resolve) => {

@@ -237,21 +257,48 @@ function resolveStateDir(): string {

237257

return path.join(home, ".openclaw");

238258

}

239259240-

function resolveArg(flag: string): string | undefined {

241-

const argv = process.argv.slice(2);

260+

function resolveArg(flag: string, argv: string[]): string | undefined {

242261

const eq = argv.find((entry) => entry.startsWith(`${flag}=`));

243262

if (eq) {

244-

return eq.slice(flag.length + 1);

263+

const value = eq.slice(flag.length + 1);

264+

if (!value) {

265+

throw new CliArgumentError(`${flag} requires a value`);

266+

}

267+

return value;

245268

}

246269

const idx = argv.indexOf(flag);

247-

if (idx >= 0 && idx + 1 < argv.length) {

248-

return argv[idx + 1];

270+

if (idx < 0) {

271+

return undefined;

249272

}

250-

return undefined;

273+

const value = argv[idx + 1];

274+

if (!value || value.startsWith("--")) {

275+

throw new CliArgumentError(`${flag} requires a value`);

276+

}

277+

return value;

278+

}

279+280+

function hasFlag(flag: string, argv = process.argv.slice(2)): boolean {

281+

return argv.includes(flag);

251282

}

252283253-

function hasFlag(flag: string): boolean {

254-

return process.argv.slice(2).includes(flag);

284+

function validateCliArgs(argv: string[]): void {

285+

for (let index = 0; index < argv.length; index += 1) {

286+

const arg = argv[index] ?? "";

287+

if (BOOLEAN_OPTIONS.has(arg)) {

288+

continue;

289+

}

290+

if (arg.startsWith("--") && arg.includes("=")) {

291+

const [flag] = arg.split("=", 1);

292+

if (VALUE_OPTIONS.has(flag)) {

293+

continue;

294+

}

295+

}

296+

if (VALUE_OPTIONS.has(arg)) {

297+

index += 1;

298+

continue;

299+

}

300+

throw new CliArgumentError(`Unknown argument: ${arg}`);

301+

}

255302

}

256303257304

function parseDriverMode(raw: string): DriverMode {

@@ -314,43 +361,54 @@ function usage(): string {

314361

);

315362

}

316363317-

function parseArgs(): Args {

318-

const channelId = resolveArg("--channel") || process.env.OPENCLAW_DISCORD_SMOKE_CHANNEL_ID || "";

364+

function parseArgs(argv = process.argv.slice(2)): Args {

365+

validateCliArgs(argv);

366+

const channelId =

367+

resolveArg("--channel", argv) || process.env.OPENCLAW_DISCORD_SMOKE_CHANNEL_ID || "";

319368

const driverModeRaw =

320-

resolveArg("--driver") || process.env.OPENCLAW_DISCORD_SMOKE_DRIVER || "token";

369+

resolveArg("--driver", argv) || process.env.OPENCLAW_DISCORD_SMOKE_DRIVER || "token";

321370

const driverMode = parseDriverMode(driverModeRaw);

322371

const driverToken =

323-

resolveArg("--token") || process.env.OPENCLAW_DISCORD_SMOKE_DRIVER_TOKEN || "";

372+

resolveArg("--token", argv) || process.env.OPENCLAW_DISCORD_SMOKE_DRIVER_TOKEN || "";

324373

const driverTokenPrefix =

325-

resolveArg("--token-prefix") || process.env.OPENCLAW_DISCORD_SMOKE_DRIVER_TOKEN_PREFIX || "Bot";

374+

resolveArg("--token-prefix", argv) ||

375+

process.env.OPENCLAW_DISCORD_SMOKE_DRIVER_TOKEN_PREFIX ||

376+

"Bot";

326377

const botToken =

327-

resolveArg("--bot-token") ||

378+

resolveArg("--bot-token", argv) ||

328379

process.env.OPENCLAW_DISCORD_SMOKE_BOT_TOKEN ||

329380

process.env.DISCORD_BOT_TOKEN ||

330381

"";

331382

const botTokenPrefix =

332-

resolveArg("--bot-token-prefix") ||

383+

resolveArg("--bot-token-prefix", argv) ||

333384

process.env.OPENCLAW_DISCORD_SMOKE_BOT_TOKEN_PREFIX ||

334385

"Bot";

335-

const targetAgent = resolveArg("--agent") || process.env.OPENCLAW_DISCORD_SMOKE_AGENT || "codex";

386+

const targetAgent =

387+

resolveArg("--agent", argv) || process.env.OPENCLAW_DISCORD_SMOKE_AGENT || "codex";

336388

const mentionUserId =

337-

resolveArg("--mention") || process.env.OPENCLAW_DISCORD_SMOKE_MENTION_USER_ID || undefined;

389+

resolveArg("--mention", argv) ||

390+

process.env.OPENCLAW_DISCORD_SMOKE_MENTION_USER_ID ||

391+

undefined;

338392

const instruction =

339-

resolveArg("--instruction") || process.env.OPENCLAW_DISCORD_SMOKE_INSTRUCTION || undefined;

393+

resolveArg("--instruction", argv) ||

394+

process.env.OPENCLAW_DISCORD_SMOKE_INSTRUCTION ||

395+

undefined;

340396

const timeoutMs = parseNumber(

341-

resolveArg("--timeout-ms") || process.env.OPENCLAW_DISCORD_SMOKE_TIMEOUT_MS,

397+

resolveArg("--timeout-ms", argv) || process.env.OPENCLAW_DISCORD_SMOKE_TIMEOUT_MS,

342398

240_000,

343399

"--timeout-ms",

344400

);

345401

const pollMs = parseNumber(

346-

resolveArg("--poll-ms") || process.env.OPENCLAW_DISCORD_SMOKE_POLL_MS,

402+

resolveArg("--poll-ms", argv) || process.env.OPENCLAW_DISCORD_SMOKE_POLL_MS,

347403

1_500,

348404

"--poll-ms",

349405

);

350-

const stateDir = path.resolve(resolveArg("--state-dir") || resolveStateDir());

406+

const stateDir = path.resolve(resolveArg("--state-dir", argv) || resolveStateDir());

351407

const openclawBin =

352-

resolveArg("--openclaw-bin") || process.env.OPENCLAW_DISCORD_SMOKE_OPENCLAW_BIN || "openclaw";

353-

const json = hasFlag("--json");

408+

resolveArg("--openclaw-bin", argv) ||

409+

process.env.OPENCLAW_DISCORD_SMOKE_OPENCLAW_BIN ||

410+

"openclaw";

411+

const json = hasFlag("--json", argv);

354412355413

if (!channelId) {

356414

throw new Error(usage());

@@ -736,10 +794,10 @@ function printOutput(params: { json: boolean; payload: SuccessResult | FailureRe

736794

}

737795

}

738796739-

async function run(): Promise<SuccessResult | FailureResult> {

797+

async function run(argv = process.argv.slice(2)): Promise<SuccessResult | FailureResult> {

740798

let args: Args;

741799

try {

742-

args = parseArgs();

800+

args = parseArgs(argv);

743801

} catch (err) {

744802

return {

745803

ok: false,

@@ -1032,12 +1090,18 @@ async function run(): Promise<SuccessResult | FailureResult> {

10321090

}

10331091

}

103410921035-

async function main(): Promise<number> {

1036-

if (hasFlag("--help") || hasFlag("-h")) {

1093+

async function main(argv = process.argv.slice(2)): Promise<number> {

1094+

try {

1095+

validateCliArgs(argv);

1096+

} catch (err) {

1097+

writeStderrLine(safeErrorMessage(err));

1098+

return 1;

1099+

}

1100+

if (hasFlag("--help", argv) || hasFlag("-h", argv)) {

10371101

writeStdoutLine(usage());

10381102

return 0;

10391103

}

1040-

const result = await run().catch(

1104+

const result = await run(argv).catch(

10411105

(err: unknown): FailureResult => ({

10421106

ok: false,

10431107

stage: "unexpected",

@@ -1046,14 +1110,15 @@ async function main(): Promise<number> {

10461110

}),

10471111

);

10481112

printOutput({

1049-

json: hasFlag("--json"),

1113+

json: hasFlag("--json", argv),

10501114

payload: result,

10511115

});

10521116

return result.ok ? 0 : 1;

10531117

}

1054111810551119

export const testing = {

10561120

parseDriverMode,

1121+

parseArgs,

10571122

parseNumber,

10581123

DISCORD_RESPONSE_BODY_MAX_BYTES,

10591124

redactDiscordApiPath,