惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Martin Fowler
Martin Fowler
Y
Y Combinator Blog
M
MIT News - Artificial intelligence
The Cloudflare Blog
WordPress大学
WordPress大学
H
Hackread – Cybersecurity News, Data Breaches, AI and More
博客园 - 司徒正美
小众软件
小众软件
Blog — PlanetScale
Blog — PlanetScale
雷峰网
雷峰网
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
J
Java Code Geeks
云风的 BLOG
云风的 BLOG
C
Check Point Blog
D
DataBreaches.Net
T
The Blog of Author Tim Ferriss
V
V2EX
F
Fortinet All Blogs
B
Blog
大猫的无限游戏
大猫的无限游戏
N
Netflix TechBlog - Medium
B
Blog RSS Feed
A
About on SuperTechFans
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(codex): require approvals for image-understanding tur...
vincentkoc · 2026-04-26 · via Recent Commits to openclaw:main

@@ -48,7 +48,7 @@ function threadStartResult() {

4848

serviceTier: null,

4949

cwd: "/tmp/openclaw-agent",

5050

instructionSources: [],

51-

approvalPolicy: "never",

51+

approvalPolicy: "on-request",

5252

approvalsReviewer: "user",

5353

sandbox: { type: "dangerFullAccess" },

5454

permissionProfile: null,

@@ -74,9 +74,12 @@ function createFakeClient(options?: {

7474

inputModalities?: string[];

7575

completeWithItems?: boolean;

7676

notifyError?: string;

77+

approvalRequestMethod?: string;

7778

}) {

7879

const notifications = new Set<(notification: CodexServerNotification) => void>();

80+

const requestHandlers = new Set<(request: { method: string }) => JsonValue | undefined>();

7981

const requests: Array<{ method: string; params?: JsonValue }> = [];

82+

const approvalResponses: JsonValue[] = [];

8083

const request = vi.fn(async (method: string, params?: JsonValue) => {

8184

requests.push({ method, params });

8285

if (method === "model/list") {

@@ -89,6 +92,14 @@ function createFakeClient(options?: {

8992

return threadStartResult();

9093

}

9194

if (method === "turn/start") {

95+

if (options?.approvalRequestMethod) {

96+

for (const handler of requestHandlers) {

97+

const response = handler({ method: options.approvalRequestMethod });

98+

if (response !== undefined) {

99+

approvalResponses.push(response);

100+

}

101+

}

102+

}

92103

if (options?.notifyError) {

93104

for (const notify of notifications) {

94105

notify({

@@ -150,9 +161,13 @@ function createFakeClient(options?: {

150161

notifications.add(handler);

151162

return () => notifications.delete(handler);

152163

},

164+

addRequestHandler(handler: (request: { method: string }) => JsonValue | undefined) {

165+

requestHandlers.add(handler);

166+

return () => requestHandlers.delete(handler);

167+

},

153168

} as unknown as CodexAppServerClient;

154169155-

return { client, requests };

170+

return { client, requests, approvalResponses };

156171

}

157172158173

describe("codex media understanding provider", () => {

@@ -183,15 +198,15 @@ describe("codex media understanding provider", () => {

183198

expect(requests[1]?.params).toMatchObject({

184199

model: "gpt-5.4",

185200

modelProvider: "openai",

186-

approvalPolicy: "never",

201+

approvalPolicy: "on-request",

187202

sandbox: "read-only",

188203

dynamicTools: [],

189204

ephemeral: true,

190205

persistExtendedHistory: false,

191206

});

192207

expect(requests[2]?.params).toMatchObject({

193208

threadId: "thread-1",

194-

approvalPolicy: "never",

209+

approvalPolicy: "on-request",

195210

model: "gpt-5.4",

196211

input: [

197212

{ type: "text", text: "Describe briefly.", text_elements: [] },

@@ -200,6 +215,29 @@ describe("codex media understanding provider", () => {

200215

});

201216

});

202217218+

it("declines approval requests during image understanding", async () => {

219+

const { client, approvalResponses } = createFakeClient({

220+

approvalRequestMethod: "item/permissions/requestApproval",

221+

});

222+

const provider = buildCodexMediaUnderstandingProvider({

223+

clientFactory: async () => client,

224+

});

225+226+

await provider.describeImage?.({

227+

buffer: Buffer.from("image-bytes"),

228+

fileName: "image.png",

229+

mime: "image/png",

230+

provider: "codex",

231+

model: "gpt-5.4",

232+

prompt: "Describe briefly.",

233+

timeoutMs: 30_000,

234+

cfg: {},

235+

agentDir: "/tmp/openclaw-agent",

236+

});

237+238+

expect(approvalResponses).toEqual([{ permissions: {}, scope: "turn" }]);

239+

});

240+203241

it("extracts text from terminal turn items", async () => {

204242

const { client } = createFakeClient({ completeWithItems: true });

205243

const provider = buildCodexMediaUnderstandingProvider({