惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

V
V2EX
C
Check Point Blog
博客园_首页
B
Blog
D
Docker
U
Unit 42
量子位
I
InfoQ
有赞技术团队
有赞技术团队
Martin Fowler
Martin Fowler
GbyAI
GbyAI
L
LangChain Blog
云风的 BLOG
云风的 BLOG
博客园 - Franky
美团技术团队
T
The Blog of Author Tim Ferriss
阮一峰的网络日志
阮一峰的网络日志
月光博客
月光博客
Vercel News
Vercel News
Recent Announcements
Recent Announcements
雷峰网
雷峰网
大猫的无限游戏
大猫的无限游戏
小众软件
小众软件
Google DeepMind News
Google DeepMind News

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(file-transfer): validate inline write base64 · opencl...
vincentkoc · 2026-05-14 · via Recent Commits to openclaw:main

File tree

  • extensions/file-transfer/src/tools

Original file line numberDiff line numberDiff line change

@@ -36,6 +36,7 @@ Docs: https://docs.openclaw.ai

3636

- Gateway HTTP: match models, session kill, and session history route paths without trusting malformed Host headers, avoiding pre-auth 500s on those endpoints.

3737

- Google Meet/Codex: report malformed node proxy `payloadJSON` responses with plugin-owned errors instead of leaking raw JSON parser failures.

3838

- Debug proxy: reject malformed relative-form proxy targets with a controlled 400 response instead of letting URL parsing escape the request handler.

39+

- File transfer: reject malformed inline `file_write` base64 before computing hashes or invoking paired nodes, avoiding Node's lenient base64 decoder.

3940

- Models config/auth: stop inferring provider env-var markers from broad `^[A-Z_][A-Z0-9_]*$` strings, and resolve config-backed provider `apiKey` values only through structured env SecretRefs (`secrets.providers[id]` / `secrets.defaults`), so unrelated env vars cannot accidentally become provider credentials. Thanks @sallyom.

4041

- Media fetch: skip allocating and buffering the response body for bodyless media responses (HEAD probes and 204-style empty bodies), avoiding wasted heap on streams that carry no payload. Thanks @shakkernerd.

4142

- CLI/onboarding: forward provider-specific auth flags (e.g. `--openai-api-key`) through the onboarding wizard so they reach provider auth methods via `ctx.opts`, letting `--openai-api-key "$OPENAI_API_KEY"` skip the redundant "use existing env var?" prompt in non-interactive harnesses. (#81669) Thanks @sjf.

Original file line numberDiff line numberDiff line change

@@ -0,0 +1,29 @@

1+

import { callGatewayTool } from "openclaw/plugin-sdk/agent-harness-runtime";

2+

import { describe, expect, it, vi } from "vitest";

3+

import { createFileWriteTool } from "./file-write-tool.js";

4+
5+

vi.mock("openclaw/plugin-sdk/agent-harness-runtime", () => ({

6+

callGatewayTool: vi.fn(),

7+

listNodes: vi.fn(),

8+

resolveNodeIdFromList: vi.fn(),

9+

}));

10+
11+

vi.mock("openclaw/plugin-sdk/media-store", () => ({

12+

readMediaBuffer: vi.fn(),

13+

}));

14+
15+

describe("file_write tool", () => {

16+

it("rejects malformed inline base64 before invoking the node", async () => {

17+

const tool = createFileWriteTool();

18+
19+

await expect(

20+

tool.execute("tool-call-1", {

21+

node: "node-1",

22+

path: "/tmp/out.txt",

23+

contentBase64: "AAA@@@",

24+

}),

25+

).rejects.toThrow("contentBase64 is not valid base64");

26+
27+

expect(callGatewayTool).not.toHaveBeenCalled();

28+

});

29+

});

Original file line numberDiff line numberDiff line change

@@ -21,6 +21,18 @@ import {

2121

FILE_WRITE_TOOL_DESCRIPTOR,

2222

} from "./descriptors.js";

2323
24+

function normalizeBase64ForCompare(value: string): string {

25+

return value.replace(/=+$/u, "").replace(/-/gu, "+").replace(/_/gu, "/");

26+

}

27+
28+

function decodeStrictBase64(value: string): Buffer {

29+

const buffer = Buffer.from(value, "base64");

30+

if (normalizeBase64ForCompare(buffer.toString("base64")) !== normalizeBase64ForCompare(value)) {

31+

throw new Error("contentBase64 is not valid base64");

32+

}

33+

return buffer;

34+

}

35+
2436

async function readSourceBytes(input: {

2537

contentBase64?: string;

2638

sourceMediaId?: string;

@@ -37,7 +49,7 @@ async function readSourceBytes(input: {

3749

if (input.contentBase64 === undefined) {

3850

throw new Error("contentBase64 or sourceMediaId required");

3951

}

40-

const buffer = Buffer.from(input.contentBase64, "base64");

52+

const buffer = decodeStrictBase64(input.contentBase64);

4153

return { buffer, contentBase64: input.contentBase64, source: "inline" };

4254

}

4355