refactor(qa): share live approval result helpers · opencl...

Recent Commits to openclaw:main

vincentkoc · 2026-06-20 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,44 @@`
	`1`	`+export function formatApprovalResultValue(value: unknown) {`
	`2`	`+if (typeof value === "string" \|\| typeof value === "number" \|\| typeof value === "boolean") {`
	`3`	`+return String(value);`
	`4`	`+}`
	`5`	`+if (value == null) {`
	`6`	`+return "<missing>";`
	`7`	`+}`
	`8`	`+return JSON.stringify(value) ?? "<unserializable>";`
	`9`	`+}`
	`10`	`+`
	`11`	`+export function readAcceptedApprovalRequest(result: unknown) {`
	`12`	`+const accepted =`
	`13`	`+typeof result === "object" && result !== null`
	`14`	`+ ? (result as { id?: unknown; status?: unknown })`
	`15`	`+ : null;`
	`16`	`+if (accepted?.status !== "accepted") {`
	`17`	`+throw new Error(`
	`18`	+`approval request status was ${formatApprovalResultValue(
	`19`	`+ accepted?.status,`
	`20`	+ )} instead of accepted`,
	`21`	`+);`
	`22`	`+}`
	`23`	`+return accepted;`
	`24`	`+}`
	`25`	`+`
	`26`	`+export function readAcceptedApprovalRequestId(result: unknown) {`
	`27`	`+const id = readAcceptedApprovalRequest(result).id;`
	`28`	`+if (typeof id !== "string" \|\| id.trim().length === 0) {`
	`29`	+throw new Error(`approval request id was ${formatApprovalResultValue(id)}`);
	`30`	`+}`
	`31`	`+return id;`
	`32`	`+}`
	`33`	`+`
	`34`	`+export function assertApprovalDecisionResult(params: { decision: string; result: unknown }) {`
	`35`	`+const resultDecision =`
	`36`	`+typeof params.result === "object" && params.result !== null`
	`37`	`+ ? (params.result as { decision?: unknown }).decision`
	`38`	`+ : undefined;`
	`39`	`+if (resultDecision !== params.decision) {`
	`40`	`+throw new Error(`
	`41`	+`approval decision was ${formatApprovalResultValue(resultDecision)} instead of ${params.decision}`,
	`42`	`+);`
	`43`	`+}`
	`44`	`+}`

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,11 @@ import {`
`22`	`22`	`acquireQaCredentialLease,`
`23`	`23`	`startQaCredentialLeaseHeartbeat,`
`24`	`24`	`} from "../shared/credential-lease.runtime.js";`
	`25`	`+import {`
	`26`	`+assertApprovalDecisionResult,`
	`27`	`+formatApprovalResultValue,`
	`28`	`+readAcceptedApprovalRequestId,`
	`29`	`+} from "../shared/live-approval-result.js";`
`25`	`30`	`import {`
`26`	`31`	`appendQaLiveLaneIssue as appendLiveLaneIssue,`
`27`	`32`	`buildQaLiveLaneArtifactsError as buildLiveLaneArtifactsError,`
`@@ -718,39 +723,6 @@ async function listSlackThreadMessages(params: {`
`718`	`723`	`return replies.messages ?? [];`
`719`	`724`	`}`
`720`	`725`
`721`		`-function formatApprovalResultValue(value: unknown) {`
`722`		`-if (typeof value === "string" \|\| typeof value === "number" \|\| typeof value === "boolean") {`
`723`		`-return String(value);`
`724`		`-}`
`725`		`-if (value == null) {`
`726`		`-return "<missing>";`
`727`		`-}`
`728`		`-return JSON.stringify(value) ?? "<unserializable>";`
`729`		`-}`
`730`		`-`
`731`		`-function readAcceptedApprovalRequest(result: unknown) {`
`732`		`-const accepted =`
`733`		`-typeof result === "object" && result !== null`
`734`		`- ? (result as { id?: unknown; status?: unknown })`
`735`		`- : null;`
`736`		`-if (accepted?.status !== "accepted") {`
`737`		`-throw new Error(`
`738`		-`approval request status was ${formatApprovalResultValue(
`739`		`- accepted?.status,`
`740`		- )} instead of accepted`,
`741`		`-);`
`742`		`-}`
`743`		`-return accepted;`
`744`		`-}`
`745`		`-`
`746`		`-function readAcceptedApprovalRequestId(result: unknown) {`
`747`		`-const id = readAcceptedApprovalRequest(result).id;`
`748`		`-if (typeof id !== "string" \|\| id.trim().length === 0) {`
`749`		-throw new Error(`approval request id was ${formatApprovalResultValue(id)}`);
`750`		`-}`
`751`		`-return id;`
`752`		`-}`
`753`		`-`
`754`	`726`	`function collectSlackBlockStringFields(`
`755`	`727`	`value: unknown,`
`756`	`728`	`fieldName: string,`
`@@ -1382,21 +1354,6 @@ async function resolveApprovalDecision(params: {`
`1382`	`1354`	`);`
`1383`	`1355`	`}`
`1384`	`1356`
`1385`		`-function assertApprovalDecisionResult(params: {`
`1386`		`-decision: SlackQaApprovalDecision;`
`1387`		`-result: unknown;`
`1388`		`-}) {`
`1389`		`-const resultDecision =`
`1390`		`-typeof params.result === "object" && params.result !== null`
`1391`		`- ? (params.result as { decision?: unknown }).decision`
`1392`		`- : undefined;`
`1393`		`-if (resultDecision !== params.decision) {`
`1394`		`-throw new Error(`
`1395`		-`approval decision was ${formatApprovalResultValue(resultDecision)} instead of ${params.decision}`,
`1396`		`-);`
`1397`		`-}`
`1398`		`-}`
`1399`		`-`
`1400`	`1357`	`async function runSlackApprovalScenario(params: {`
`1401`	`1358`	`channelId: string;`
`1402`	`1359`	`context: Omit<SlackQaScenarioContext, "sentTs">;`

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,11 @@ import {`
`30`	`30`	`acquireQaCredentialLease,`
`31`	`31`	`startQaCredentialLeaseHeartbeat,`
`32`	`32`	`} from "../shared/credential-lease.runtime.js";`
	`33`	`+import {`
	`34`	`+assertApprovalDecisionResult,`
	`35`	`+formatApprovalResultValue,`
	`36`	`+readAcceptedApprovalRequestId,`
	`37`	`+} from "../shared/live-approval-result.js";`
`33`	`38`	`import {`
`34`	`39`	`appendQaLiveLaneIssue as appendLiveLaneIssue,`
`35`	`40`	`redactQaLiveLaneDetails,`
`@@ -2135,39 +2140,6 @@ async function startWhatsAppQaDriverSessionWithRetry(params: { authDir: string }`
`2135`	`2140`	`throw new Error("unreachable WhatsApp QA driver retry loop exit");`
`2136`	`2141`	`}`
`2137`	`2142`
`2138`		`-function formatApprovalResultValue(value: unknown) {`
`2139`		`-if (typeof value === "string" \|\| typeof value === "number" \|\| typeof value === "boolean") {`
`2140`		`-return String(value);`
`2141`		`-}`
`2142`		`-if (value == null) {`
`2143`		`-return "<missing>";`
`2144`		`-}`
`2145`		`-return JSON.stringify(value) ?? "<unserializable>";`
`2146`		`-}`
`2147`		`-`
`2148`		`-function readAcceptedApprovalRequest(result: unknown) {`
`2149`		`-const accepted =`
`2150`		`-typeof result === "object" && result !== null`
`2151`		`- ? (result as { id?: unknown; status?: unknown })`
`2152`		`- : null;`
`2153`		`-if (accepted?.status !== "accepted") {`
`2154`		`-throw new Error(`
`2155`		-`approval request status was ${formatApprovalResultValue(
`2156`		`- accepted?.status,`
`2157`		- )} instead of accepted`,
`2158`		`-);`
`2159`		`-}`
`2160`		`-return accepted;`
`2161`		`-}`
`2162`		`-`
`2163`		`-function readAcceptedApprovalRequestId(result: unknown) {`
`2164`		`-const id = readAcceptedApprovalRequest(result).id;`
`2165`		`-if (typeof id !== "string" \|\| id.trim().length === 0) {`
`2166`		-throw new Error(`approval request id was ${formatApprovalResultValue(id)}`);
`2167`		`-}`
`2168`		`-return id;`
`2169`		`-}`
`2170`		`-`
`2171`	`2143`	`async function requestWhatsAppApproval(params: {`
`2172`	`2144`	`approvalId: string;`
`2173`	`2145`	`driverPhoneE164: string;`
`@@ -2261,21 +2233,6 @@ async function resolveApprovalDecision(params: {`
`2261`	`2233`	`);`
`2262`	`2234`	`}`
`2263`	`2235`
`2264`		`-function assertApprovalDecisionResult(params: {`
`2265`		`-decision: WhatsAppQaApprovalDecision;`
`2266`		`-result: unknown;`
`2267`		`-}) {`
`2268`		`-const resultDecision =`
`2269`		`-typeof params.result === "object" && params.result !== null`
`2270`		`- ? (params.result as { decision?: unknown }).decision`
`2271`		`- : undefined;`
`2272`		`-if (resultDecision !== params.decision) {`
`2273`		`-throw new Error(`
`2274`		-`approval decision was ${formatApprovalResultValue(resultDecision)} instead of ${params.decision}`,
`2275`		`-);`
`2276`		`-}`
`2277`		`-}`
`2278`		`-`
`2279`	`2236`	`function matchesWhatsAppApprovalPendingText(params: {`
`2280`	`2237`	`approvalId: string;`
`2281`	`2238`	`approvalKind: WhatsAppQaApprovalKind;`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main