惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

博客园_首页
博客园 - Franky
大猫的无限游戏
大猫的无限游戏
博客园 - 三生石上(FineUI控件)
量子位
博客园 - 聂微东
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
S
SegmentFault 最新的问题
Apple Machine Learning Research
Apple Machine Learning Research
爱范儿
爱范儿
V
Visual Studio Blog
雷峰网
雷峰网
T
Tailwind CSS Blog
宝玉的分享
宝玉的分享
Blog — PlanetScale
Blog — PlanetScale
有赞技术团队
有赞技术团队
博客园 - 叶小钗
Microsoft Azure Blog
Microsoft Azure Blog
T
The Blog of Author Tim Ferriss
U
Unit 42
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
小众软件
小众软件
阮一峰的网络日志
阮一峰的网络日志
Y
Y Combinator Blog

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(test): guard benchmark qa cli args · openclaw/opencla...
vincentkoc · 2026-06-20 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -107,6 +107,22 @@ const DEFAULT_WARMUP = 1;

107107

const DEFAULT_TIMEOUT_MS = 30_000;

108108

const DEFAULT_ENTRY = "openclaw.mjs";

109109

const MAX_RSS_MARKER = "__OPENCLAW_MAX_RSS_KB__=";

110+

const VALUE_FLAGS = new Set([

111+

"--case",

112+

"--compare-baseline",

113+

"--compare-candidate",

114+

"--cpu-prof-dir",

115+

"--entry",

116+

"--entry-primary",

117+

"--entry-secondary",

118+

"--heap-prof-dir",

119+

"--output",

120+

"--preset",

121+

"--runs",

122+

"--timeout-ms",

123+

"--warmup",

124+

]);

125+

const BOOLEAN_FLAGS = new Set(["--help", "--json"]);

110126
111127

const COMMAND_CASES: readonly CommandCase[] = [

112128

{

@@ -451,6 +467,24 @@ function parseRepeatableFlag(flag: string): string[] {

451467

return values;

452468

}

453469
470+

function validateCliArgs(argv: readonly string[] = process.argv.slice(2)): void {

471+

for (let index = 0; index < argv.length; index += 1) {

472+

const arg = argv[index];

473+

if (VALUE_FLAGS.has(arg)) {

474+

const value = argv[index + 1];

475+

if (!value || value.startsWith("--")) {

476+

throw new Error(`${arg} requires a value`);

477+

}

478+

index += 1;

479+

continue;

480+

}

481+

if (BOOLEAN_FLAGS.has(arg)) {

482+

continue;

483+

}

484+

throw new Error(`Unknown argument: ${arg}`);

485+

}

486+

}

487+
454488

function parsePositiveInt(raw: string | undefined, fallback: number, label = "value"): number {

455489

return parseStrictIntegerOption({ fallback, label, min: 1, raw });

456490

}

@@ -1044,6 +1078,7 @@ async function main(): Promise<void> {

10441078

return;

10451079

}

10461080
1081+

validateCliArgs();

10471082

const options = parseOptions();

10481083

if (options.compareBaseline || options.compareCandidate) {

10491084

if (!options.compareBaseline || !options.compareCandidate) {

@@ -1148,12 +1183,13 @@ export const testing = {

11481183

parseNonNegativeInt,

11491184

parsePositiveInt,

11501185

readBenchmarkComparison: readBenchmarkComparisonForTesting,

1186+

validateCliArgs,

11511187

writeJsonOutput,

11521188

};

11531189
11541190

if (import.meta.url === pathToFileURL(process.argv[1] ?? "").href) {

11551191

await main().catch((error: unknown) => {

1156-

console.error(error instanceof Error ? error.stack : String(error));

1192+

console.error(error instanceof Error ? error.message : String(error));

11571193

process.exit(1);

11581194

});

11591195

}

Original file line numberDiff line numberDiff line change

@@ -38,19 +38,40 @@ export type ProducerOptions = {

3838

skipVisualProof: boolean;

3939

};

4040
41+

function usage() {

42+

return `Usage: node --import tsx scripts/qa/ux-matrix-evidence-producer.ts --artifact-base <dir> [options]

43+
44+

Produces a QA Lab UX Matrix evidence bundle.

45+
46+

Options:

47+

--artifact-base <dir> Evidence artifact directory

48+

--repo-root <dir> Repository root

49+

--skip-visual-proof Use fixture visual evidence instead of Playwright screenshots

50+

-h, --help Show this help

51+

`;

52+

}

53+
54+

function readOptionValue(argv: readonly string[], index: number, arg: string) {

55+

const value = argv[index + 1] ?? "";

56+

if (!value || value.startsWith("--")) {

57+

throw new Error(`${arg} requires a value`);

58+

}

59+

return value;

60+

}

61+
4162

function parseOptions(argv: readonly string[]): ProducerOptions {

4263

let artifactBase = "";

4364

let repoRoot = process.cwd();

4465

let skipVisualProof = false;

4566

for (let index = 0; index < argv.length; index += 1) {

4667

const arg = argv[index];

4768

if (arg === "--artifact-base") {

48-

artifactBase = argv[index + 1] ?? "";

69+

artifactBase = readOptionValue(argv, index, arg);

4970

index += 1;

5071

continue;

5172

}

5273

if (arg === "--repo-root") {

53-

repoRoot = argv[index + 1] ?? "";

74+

repoRoot = readOptionValue(argv, index, arg);

5475

index += 1;

5576

continue;

5677

}

@@ -625,13 +646,21 @@ export async function runUxMatrixEvidenceProducer(options: ProducerOptions) {

625646

}

626647
627648

if (import.meta.url === pathToFileURL(process.argv[1] ?? "").href) {

628-

runUxMatrixEvidenceProducer(parseOptions(process.argv.slice(2)))

629-

.then((result) => {

630-

console.log(`UX Matrix evidence: ${path.join(result.artifactBase, QA_EVIDENCE_FILENAME)}`);

631-

console.log(`UX Matrix entries: ${result.evidence.entries.length}`);

649+

(async () => {

650+

const cliArgs = process.argv.slice(2);

651+

if (cliArgs.includes("--help") || cliArgs.includes("-h")) {

652+

console.log(usage());

653+

return;

654+

}

655+

const result = await runUxMatrixEvidenceProducer(parseOptions(cliArgs));

656+

console.log(`UX Matrix evidence: ${path.join(result.artifactBase, QA_EVIDENCE_FILENAME)}`);

657+

console.log(`UX Matrix entries: ${result.evidence.entries.length}`);

658+

})()

659+

.then(() => {

660+

process.exitCode = 0;

632661

})

633662

.catch((error: unknown) => {

634-

console.error(error instanceof Error ? error.stack || error.message : String(error));

663+

console.error(error instanceof Error ? error.message : String(error));

635664

process.exitCode = 1;

636665

});

637666

}

Original file line numberDiff line numberDiff line change

@@ -1,4 +1,5 @@

11

// Bench Cli Startup tests cover bench cli startup script behavior.

2+

import { spawnSync } from "node:child_process";

23

import { existsSync, readFileSync, writeFileSync } from "node:fs";

34

import { join } from "node:path";

45

import { describe, expect, it } from "vitest";

@@ -29,6 +30,25 @@ function withEnv<T>(env: Record<string, string | undefined>, callback: () => T):

2930

}

3031
3132

describe("bench-cli-startup", () => {

33+

it("rejects unknown CLI options before running benchmarks", () => {

34+

expect(() => testing.validateCliArgs(["--wat"])).toThrow("Unknown argument: --wat");

35+
36+

const result = spawnSync(

37+

process.execPath,

38+

["--import", "tsx", "scripts/bench-cli-startup.ts", "--wat"],

39+

{

40+

cwd: join(__dirname, "../.."),

41+

encoding: "utf8",

42+

},

43+

);

44+
45+

expect(result.status).toBe(1);

46+

expect(result.stdout).toBe("");

47+

expect(result.stderr.trim()).toBe("Unknown argument: --wat");

48+

expect(result.stderr).not.toContain("Node.js");

49+

expect(result.stderr).not.toContain("\n at ");

50+

});

51+
3252

it("writes compare-mode JSON output and creates parent directories", () => {

3353

const tempDirs = createTempDirTracker();

3454

const tmpDir = tempDirs.make("openclaw-cli-startup-compare-output-");

Original file line numberDiff line numberDiff line change

@@ -0,0 +1,50 @@

1+

// QA UX Matrix evidence producer tests cover operator-facing CLI behavior.

2+

import { spawnSync } from "node:child_process";

3+

import path from "node:path";

4+

import { describe, expect, it } from "vitest";

5+
6+

function runCli(...args: string[]) {

7+

return spawnSync(

8+

process.execPath,

9+

["--import", "tsx", "scripts/qa/ux-matrix-evidence-producer.ts", ...args],

10+

{

11+

cwd: path.resolve(__dirname, "../.."),

12+

encoding: "utf8",

13+

},

14+

);

15+

}

16+
17+

function expectNoNodeStack(stderr: string) {

18+

expect(stderr).not.toContain("Node.js");

19+

expect(stderr).not.toContain("\n at ");

20+

}

21+
22+

describe("QA UX Matrix evidence producer CLI", () => {

23+

it("prints help without generating evidence", () => {

24+

const result = runCli("--help");

25+
26+

expect(result.status).toBe(0);

27+

expect(result.stdout).toContain(

28+

"Usage: node --import tsx scripts/qa/ux-matrix-evidence-producer.ts",

29+

);

30+

expect(result.stderr).toBe("");

31+

});

32+
33+

it("reports invalid args without a Node stack trace", () => {

34+

const result = runCli("--wat");

35+
36+

expect(result.status).toBe(1);

37+

expect(result.stdout).toBe("");

38+

expect(result.stderr.trim()).toBe("unsupported UX Matrix producer arg: --wat");

39+

expectNoNodeStack(result.stderr);

40+

});

41+
42+

it("reports missing valued args without a Node stack trace", () => {

43+

const result = runCli("--artifact-base", "--repo-root", ".");

44+
45+

expect(result.status).toBe(1);

46+

expect(result.stdout).toBe("");

47+

expect(result.stderr.trim()).toBe("--artifact-base requires a value");

48+

expectNoNodeStack(result.stderr);

49+

});

50+

});