惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

P
Proofpoint News Feed
V
V2EX
WordPress大学
WordPress大学
Google DeepMind News
Google DeepMind News
Martin Fowler
Martin Fowler
小众软件
小众软件
Blog — PlanetScale
Blog — PlanetScale
月光博客
月光博客
The Cloudflare Blog
T
Tailwind CSS Blog
H
Help Net Security
腾讯CDC
爱范儿
爱范儿
人人都是产品经理
人人都是产品经理
H
Hackread – Cybersecurity News, Data Breaches, AI and More
The GitHub Blog
The GitHub Blog
Microsoft Security Blog
Microsoft Security Blog
Stack Overflow Blog
Stack Overflow Blog
D
DataBreaches.Net
C
Check Point Blog
量子位
酷 壳 – CoolShell
酷 壳 – CoolShell
美团技术团队
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
Fix subagent completion announce delivery timing (#83039)...
joshavant · 2026-05-17 · via Recent Commits to openclaw:main

@@ -0,0 +1,249 @@

1+

import { describe, expect, it, vi } from "vitest";

2+

import { __testing, type EmbeddedPiActiveSessionSteerTarget } from "./attempt.js";

3+4+

describe("embedded Pi queued steering cancellation", () => {

5+

it("waits for the queued user message_end transcript boundary", async () => {

6+

let emit!: (event: unknown) => void;

7+

const activeSession: EmbeddedPiActiveSessionSteerTarget = {

8+

getSteeringMessages: () => [],

9+

steer: async () => {},

10+

subscribe: (listener) => {

11+

emit = listener;

12+

return () => {};

13+

},

14+

};

15+

const wait = __testing.steerAndWaitForTranscriptCommit(

16+

activeSession,

17+

"queued completion",

18+

10_000,

19+

);

20+

let settled = false;

21+

void wait.then(() => {

22+

settled = true;

23+

});

24+25+

emit({

26+

type: "message_start",

27+

message: {

28+

role: "user",

29+

content: [{ type: "text", text: "queued completion" }],

30+

},

31+

});

32+

await Promise.resolve();

33+

expect(settled).toBe(false);

34+35+

emit({

36+

type: "message_end",

37+

message: {

38+

role: "user",

39+

content: [{ type: "text", text: "queued completion" }],

40+

},

41+

});

42+43+

await expect(wait).resolves.toBeUndefined();

44+

expect(settled).toBe(true);

45+

});

46+47+

it("removes only the timed-out steering message and preserves unrelated payloads", async () => {

48+

const unrelatedImage = {

49+

type: "image",

50+

source: { type: "base64", data: "abc", media_type: "image/png" },

51+

};

52+

const unrelatedMessage = {

53+

role: "user",

54+

content: [{ type: "text", text: "keep this rich payload" }, unrelatedImage],

55+

timestamp: 1,

56+

};

57+

const targetMessage = {

58+

role: "user",

59+

content: [{ type: "text", text: "timed-out completion announce" }],

60+

timestamp: 2,

61+

};

62+

const trailingMessage = {

63+

role: "custom",

64+

customType: "notice",

65+

content: "preserve custom queued message",

66+

timestamp: 3,

67+

};

68+

const steeringUiMessages = ["keep this rich payload", "timed-out completion announce"];

69+

const queueMessages = [unrelatedMessage, targetMessage, trailingMessage];

70+

const activeSession: EmbeddedPiActiveSessionSteerTarget = {

71+

agent: {

72+

steeringQueue: {

73+

messages: queueMessages,

74+

},

75+

},

76+

getSteeringMessages: () => steeringUiMessages,

77+

steer: async () => {},

78+

subscribe: () => () => {},

79+

};

80+81+

await expect(

82+

__testing.cancelQueuedSteeringMessage(activeSession, "timed-out completion announce"),

83+

).resolves.toBe(true);

84+85+

expect(queueMessages).toEqual([unrelatedMessage, trailingMessage]);

86+

expect(queueMessages[0]).toBe(unrelatedMessage);

87+

expect(queueMessages[0]?.content[1]).toBe(unrelatedImage);

88+

expect(queueMessages[1]).toBe(trailingMessage);

89+

expect(steeringUiMessages).toEqual(["keep this rich payload"]);

90+

});

91+92+

it("rejects and removes the queued steering message when the session ends first", async () => {

93+

vi.useFakeTimers();

94+

let emit!: (event: unknown) => void;

95+

const targetMessage = {

96+

role: "user",

97+

content: [{ type: "text", text: "completion after parent stopped" }],

98+

timestamp: 2,

99+

};

100+

const keepMessage = {

101+

role: "user",

102+

content: [{ type: "text", text: "keep unrelated queue entry" }],

103+

timestamp: 3,

104+

};

105+

const steeringUiMessages = ["completion after parent stopped", "keep unrelated queue entry"];

106+

const queueMessages = [targetMessage, keepMessage];

107+

let unsubscribed = false;

108+

const activeSession: EmbeddedPiActiveSessionSteerTarget = {

109+

agent: {

110+

steeringQueue: {

111+

messages: queueMessages,

112+

},

113+

},

114+

getSteeringMessages: () => steeringUiMessages,

115+

steer: async () => {},

116+

subscribe: (listener) => {

117+

emit = listener;

118+

return () => {

119+

unsubscribed = true;

120+

};

121+

},

122+

};

123+124+

const wait = __testing.steerAndWaitForTranscriptCommit(

125+

activeSession,

126+

"completion after parent stopped",

127+

10_000,

128+

);

129+

const rejection = expect(wait).rejects.toThrow(

130+

"active session ended before queued steering message was committed to the transcript",

131+

);

132+133+

emit({ type: "agent_end", messages: [] });

134+

await vi.advanceTimersByTimeAsync(0);

135+136+

try {

137+

await rejection;

138+

expect(queueMessages).toEqual([keepMessage]);

139+

expect(steeringUiMessages).toEqual(["keep unrelated queue entry"]);

140+

expect(unsubscribed).toBe(true);

141+

} finally {

142+

vi.useRealTimers();

143+

}

144+

});

145+146+

it("keeps queued steering pending when Pi auto-retry starts after agent_end", async () => {

147+

vi.useFakeTimers();

148+

try {

149+

let emit!: (event: unknown) => void;

150+

const targetMessage = {

151+

role: "user",

152+

content: [{ type: "text", text: "completion survives retry" }],

153+

timestamp: 2,

154+

};

155+

const steeringUiMessages = ["completion survives retry"];

156+

const queueMessages = [targetMessage];

157+

const activeSession: EmbeddedPiActiveSessionSteerTarget = {

158+

agent: {

159+

steeringQueue: {

160+

messages: queueMessages,

161+

},

162+

},

163+

getSteeringMessages: () => steeringUiMessages,

164+

steer: async () => {},

165+

subscribe: (listener) => {

166+

emit = listener;

167+

return () => {};

168+

},

169+

};

170+171+

const wait = __testing.steerAndWaitForTranscriptCommit(

172+

activeSession,

173+

"completion survives retry",

174+

10_000,

175+

);

176+177+

emit({ type: "agent_end", messages: [] });

178+

emit({ type: "auto_retry_start", attempt: 1, maxAttempts: 3, delayMs: 1_000 });

179+

await vi.advanceTimersByTimeAsync(0);

180+181+

expect(queueMessages).toEqual([targetMessage]);

182+

expect(steeringUiMessages).toEqual(["completion survives retry"]);

183+184+

emit({

185+

type: "message_end",

186+

message: {

187+

role: "user",

188+

content: [{ type: "text", text: "completion survives retry" }],

189+

},

190+

});

191+192+

await expect(wait).resolves.toBeUndefined();

193+

} finally {

194+

vi.useRealTimers();

195+

}

196+

});

197+198+

it("keeps queued steering pending when Pi auto-compaction starts after agent_end", async () => {

199+

vi.useFakeTimers();

200+

try {

201+

let emit!: (event: unknown) => void;

202+

const targetMessage = {

203+

role: "user",

204+

content: [{ type: "text", text: "completion survives compaction" }],

205+

timestamp: 2,

206+

};

207+

const steeringUiMessages = ["completion survives compaction"];

208+

const queueMessages = [targetMessage];

209+

const activeSession: EmbeddedPiActiveSessionSteerTarget = {

210+

agent: {

211+

steeringQueue: {

212+

messages: queueMessages,

213+

},

214+

},

215+

getSteeringMessages: () => steeringUiMessages,

216+

steer: async () => {},

217+

subscribe: (listener) => {

218+

emit = listener;

219+

return () => {};

220+

},

221+

};

222+223+

const wait = __testing.steerAndWaitForTranscriptCommit(

224+

activeSession,

225+

"completion survives compaction",

226+

10_000,

227+

);

228+229+

emit({ type: "agent_end", messages: [] });

230+

emit({ type: "compaction_start", reason: "threshold" });

231+

await vi.advanceTimersByTimeAsync(0);

232+233+

expect(queueMessages).toEqual([targetMessage]);

234+

expect(steeringUiMessages).toEqual(["completion survives compaction"]);

235+236+

emit({

237+

type: "message_end",

238+

message: {

239+

role: "user",

240+

content: [{ type: "text", text: "completion survives compaction" }],

241+

},

242+

});

243+244+

await expect(wait).resolves.toBeUndefined();

245+

} finally {

246+

vi.useRealTimers();

247+

}

248+

});

249+

});