fix(channels): stop duplicating inbound previews in syste...

Recent Commits to openclaw:main

hugenshen · 2026-06-19 · via Recent Commits to openclaw:main

File tree

- msteams/src/monitor-handler
- slack/src/monitor/message-handler

Original file line number	Diff line number	Diff line change
`@@ -734,7 +734,7 @@ describe("msteams monitor handler authz", () => {`
`734`	`734`	`expect(ctxPayload.CommandAuthorized).toBe(true);`
`735`	`735`	`});`
`736`	`736`
`737`		`-it("marks skipped channel message system events as non-owner", async () => {`
	`737`	`+it("marks skipped channel message system events as non-owner without duplicating body text", async () => {`
`738`	`738`	`resetThreadMocks();`
`739`	`739`	`const { deps, enqueueSystemEvent } = createDeps({`
`740`	`740`	`channels: {`
`@@ -768,15 +768,16 @@ describe("msteams monitor handler authz", () => {`
`768`	`768`
`769`	`769`	`expect(runtimeApiMockState.dispatchReplyFromConfigWithSettledDispatcher).not.toHaveBeenCalled();`
`770`	`770`	`const systemEventCall = enqueueSystemEvent.mock.calls.find(`
`771`		`-([text]) => typeof text === "string" && text.includes("please run the deployment"),`
	`771`	`+([text]) => text === "Teams message in channel from Member",`
`772`	`772`	`);`
`773`	`773`	`if (!systemEventCall) {`
`774`	`774`	`throw new Error("expected skipped Teams message system event");`
`775`	`775`	`}`
`776`	`776`	`expect(systemEventCall[1]).toMatchObject({});`
	`777`	`+expect(systemEventCall[0]).not.toContain("please run the deployment");`
`777`	`778`	`});`
`778`	`779`
`779`		`-it("keeps dispatched primary message system events owner-neutral", async () => {`
	`780`	`+it("keeps dispatched primary message system events owner-neutral without duplicating body text", async () => {`
`780`	`781`	`resetThreadMocks();`
`781`	`782`	`const { deps, enqueueSystemEvent } = createDeps({`
`782`	`783`	`channels: {`
`@@ -810,11 +811,14 @@ describe("msteams monitor handler authz", () => {`
`810`	`811`
`811`	`812`	`expect(runtimeApiMockState.dispatchReplyFromConfigWithSettledDispatcher).toHaveBeenCalled();`
`812`	`813`	`const systemEventCall = enqueueSystemEvent.mock.calls.find(`
`813`		`-([text]) => typeof text === "string" && text.includes("please check the build"),`
	`814`	`+([text]) => text === "Teams message in channel from Member",`
`814`	`815`	`);`
`815`	`816`	`if (!systemEventCall) {`
`816`	`817`	`throw new Error("expected active Teams message system event");`
`817`	`818`	`}`
	`819`	`+expect(systemEventCall[0]).not.toContain("please check the build");`
	`820`	`+const dispatched = firstSettledDispatch();`
	`821`	`+expect(recordFromMockCall(dispatched.ctxPayload).BodyForAgent).toBe("please check the build");`
`818`	`822`	`});`
`819`	`823`
`820`	`824`	`it("authorizes text control commands from static access groups", async () => {`

Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,7 @@ export function createMSTeamsMessageHandler(deps: MSTeamsMessageHandlerDeps) {`
`508`	`508`	: `Teams message in ${conversationType} from ${senderName}`;
`509`	`509`
`510`	`510`	`const enqueuePrimaryMessageSystemEvent = () =>`
`511`		-core.system.enqueueSystemEvent(`${inboundLabel}: ${preview}`, {
	`511`	`+core.system.enqueueSystemEvent(inboundLabel, {`
`512`	`512`	`sessionKey: route.sessionKey,`
`513`	`513`	contextKey: `msteams:message:${conversationId}:${activity.id ?? "unknown"}`,
`514`	`514`	`});`

Original file line number	Diff line number	Diff line change
`@@ -158,14 +158,17 @@ describe("slack prepareSlackMessage inbound contract", () => {`
`158`	`158`	`});`
`159`	`159`	`}`
`160`	`160`
`161`		`-it("queues inbound message system events as untrusted", async () => {`
`162`		`-const prepared = await prepareWithDefaultCtx(createSlackMessage({}));`
	`161`	`+it("queues inbound message system events without duplicating body text", async () => {`
	`162`	`+const body =`
	`163`	`+"please summarize the deployment, rollback checks, health checks, and follow-up items";`
	`164`	`+const prepared = await prepareWithDefaultCtx(createSlackMessage({ text: body }));`
`163`	`165`
`164`	`166`	`assertPrepared(prepared);`
`165`		`-expect(enqueueSystemEventMock).toHaveBeenCalledWith("Slack DM from Alice: hi", {`
	`167`	`+expect(enqueueSystemEventMock).toHaveBeenCalledWith("Slack DM from Alice", {`
`166`	`168`	`sessionKey: prepared.ctxPayload.SessionKey,`
`167`	`169`	`contextKey: "slack:message:D123:1.000",`
`168`	`170`	`});`
	`171`	`+expect(prepared.ctxPayload.BodyForAgent).toContain(body);`
`169`	`172`	`});`
`170`	`173`
`171`	`174`	`it("prepares wildcard open-policy account DMs", async () => {`

Original file line number	Diff line number	Diff line change
`@@ -1131,7 +1131,7 @@ export async function prepareSlackMessage(params: {`
`1131`	`1131`	? `slack:channel:${message.channel}`
`1132`	`1132`	: `slack:group:${message.channel}`;
`1133`	`1133`
`1134`		-enqueueSystemEvent(`${inboundLabel}: ${preview}`, {
	`1134`	`+enqueueSystemEvent(inboundLabel, {`
`1135`	`1135`	`sessionKey,`
`1136`	`1136`	contextKey: `slack:message:${message.channel}:${message.ts ?? "unknown"}`,
`1137`	`1137`	`});`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main

File tree