惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Engineering at Meta
Engineering at Meta
雷峰网
雷峰网
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
B
Blog
Y
Y Combinator Blog
WordPress大学
WordPress大学
Microsoft Azure Blog
Microsoft Azure Blog
小众软件
小众软件
G
Google Developers Blog
云风的 BLOG
云风的 BLOG
罗磊的独立博客
博客园 - 三生石上(FineUI控件)
博客园 - 叶小钗
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
量子位
The Cloudflare Blog
T
The Blog of Author Tim Ferriss
博客园_首页
B
Blog RSS Feed
Hugging Face - Blog
Hugging Face - Blog
IT之家
IT之家
阮一峰的网络日志
阮一峰的网络日志
L
LangChain Blog
宝玉的分享
宝玉的分享

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(gateway): strip spurious tool calls on non-tool stops...
Jerry-Xin · 2026-05-31 · via Recent Commits to openclaw:main
1-

import { describe, expect, it } from "vitest";

1+

import type { ChatCompletionChunk } from "openai/resources/chat/completions.js";

2+

import { describe, expect, it, vi } from "vitest";

23

import type { Context, Model } from "../types.js";

4+5+

type DeepPartial<T> = { [P in keyof T]?: DeepPartial<T[P]> };

6+7+

const mockChunksRef: { chunks: DeepPartial<ChatCompletionChunk>[] } = { chunks: [] };

8+9+

vi.mock("openai", () => {

10+

class MockOpenAI {

11+

chat = {

12+

completions: {

13+

create: () => ({

14+

withResponse: async () => {

15+

async function* generate() {

16+

for (const chunk of mockChunksRef.chunks) {

17+

yield chunk;

18+

}

19+

}

20+

return {

21+

data: generate(),

22+

response: { status: 200, headers: new Headers() },

23+

};

24+

},

25+

}),

26+

},

27+

};

28+

}

29+

return { default: MockOpenAI };

30+

});

31+332

import { streamOpenAICompletions, streamSimpleOpenAICompletions } from "./openai-completions.js";

43334+

const model = {

35+

id: "gpt-5.5",

36+

name: "GPT-5.5",

37+

api: "openai-completions",

38+

provider: "openai",

39+

baseUrl: "https://api.openai.com/v1",

40+

reasoning: false,

41+

input: ["text"],

42+

cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },

43+

contextWindow: 128_000,

44+

maxTokens: 4096,

45+

} satisfies Model<"openai-completions">;

46+547

const context = {

648

messages: [{ role: "user", content: "hi", timestamp: 1 }],

749

} satisfies Context;

@@ -21,6 +63,44 @@ function createModel(maxTokens: number): Model<"openai-completions"> {

2163

};

2264

}

236566+

function makeTextChunk(text: string): DeepPartial<ChatCompletionChunk> {

67+

return {

68+

id: "chatcmpl-test",

69+

choices: [{ index: 0, delta: { content: text, role: "assistant" } }],

70+

};

71+

}

72+73+

function makeToolCallChunk(

74+

id: string,

75+

name: string,

76+

args: string,

77+

finishReason?: string,

78+

): DeepPartial<ChatCompletionChunk> {

79+

return {

80+

id: "chatcmpl-test",

81+

choices: [

82+

{

83+

index: 0,

84+

delta: {

85+

tool_calls: [{ index: 0, id, function: { name, arguments: args }, type: "function" }],

86+

},

87+

finish_reason: finishReason as ChatCompletionChunk.Choice["finish_reason"],

88+

},

89+

],

90+

};

91+

}

92+93+

function makeFinishChunk(

94+

finishReason: string,

95+

usage?: { prompt_tokens: number; completion_tokens: number; total_tokens: number },

96+

): DeepPartial<ChatCompletionChunk> {

97+

return {

98+

id: "chatcmpl-test",

99+

choices: [{ index: 0, delta: {}, finish_reason: finishReason as never }],

100+

...(usage ? { usage } : {}),

101+

};

102+

}

103+24104

describe("OpenAI-compatible completions params", () => {

25105

it("clamps requested max tokens to the model output cap", async () => {

26106

let capturedMaxTokens: unknown;

@@ -56,3 +136,65 @@ describe("OpenAI-compatible completions params", () => {

56136

expect(capturedStop).toEqual(["STOP"]);

57137

});

58138

});

139+140+

describe("openai-completions stop-reason tool-call guard", () => {

141+

it("strips toolCall blocks when finish_reason is stop but tool_calls were accumulated", async () => {

142+

mockChunksRef.chunks = [

143+

makeTextChunk("Hello"),

144+

makeToolCallChunk("call_1", "bash", '{"cmd":"ls"}'),

145+

makeFinishChunk("stop"),

146+

];

147+148+

const stream = streamOpenAICompletions(model, context, {

149+

apiKey: "sk-test",

150+

});

151+

const result = await stream.result();

152+153+

expect(result.stopReason).toBe("stop");

154+

expect(result.content.filter((b) => b.type === "toolCall")).toStrictEqual([]);

155+

expect(result.content.some((b) => b.type === "text")).toBe(true);

156+

});

157+158+

it("preserves toolCall blocks when finish_reason is tool_calls", async () => {

159+

mockChunksRef.chunks = [

160+

makeToolCallChunk("call_1", "bash", '{"cmd":"ls"}'),

161+

makeFinishChunk("tool_calls"),

162+

];

163+164+

const stream = streamOpenAICompletions(model, context, {

165+

apiKey: "sk-test",

166+

});

167+

const result = await stream.result();

168+169+

expect(result.stopReason).toBe("toolUse");

170+

const toolCalls = result.content.filter((b) => b.type === "toolCall");

171+

expect(toolCalls).toHaveLength(1);

172+

});

173+174+

it("strips toolCall blocks when finish_reason is length but tool_calls were accumulated", async () => {

175+

mockChunksRef.chunks = [

176+

makeToolCallChunk("call_1", "bash", '{"cmd":"ls"}'),

177+

makeFinishChunk("length"),

178+

];

179+180+

const stream = streamOpenAICompletions(model, context, {

181+

apiKey: "sk-test",

182+

});

183+

const result = await stream.result();

184+185+

expect(result.stopReason).toBe("length");

186+

expect(result.content.filter((b) => b.type === "toolCall")).toStrictEqual([]);

187+

});

188+189+

it("downgrades toolUse stop reason when finish_reason is tool_calls but no tool_calls accumulated", async () => {

190+

mockChunksRef.chunks = [makeTextChunk("Just text"), makeFinishChunk("tool_calls")];

191+192+

const stream = streamOpenAICompletions(model, context, {

193+

apiKey: "sk-test",

194+

});

195+

const result = await stream.result();

196+197+

expect(result.stopReason).toBe("stop");

198+

expect(result.content.filter((b) => b.type === "toolCall")).toStrictEqual([]);

199+

});

200+

});