惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

雷峰网
雷峰网
爱范儿
爱范儿
宝玉的分享
宝玉的分享
Apple Machine Learning Research
Apple Machine Learning Research
博客园 - Franky
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
博客园 - 三生石上(FineUI控件)
人人都是产品经理
人人都是产品经理
阮一峰的网络日志
阮一峰的网络日志
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
Last Week in AI
Last Week in AI
博客园 - 聂微东
大猫的无限游戏
大猫的无限游戏
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
罗磊的独立博客
博客园 - 叶小钗
WordPress大学
WordPress大学
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
酷 壳 – CoolShell
酷 壳 – CoolShell
小众软件
小众软件
博客园 - 司徒正美
博客园 - 【当耐特】
IT之家
IT之家

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(diffs): continue after card hydration errors (#84775)...
cosmopolitan · 2026-05-23 · via Recent Commits to openclaw:main

@@ -1,13 +1,74 @@

1+

/* @vitest-environment jsdom */

2+13

import { readFileSync } from "node:fs";

2-

import { describe, expect, it } from "vitest";

4+

import path from "node:path";

5+

import { beforeEach, describe, expect, it, vi } from "vitest";

6+7+

const disableAutoStartKey = Symbol.for("openclaw.diffs.disableAutoStart");

8+

(globalThis as typeof globalThis & Record<symbol, unknown>)[disableAutoStartKey] = true;

39410

const VIEWER_CLIENT_SRC = readFileSync(

5-

new URL("./viewer-client.ts", import.meta.url),

11+

path.join(process.cwd(), "extensions/diffs/src/viewer-client.ts"),

612

"utf8",

713

);

814915

const XSS_PATTERNS = ["onerror", "<script", "onclick", "javascript:", "onload"];

101617+

const {

18+

fileDiffHydrateMock,

19+

fileDiffRerenderMock,

20+

fileDiffSetOptionsMock,

21+

preloadHighlighterMock,

22+

} = vi.hoisted(() => ({

23+

fileDiffHydrateMock: vi.fn(),

24+

fileDiffRerenderMock: vi.fn(),

25+

fileDiffSetOptionsMock: vi.fn(),

26+

preloadHighlighterMock: vi.fn(async () => undefined),

27+

}));

28+29+

vi.mock("@pierre/diffs", () => ({

30+

FileDiff: class {

31+

hydrate(params: unknown) {

32+

return fileDiffHydrateMock(params);

33+

}

34+

rerender() {

35+

return fileDiffRerenderMock();

36+

}

37+

setOptions(params: unknown) {

38+

return fileDiffSetOptionsMock(params);

39+

}

40+

},

41+

preloadHighlighter: preloadHighlighterMock,

42+

}));

43+44+

const viewerPayload = JSON.stringify({

45+

prerenderedHTML: "<div>diff</div>",

46+

options: {

47+

theme: { light: "pierre-light", dark: "pierre-dark" },

48+

diffStyle: "unified",

49+

diffIndicators: "bars",

50+

disableLineNumbers: false,

51+

expandUnchanged: false,

52+

themeType: "dark",

53+

backgroundEnabled: true,

54+

overflow: "wrap",

55+

unsafeCSS: "",

56+

},

57+

langs: ["text"],

58+

oldFile: { fileName: "a.ts", lang: "text", content: "old" },

59+

newFile: { fileName: "a.ts", lang: "text", content: "new" },

60+

});

61+62+

function renderCard(): void {

63+

document.body.insertAdjacentHTML(

64+

"beforeend",

65+

`<section class="oc-diff-card">

66+

<div data-openclaw-diff-host></div>

67+

<script type="application/json" data-openclaw-diff-payload>${viewerPayload}</script>

68+

</section>`,

69+

);

70+

}

71+1172

describe("createToolbarButton icon safety", () => {

1273

it("toolbarIconSvg map exists and has exactly 8 icon names", () => {

1374

const requiredNames = [

@@ -58,3 +119,57 @@ describe("createToolbarButton icon safety", () => {

58119

}

59120

});

60121

});

122+123+

describe("hydrateViewer", () => {

124+

beforeEach(() => {

125+

document.body.innerHTML = "";

126+

delete document.documentElement.dataset.openclawDiffsError;

127+

delete document.documentElement.dataset.openclawDiffsReady;

128+

vi.clearAllMocks();

129+

});

130+131+

it("continues hydrating later cards when one card throws", async () => {

132+

const warn = vi.spyOn(console, "warn").mockImplementation(() => undefined);

133+

renderCard();

134+

renderCard();

135+

fileDiffHydrateMock.mockImplementationOnce(() => {

136+

throw new Error("broken card");

137+

});

138+

const { controllers, hydrateViewer } = await import("./viewer-client.js");

139+

controllers.splice(0);

140+141+

await hydrateViewer();

142+143+

expect(fileDiffHydrateMock).toHaveBeenCalledTimes(2);

144+

expect(controllers).toHaveLength(1);

145+

expect(warn).toHaveBeenCalledWith(

146+

"Skipping diff card that failed to hydrate",

147+

expect.any(Error),

148+

);

149+

expect(document.documentElement.dataset.openclawDiffsError).toBeUndefined();

150+

warn.mockRestore();

151+

});

152+153+

it("does not retain controllers when initial state application throws", async () => {

154+

const warn = vi.spyOn(console, "warn").mockImplementation(() => undefined);

155+

renderCard();

156+

renderCard();

157+

fileDiffSetOptionsMock.mockImplementationOnce(() => {

158+

throw new Error("broken options");

159+

});

160+

const { controllers, hydrateViewer } = await import("./viewer-client.js");

161+

controllers.splice(0);

162+163+

await hydrateViewer();

164+165+

expect(fileDiffHydrateMock).toHaveBeenCalledTimes(2);

166+

expect(fileDiffSetOptionsMock).toHaveBeenCalledTimes(2);

167+

expect(controllers).toHaveLength(1);

168+

expect(warn).toHaveBeenCalledWith(

169+

"Skipping diff card that failed to hydrate",

170+

expect.any(Error),

171+

);

172+

expect(document.documentElement.dataset.openclawDiffsError).toBeUndefined();

173+

warn.mockRestore();

174+

});

175+

});