惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

博客园 - Franky
N
Netflix TechBlog - Medium
宝玉的分享
宝玉的分享
Google DeepMind News
Google DeepMind News
腾讯CDC
G
Google Developers Blog
Martin Fowler
Martin Fowler
Microsoft Security Blog
Microsoft Security Blog
Recent Announcements
Recent Announcements
爱范儿
爱范儿
Engineering at Meta
Engineering at Meta
Microsoft Azure Blog
Microsoft Azure Blog
A
About on SuperTechFans
aimingoo的专栏
aimingoo的专栏
有赞技术团队
有赞技术团队
Jina AI
Jina AI
人人都是产品经理
人人都是产品经理
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
M
MIT News - Artificial intelligence
罗磊的独立博客
博客园 - 三生石上(FineUI控件)
美团技术团队
WordPress大学
WordPress大学
阮一峰的网络日志
阮一峰的网络日志

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(feishu): resolve card-action chat type before dispatc...
drobison00 · 2026-04-18 · via Recent Commits to openclaw:main

@@ -2,6 +2,7 @@ import type { ClawdbotConfig, RuntimeEnv } from "../runtime-api.js";

22

import { resolveFeishuRuntimeAccount } from "./accounts.js";

33

import { handleFeishuMessage, type FeishuMessageEvent } from "./bot.js";

44

import { decodeFeishuCardAction, buildFeishuCardActionTextFallback } from "./card-interaction.js";

5+

import { createFeishuClient } from "./client.js";

56

import {

67

createApprovalCard,

78

FEISHU_APPROVAL_CANCEL_ACTION,

@@ -104,7 +105,7 @@ function releaseFeishuCardActionToken(params: { token: string; accountId: string

104105

function buildSyntheticMessageEvent(

105106

event: FeishuCardActionEvent,

106107

content: string,

107-

chatType?: "p2p" | "group",

108+

chatType: "p2p" | "group",

108109

): FeishuMessageEvent {

109110

return {

110111

sender: {

@@ -117,7 +118,7 @@ function buildSyntheticMessageEvent(

117118

message: {

118119

message_id: `card-action-${event.token}`,

119120

chat_id: event.context.chat_id || event.operator.open_id,

120-

chat_type: chatType ?? (event.context.chat_id ? "group" : "p2p"),

121+

chat_type: chatType,

121122

message_type: "text",

122123

content: JSON.stringify({ text: content }),

123124

},

@@ -136,20 +137,124 @@ async function dispatchSyntheticCommand(params: {

136137

cfg: ClawdbotConfig;

137138

event: FeishuCardActionEvent;

138139

command: string;

140+

account: ReturnType<typeof resolveFeishuRuntimeAccount>;

139141

botOpenId?: string;

140142

runtime?: RuntimeEnv;

141143

accountId?: string;

142144

chatType?: "p2p" | "group";

143145

}): Promise<void> {

146+

const resolvedChatType = await resolveCardActionChatType({

147+

event: params.event,

148+

account: params.account,

149+

chatType: params.chatType,

150+

log: params.runtime?.log ?? console.log,

151+

});

144152

await handleFeishuMessage({

145153

cfg: params.cfg,

146-

event: buildSyntheticMessageEvent(params.event, params.command, params.chatType),

154+

event: buildSyntheticMessageEvent(params.event, params.command, resolvedChatType),

147155

botOpenId: params.botOpenId,

148156

runtime: params.runtime,

149157

accountId: params.accountId,

150158

});

151159

}

152160161+

// Feishu's im.chat.get returns two fields:

162+

// chat_mode: conversation type — "p2p" | "group" | "topic"

163+

// chat_type: privacy classification — "private" | "public"

164+

// We check chat_mode first because it directly indicates conversation type.

165+

// "private" maps to "p2p" as the safe-failure direction (restrictive DM

166+

// policy) — a private group chat misclassified as p2p is safer than the

167+

// reverse. "topic" and "public" are treated as group semantics.

168+

function normalizeResolvedCardActionChatType(value: unknown): "p2p" | "group" | undefined {

169+

if (value === "group" || value === "topic" || value === "public") {

170+

return "group";

171+

}

172+

if (value === "p2p" || value === "private") {

173+

return "p2p";

174+

}

175+

return undefined;

176+

}

177+178+

const resolvedChatTypeCache = new Map<string, { value: "p2p" | "group"; expiresAt: number }>();

179+

const CHAT_TYPE_CACHE_TTL_MS = 30 * 60_000;

180+

const CHAT_TYPE_CACHE_MAX_SIZE = 5_000;

181+182+

function pruneChatTypeCache(now: number): void {

183+

for (const [key, entry] of resolvedChatTypeCache.entries()) {

184+

if (entry.expiresAt <= now) {

185+

resolvedChatTypeCache.delete(key);

186+

}

187+

}

188+

if (resolvedChatTypeCache.size > CHAT_TYPE_CACHE_MAX_SIZE) {

189+

const excess = resolvedChatTypeCache.size - CHAT_TYPE_CACHE_MAX_SIZE;

190+

const iter = resolvedChatTypeCache.keys();

191+

for (let i = 0; i < excess; i++) {

192+

const key = iter.next().value;

193+

if (key !== undefined) {

194+

resolvedChatTypeCache.delete(key);

195+

}

196+

}

197+

}

198+

}

199+200+

function sanitizeLogValue(v: string): string {

201+

return v.replace(/[\r\n]/g, " ").slice(0, 500);

202+

}

203+204+

async function resolveCardActionChatType(params: {

205+

event: FeishuCardActionEvent;

206+

account: ReturnType<typeof resolveFeishuRuntimeAccount>;

207+

chatType?: "p2p" | "group";

208+

log: (message: string) => void;

209+

}): Promise<"p2p" | "group"> {

210+

const explicitChatType = normalizeResolvedCardActionChatType(params.chatType);

211+

if (explicitChatType) {

212+

return explicitChatType;

213+

}

214+215+

const chatId = params.event.context.chat_id?.trim();

216+

if (!chatId) {

217+

return "p2p";

218+

}

219+220+

const cacheKey = `${params.account.accountId}:${chatId}`;

221+

const now = Date.now();

222+

pruneChatTypeCache(now);

223+

const cached = resolvedChatTypeCache.get(cacheKey);

224+

if (cached) {

225+

return cached.value;

226+

}

227+228+

try {

229+

const response = (await createFeishuClient(params.account).im.chat.get({

230+

path: { chat_id: chatId },

231+

})) as { code?: number; msg?: string; data?: { chat_type?: unknown; chat_mode?: unknown } };

232+

if (response.code === 0) {

233+

const resolvedChatType =

234+

normalizeResolvedCardActionChatType(response.data?.chat_mode) ??

235+

normalizeResolvedCardActionChatType(response.data?.chat_type);

236+

if (resolvedChatType) {

237+

resolvedChatTypeCache.set(cacheKey, { value: resolvedChatType, expiresAt: now + CHAT_TYPE_CACHE_TTL_MS });

238+

return resolvedChatType;

239+

}

240+

params.log(

241+

`feishu[${params.account.accountId}]: card action missing chat type for chat; defaulting to p2p`,

242+

);

243+

} else {

244+

params.log(

245+

`feishu[${params.account.accountId}]: failed to resolve chat type: ${sanitizeLogValue(response.msg ?? "unknown error")}; defaulting to p2p`,

246+

);

247+

}

248+

} catch (err) {

249+

const message = err instanceof Error ? err.message : "unknown";

250+

params.log(

251+

`feishu[${params.account.accountId}]: failed to resolve chat type: ${sanitizeLogValue(message)}; defaulting to p2p`,

252+

);

253+

}

254+255+

return "p2p";

256+

}

257+153258

async function sendInvalidInteractionNotice(params: {

154259

cfg: ClawdbotConfig;

155260

event: FeishuCardActionEvent;

@@ -246,7 +351,12 @@ export async function handleFeishuCardAction(params: {

246351

prompt,

247352

sessionKey: envelope.c?.s,

248353

expiresAt: Date.now() + FEISHU_APPROVAL_CARD_TTL_MS,

249-

chatType: envelope.c?.t ?? (event.context.chat_id ? "group" : "p2p"),

354+

chatType: await resolveCardActionChatType({

355+

event,

356+

account,

357+

chatType: envelope.c?.t,

358+

log,

359+

}),

250360

confirmLabel: command === "/reset" ? "Reset" : "Confirm",

251361

}),

252362

accountId,

@@ -282,10 +392,11 @@ export async function handleFeishuCardAction(params: {

282392

cfg,

283393

event,

284394

command,

395+

account,

285396

botOpenId: params.botOpenId,

286397

runtime,

287398

accountId,

288-

chatType: envelope.c?.t ?? (event.context.chat_id ? "group" : "p2p"),

399+

chatType: envelope.c?.t,

289400

});

290401

completeFeishuCardActionToken({ token: event.token, accountId: account.accountId });

291402

return;

@@ -311,6 +422,7 @@ export async function handleFeishuCardAction(params: {

311422

cfg,

312423

event,

313424

command: content,

425+

account,

314426

botOpenId: params.botOpenId,

315427

runtime,

316428

accountId,