惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

D
Docker
I
InfoQ
L
LangChain Blog
阮一峰的网络日志
阮一峰的网络日志
Y
Y Combinator Blog
博客园_首页
Martin Fowler
Martin Fowler
宝玉的分享
宝玉的分享
A
About on SuperTechFans
Apple Machine Learning Research
Apple Machine Learning Research
Vercel News
Vercel News
T
The Blog of Author Tim Ferriss
C
Check Point Blog
B
Blog RSS Feed
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
Engineering at Meta
Engineering at Meta
B
Blog
爱范儿
爱范儿
Stack Overflow Blog
Stack Overflow Blog
aimingoo的专栏
aimingoo的专栏
WordPress大学
WordPress大学
F
Fortinet All Blogs
月光博客
月光博客
GbyAI
GbyAI

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
test(qa): resolve Matrix target-both approvals via gatewa...
vincentkoc · 2026-05-04 · via Recent Commits to openclaw:main

@@ -224,6 +224,14 @@ function assertApprovalDecisionResult(params: {

224224

}

225225

}

226226227+

function assertApprovalResolveResult(result: unknown) {

228+

const resolved =

229+

typeof result === "object" && result !== null ? (result as { ok?: unknown }) : null;

230+

if (resolved?.ok !== true) {

231+

throw new Error(`approval resolve result was ${formatApprovalResultValue(result)}`);

232+

}

233+

}

234+227235

function formatApprovalResultValue(value: unknown) {

228236

if (typeof value === "string" || typeof value === "number" || typeof value === "boolean") {

229237

return String(value);

@@ -305,6 +313,24 @@ async function waitForApprovalDecision(params: {

305313

);

306314

}

307315316+

async function resolveApprovalDecision(params: {

317+

approvalId: string;

318+

context: MatrixQaScenarioContext;

319+

decision: MatrixQaApprovalDecision;

320+

kind: MatrixQaApprovalKind;

321+

}) {

322+

const gatewayCall = requireMatrixQaGatewayCall(params.context);

323+

const method = params.kind === "exec" ? "exec.approval.resolve" : "plugin.approval.resolve";

324+

return await gatewayCall(

325+

method,

326+

{ decision: params.decision, id: params.approvalId },

327+

{

328+

expectFinal: true,

329+

timeoutMs: MATRIX_QA_APPROVAL_DECISION_TIMEOUT_MS + 5_000,

330+

},

331+

);

332+

}

333+308334

function readAcceptedApprovalRequest(result: unknown) {

309335

const accepted =

310336

typeof result === "object" && result !== null

@@ -563,22 +589,13 @@ export async function runApprovalChannelTargetBothScenario(context: MatrixQaScen

563589

if (channelApproval.event.approval?.id !== dmApproval.event.approval?.id) {

564590

throw new Error("target=both delivered different approval ids to channel and DM");

565591

}

566-

const reaction = await reactToApproval({

567-

context,

568-

decision: "allow-once",

569-

roomId: context.roomId,

570-

targetEventId: channelApproval.event.eventId,

571-

});

572-

const result = await waitForApprovalDecision({

592+

const result = await resolveApprovalDecision({

573593

approvalId,

574594

context,

575-

kind: "exec",

576-

});

577-

assertApprovalDecisionResult({

578-

approvalId,

579595

decision: "allow-once",

580-

result,

596+

kind: "exec",

581597

});

598+

assertApprovalResolveResult(result);

582599

const lateDuplicate = await client.waitForOptionalRoomEvent({

583600

observedEvents: context.observedEvents,

584601

predicate: (event) =>

@@ -599,16 +616,14 @@ export async function runApprovalChannelTargetBothScenario(context: MatrixQaScen

599616

buildMatrixApprovalArtifact(channelApproval.event),

600617

buildMatrixApprovalArtifact(dmApproval.event),

601618

],

602-

reactionEmoji: reaction.reaction?.key,

603-

reactionEventId: reaction.eventId,

604-

reactionTargetEventId: reaction.reaction?.eventId,

619+

resolveResult: result,

605620

token,

606621

},

607622

details: [

608623

`channel approval event: ${channelApproval.event.eventId}`,

609624

`dm approval event: ${dmApproval.event.eventId}`,

610625

`approval id: ${approvalId}`,

611-

`decision: allow-once`,

626+

`decision: allow-once via gateway resolve`,

612627

].join("\n"),

613628

} satisfies MatrixQaScenarioExecution;

614629

}