惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

V
Visual Studio Blog
量子位
大猫的无限游戏
大猫的无限游戏
Hugging Face - Blog
Hugging Face - Blog
S
SegmentFault 最新的问题
Blog — PlanetScale
Blog — PlanetScale
月光博客
月光博客
Google DeepMind News
Google DeepMind News
小众软件
小众软件
WordPress大学
WordPress大学
宝玉的分享
宝玉的分享
MongoDB | Blog
MongoDB | Blog
B
Blog RSS Feed
博客园 - Franky
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
B
Blog
博客园 - 聂微东
The GitHub Blog
The GitHub Blog
Recent Announcements
Recent Announcements
Y
Y Combinator Blog
Microsoft Security Blog
Microsoft Security Blog
雷峰网
雷峰网
Jina AI
Jina AI
酷 壳 – CoolShell
酷 壳 – CoolShell

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(cron): retire bundled mcp runtimes · openclaw/opencla...
steipete · 2026-04-23 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -22,6 +22,7 @@ Docs: https://docs.openclaw.ai

2222

- Config/gateway: recover configs accidentally prefixed with non-JSON output during gateway startup or `openclaw doctor --fix`, preserving the clobbered file as a backup while leaving normal config reads read-only.

2323

- Pi embedded runs: pass real built-in tools into Pi session creation and then narrow active tool names after custom tool registration, so the runner and compaction paths compile cleanly and keep OpenClaw-managed custom tool allowlists without feeding string arrays into `createAgentSession`. Thanks @vincentkoc.

2424

- Agents/OpenAI websocket: route native OpenAI websocket metadata and session-header decisions through the shared endpoint classifier so local mocks and custom `models.providers.openai.baseUrl` endpoints stay out of the native OpenAI path consistently across embedded-runner and websocket transport code. Thanks @vincentkoc.

25+

- Cron/MCP: retire bundled MCP runtimes through one shared cleanup path for isolated cron run ends, persistent cron session rollover, and direct cron `deleteAfterRun` fallback cleanup. Fixes #69145, #68623, and #68827.

2526

- MCP/gateway: tear down stdio MCP process trees on transport close and dispose bundled MCP runtimes during session delete/reset, preventing orphaned wrapper/server processes from accumulating. Fixes #68809 and #69465.

2627

- Config: render validation warnings with real line breaks instead of a literal `\n` sequence in CLI/audit output. Fixes #70140.

2728

- Cron/doctor: repair malformed persisted cron job IDs through `openclaw doctor`, including legacy `jobId`, non-string `id`, and missing `id` rows, so `cron list` no longer needs display-layer coercion for corrupt store data. Fixes #70128.

Original file line numberDiff line numberDiff line change

@@ -1,6 +1,11 @@

11

import { afterEach, describe, expect, it, vi } from "vitest";

22

import { cleanupBundleMcpHarness } from "./pi-bundle-mcp-test-harness.js";

3-

import { __testing, materializeBundleMcpToolsForRun } from "./pi-bundle-mcp-tools.js";

3+

import {

4+

__testing,

5+

getOrCreateSessionMcpRuntime,

6+

materializeBundleMcpToolsForRun,

7+

retireSessionMcpRuntime,

8+

} from "./pi-bundle-mcp-tools.js";

49

import type { SessionMcpRuntime } from "./pi-bundle-mcp-types.js";

510
611

vi.mock("./embedded-pi-mcp.js", () => ({

@@ -298,4 +303,20 @@ describe("session MCP runtime", () => {

298303

expect((result.error as Error).message).toMatch(/disposed/);

299304

expect(manager.listSessionIds()).not.toContain("session-d");

300305

});

306+
307+

it("retires global session runtimes and ignores missing ids", async () => {

308+

await getOrCreateSessionMcpRuntime({

309+

sessionId: "session-retire",

310+

sessionKey: "agent:test:session-retire",

311+

workspaceDir: "/workspace",

312+

});

313+

expect(__testing.getCachedSessionIds()).toContain("session-retire");

314+
315+

await expect(

316+

retireSessionMcpRuntime({ sessionId: " session-retire ", reason: "test" }),

317+

).resolves.toBe(true);

318+

expect(__testing.getCachedSessionIds()).not.toContain("session-retire");

319+
320+

await expect(retireSessionMcpRuntime({ sessionId: " ", reason: "test" })).resolves.toBe(false);

321+

});

301322

});

Original file line numberDiff line numberDiff line change

@@ -436,6 +436,24 @@ export async function disposeSessionMcpRuntime(sessionId: string): Promise<void>

436436

await getSessionMcpRuntimeManager().disposeSession(sessionId);

437437

}

438438
439+

export async function retireSessionMcpRuntime(params: {

440+

sessionId?: string | null;

441+

reason: string;

442+

onError?: (error: unknown, sessionId: string, reason: string) => void;

443+

}): Promise<boolean> {

444+

const sessionId = normalizeOptionalString(params.sessionId);

445+

if (!sessionId) {

446+

return false;

447+

}

448+

try {

449+

await disposeSessionMcpRuntime(sessionId);

450+

return true;

451+

} catch (error) {

452+

params.onError?.(error, sessionId, params.reason);

453+

return false;

454+

}

455+

}

456+
439457

export async function disposeAllSessionMcpRuntimes(): Promise<void> {

440458

await getSessionMcpRuntimeManager().disposeAll();

441459

}

Original file line numberDiff line numberDiff line change

@@ -13,6 +13,7 @@ export {

1313

disposeSessionMcpRuntime,

1414

getOrCreateSessionMcpRuntime,

1515

getSessionMcpRuntimeManager,

16+

retireSessionMcpRuntime,

1617

} from "./pi-bundle-mcp-runtime.js";

1718

export {

1819

createBundleMcpToolRuntime,

Original file line numberDiff line numberDiff line change

@@ -33,6 +33,7 @@ let streamCallCount = 0;

3333

let observedContexts: Array<Array<{ role?: string; content?: unknown }>> = [];

3434
3535

vi.mock("./pi-bundle-mcp-tools.js", () => ({

36+

retireSessionMcpRuntime: vi.fn(async () => true),

3637

getOrCreateSessionMcpRuntime: async () => ({

3738

sessionId: "bundle-mcp-runtime",

3839

sessionKey: "agent:test:bundle-mcp-e2e",

Original file line numberDiff line numberDiff line change

@@ -111,6 +111,8 @@ const installRunEmbeddedMocks = () => {

111111

}));

112112

vi.doMock("./pi-bundle-mcp-tools.js", () => ({

113113

disposeSessionMcpRuntime: (sessionId: string) => disposeSessionMcpRuntimeMock(sessionId),

114+

retireSessionMcpRuntime: ({ sessionId }: { sessionId?: string | null }) =>

115+

sessionId ? disposeSessionMcpRuntimeMock(sessionId) : Promise.resolve(false),

114116

}));

115117

vi.doMock("./pi-embedded-runner/model.js", async () => {

116118

const actual = await vi.importActual<typeof import("./pi-embedded-runner/model.js")>(

Original file line numberDiff line numberDiff line change

@@ -336,6 +336,7 @@ export async function loadCompactHooksHarness(): Promise<{

336336

}));

337337
338338

vi.doMock("../pi-bundle-mcp-tools.js", () => ({

339+

retireSessionMcpRuntime: vi.fn(async () => true),

339340

createBundleMcpToolRuntime: vi.fn(async () => ({

340341

tools: [],

341342

dispose: vi.fn(async () => {}),

Original file line numberDiff line numberDiff line change

@@ -50,7 +50,7 @@ import {

5050

} from "../model-auth.js";

5151

import { normalizeProviderId } from "../model-selection.js";

5252

import { ensureOpenClawModelsJson } from "../models-config.js";

53-

import { disposeSessionMcpRuntime } from "../pi-bundle-mcp-tools.js";

53+

import { retireSessionMcpRuntime } from "../pi-bundle-mcp-tools.js";

5454

import {

5555

classifyFailoverReason,

5656

extractObservedOverflowTokenCount,

@@ -2130,10 +2130,14 @@ export async function runEmbeddedPiAgent(

21302130

await contextEngine.dispose?.();

21312131

stopRuntimeAuthRefreshTimer();

21322132

if (params.cleanupBundleMcpOnRunEnd === true) {

2133-

await disposeSessionMcpRuntime(params.sessionId).catch((error) => {

2134-

log.warn(

2135-

`bundle-mcp cleanup failed after run for ${params.sessionId}: ${formatErrorMessage(error)}`,

2136-

);

2133+

await retireSessionMcpRuntime({

2134+

sessionId: params.sessionId,

2135+

reason: "embedded-run-end",

2136+

onError: (error, sessionId) => {

2137+

log.warn(

2138+

`bundle-mcp cleanup failed after run for ${sessionId}: ${formatErrorMessage(error)}`,

2139+

);

2140+

},

21372141

});

21382142

}

21392143

}

Original file line numberDiff line numberDiff line change

@@ -424,6 +424,7 @@ vi.mock("../../pi-bundle-mcp-tools.js", () => ({

424424

createBundleMcpToolRuntime: async () => undefined,

425425

getOrCreateSessionMcpRuntime: async () => undefined,

426426

materializeBundleMcpToolsForRun: async () => undefined,

427+

retireSessionMcpRuntime: async () => true,

427428

}));

428429
429430

vi.mock("../../pi-bundle-lsp-runtime.js", () => ({

Original file line numberDiff line numberDiff line change

@@ -4,7 +4,7 @@ import { resolveSessionAgentId } from "../../agents/agent-scope.js";

44

import { clearBootstrapSnapshotOnSessionRollover } from "../../agents/bootstrap-cache.js";

55

import { getCliSessionBinding } from "../../agents/cli-session.js";

66

import { resetRegisteredAgentHarnessSessions } from "../../agents/harness/registry.js";

7-

import { disposeSessionMcpRuntime } from "../../agents/pi-bundle-mcp-tools.js";

7+

import { retireSessionMcpRuntime } from "../../agents/pi-bundle-mcp-tools.js";

88

import { normalizeChatType } from "../../channels/chat-type.js";

99

import { resolveGroupSessionKey } from "../../config/sessions/group.js";

1010

import { canonicalizeMainSessionAlias } from "../../config/sessions/main-session.js";

@@ -815,13 +815,14 @@ export async function initSessionState(params: {

815815

agentId,

816816

archivedTranscripts,

817817

});

818-

await disposeSessionMcpRuntime(previousSessionEntry.sessionId).catch((error) => {

819-

log.warn(

820-

`failed to dispose bundle MCP runtime for session ${previousSessionEntry.sessionId}`,

821-

{

818+

await retireSessionMcpRuntime({

819+

sessionId: previousSessionEntry.sessionId,

820+

reason: "reply-session-rollover",

821+

onError: (error, sessionId) => {

822+

log.warn(`failed to dispose bundle MCP runtime for session ${sessionId}`, {

822823

error: String(error),

823-

},

824-

);

824+

});

825+

},

825826

});

826827

await resetRegisteredAgentHarnessSessions({

827828

sessionId: previousSessionEntry.sessionId,