Originally published on lavkesh.com

I was working on a project with a tight deadline when my team lead asked me to review a colleague's code. The code had inconsistent naming conventions, duplicated logic, and no comments. I wrote a scathing review, pointing out all the flaws and suggesting that the code be rewritten from scratch.

My colleague was defensive and hurt by my feedback, and the team lead had to intervene to calm the situation. I realized I had been too harsh and that my feedback had not been constructive. I had focused on criticizing the code rather than helping my colleague improve.

I learned a valuable lesson from that experience. When giving feedback, it's essential to be specific, objective, and respectful. Instead of criticizing the code, I should have focused on suggesting improvements and offering help. I should have also considered the context and the constraints that my colleague was working under.

Since then, I've made a conscious effort to give feedback that is constructive and respectful. I've also learned to receive feedback graciously, even when it's critical. I've come to realize that feedback is an opportunity to learn and grow, rather than a personal attack.

I use the sandwich method, where I start with something positive, followed by constructive feedback, and end with something positive. This approach helps to soften the blow and makes the feedback more palatable. I also focus on the behavior or the code, rather than the person.

Instead of saying 'you're a bad coder', I say 'this code can be improved by...'. This approach helps to avoid defensiveness and promotes a more constructive conversation. I've also learned to ask questions and seek clarification when receiving feedback.

This helps to ensure that I understand the feedback and can act on it. Feedback is not a one-time event, but an ongoing process. It's essential to follow up and check in with my colleagues to see how they're progressing and if they need any further help or guidance.

Giving and receiving feedback is an essential part of being a good engineer and a good team player. It's not always easy, but it's a crucial part of growing and improving. I've been fortunate to have had colleagues and team leads who have taught me the value of feedback and how to give and receive it effectively.

I've seen the impact that constructive feedback can have on a team. It can boost morale, improve collaboration, and lead to better outcomes. I've also seen how destructive feedback can be, leading to defensiveness, hurt feelings, and a breakdown in communication. I'm committed to continuing to learn and grow, and to helping my colleagues do the same.

I believe that feedback is a key part of that process, and I'm excited to see the positive impact that it can have. My experience has taught me that feedback is essential for growth and improvement, and I hope that my experience can help others to learn from their mistakes and become better engineers and team players.