惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Y
Y Combinator Blog
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
博客园_首页
量子位
V
Visual Studio Blog
博客园 - Franky
宝玉的分享
宝玉的分享
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
博客园 - 【当耐特】
罗磊的独立博客
小众软件
小众软件
V
V2EX
GbyAI
GbyAI
B
Blog RSS Feed
博客园 - 三生石上(FineUI控件)
大猫的无限游戏
大猫的无限游戏
有赞技术团队
有赞技术团队
月光博客
月光博客
Recent Announcements
Recent Announcements
雷峰网
雷峰网
F
Fortinet All Blogs
M
MIT News - Artificial intelligence

jdhao's digital space

Conversion between base64 and OpenCV or PIL Image 腾讯云对象存储博客图床开启 CDN 加速(不需要购买额外域名) Search and Replace in Multiple Files in Vim/Neovim Change Table Column Width in LaTeX Image or Table Side by Side in LaTeX LaTeX 并排显示图像或表格 Firenvim: Neovim inside Your Browser Content inside HTML tags missing in Latest Hugo? Creating Markdown Front Matter with Ultisnips Labelme JSON 标注格式转 voc XML 格式 Nifty Nvim Techniques That Make My Life Easier -- Series 6 macOS 下如何为视频制作字幕 Running Command Asynchronously inside Neovim Resolving Merge Conflict after Git Stash Pop Pylint: command not found? A Hands-on Experience with Neovim's Built-in LSP Support How to Convert PDF to Images with Imagemagick 互联网上常用缩略语集锦 File Backup in Neovim Converting PDF Pages to Images with Poppler Nifty Nvim Techniques That Make My Life Easier -- Series 5 Neovim Configuration for System-wide Use How to sort a list of tuple or list in Python -- lambda or itemgetter? Building A Vim Statusline from Scratch 人类第一颗原子弹爆炸始末 Distributed Training in PyTorch with Horovod Learning Expect Programming Essential Knowledge about SSH Nifty LaTeX Techniques -- Series 1 更改 Adsense 邮寄地址,重新寄送 PIN
A Tutorial on Creating GitHub Pull Requests
2018-05-06 · via jdhao's digital space

Today I make my first ever GitHub pull request to the great Hexo theme NexT. I will summarize how to make a pull request in following post.

Creating a fork#

According to GitHub documentation:

If you don’t have write access to the repository where you’d like to create a pull request, you must create a fork, or copy, of the repository first.

If you do not have write access to the repository you want to contribute to, the first step is to fork it. A fork means a complete copy of the original repository. But now you can do whatever you want on the fork without permission from the maintainer of the original repo.

It is easy to fork a public repository. Take the theme NexT for an example. Go to theme NexT’s GitHub repo, and click the “fork” button on the upper right to fork it.

Now I have a forked repo of the original repo. The address of the forked repo is https://github.com/jdhao/hexo-theme-next.

Create a local clone of your forked repo#

If you want to start working on your forked repo, first you need to create a local clone the forked repo. Go to the forked repo in GitHub, and copy its address (see image below).

On the command line, use the following command to clone the forked repo:

git clone https://github.com/jdhao/hexo-theme-next.git # replace this address with your actual address

After a while, the forked remote repo will be copied to your local computer. The folder name is hexo-theme-next.

Add original remote repo as one of your remote#

In order to communicate with the original remote repo, we need to add it as one of our remote repo. Before that, your remote repo is only the forked remote repo. Use the following command to confirm that:

cd hexo-theme-next && git remote -v

You will see something like:

origin https://github.com/jdhao/hexo-theme-next.git (fetch) origin https://github.com/jdhao/hexo-theme-next.git (push)

In the above output, origin means your forked remote repo. Then go to the original remote and copy its address, just as we do for the forked remote. We then add the original remote as upstream:

 git remote add upstream  https://github.com/theme-next/hexo-theme-next.git

Now, using git remote -v again, you will see that original repo is also shown in your remote list:

origin https://github.com/jdhao/hexo-theme-next.git (fetch) origin https://github.com/jdhao/hexo-theme-next.git (push) upstream https://github.com/theme-next/hexo-theme-next.git (fetch) upstream https://github.com/theme-next/hexo-theme-next.git (push)

Make changes#

Now you can make changes in your local repo. It is good practice to only change one feature at a time and commit it. After you have finished making changes to your local repo, you should commit and push it to your forked remote.

git add .
git commit -m "change feature xxx"
git push origin master # your forked remote will be updated now

Make your pull request#

Now you can make your pull request. Go to the original repo, and click “New pull request” button,

On the Compare page, click “compare across forks”, you will see something like the following

On the left, there is “base fork”. On the right, there is “head fork”. Click the pull-down list to choose the original remote as base fork and choose your forked repo as head fork.

Then give a title to your pull request. You should also create a description according to the repo’s pull request template. Most serious projects have a pull request template. Make sure your pull request description follows their guidelines.

Finally, click the button “create pull request” on the bottom of the page to finish your pull request. Stay patient and wait for the original repo owner to review your pull request!

How to update your pull request#

As is often the case, your pull request may need some polishing before it can be merged. So how do we update our pull request with new changes? It turns out that git can do that for us “magically”!

You just need to make modifications on your local branch, commit the changes and push it to your forked remote. Now go to your pull request page, you will find that the new commit will appear at the bottom of this pull request discussion (see image below for an example).

How to sync your master with original repository#

A lot of people contribute to an open source project. After you have forked a project, other people may have committed several changes to the original repo’s master branch. How to keep your forked remote master up to date with the original repo?

You can fetch the changes from the upstream master and then merge the changes with your origin master:

git fetch upstream # fetch latest changes in upstream to your local
git checkout master # make sure that you are on local master
git merge  upstream/master # merge changes with your local master
git push origin master # push changes to your forked remote master

In the git merge stage, there may be some conflict between your master and upstream master. In order to merge, you have to resolve the conflicts. See here as a start on how to handle merge conflicts.

References#