hey all, i have updated the pkgbuild to use the tor-browser-build (tbb) tool as advised by mullvad-browser (mb) upstream and the folks here in the comments

also, please fetch keys to allow verification of sigs in sha256sums-unsigned-build.txt:

gpg --auto-key-locate nodefault,wkd --locate-keys torbrowser@torproject.org

@konvix: Have you tried building this PKGBUILD yourself in clean chroot recently?

No, but I got your point

@patlefort: It's relevant in that a pkgbuild should never request root access.

I agree

/usr/bin/core_perl is not on PATH so the use of which results in it trying to execute a header file. Calling /usr/bin/core_perl/h2ph directly, like done in patlefort patch, should make that part work.

Have you tried building this PKGBUILD yourself in clean chroot recently?

It's relevant in that a pkgbuild should never request root access.

@patlefort I'm looking into your patch, it doesn't seem to be relevant to @konvix errors though

Did you look at my patch? It removes the need to use sudo.

@konvix I fixed checksums, thanks for reporting

for h2ph that's what I get:

sudo pacman -Qo $(which h2ph) /usr/bin/core_perl/h2ph is owned by perl 5.42.2-1.1

@noureddinex mismatching checksum for sha256sums-unsigned-build.txt:

==> Validating source files with sha256sums...
    tor-browser-build ... Skipped
    sha256sums-unsigned-build.txt ... FAILED
    sha256sums-unsigned-build.txt.asc ... Skipped
    mullvad-browser.desktop ... Passed
==> ERROR: One or more files did not pass the validity check!

Ignoring that, it still fails during first step of prepare when it tries to execute syscall.h when missing makedepend h2ph can't be located:

==> Starting prepare()...
which: no h2ph in (/home/user/bin:/home/user/.local/bin/adev:/home/user/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
sudo: sys/syscall.h: command not found
==> ERROR: A failure occurred in prepare().

from sudo $(which h2ph) sys/syscall.h asm/unistd.h asm/unistd_64.h bits/syscall.h.

Able to take a look at this and the patch from patlefort below?

Package does not build anymore. This URL is now 404 after mullvad-browser 15.0.8 release: https://cdn.mullvad.net/browser/15.0.7/sha256sums-unsigned-build.txt

It will likely also need patches for compatibility with clang v22 to compile (discussed @ firefox-esr).