惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

博客园 - 三生石上(FineUI控件)
月光博客
月光博客
S
SegmentFault 最新的问题
有赞技术团队
有赞技术团队
Stack Overflow Blog
Stack Overflow Blog
Engineering at Meta
Engineering at Meta
T
The Blog of Author Tim Ferriss
The GitHub Blog
The GitHub Blog
小众软件
小众软件
Hugging Face - Blog
Hugging Face - Blog
IT之家
IT之家
宝玉的分享
宝玉的分享
A
About on SuperTechFans
Vercel News
Vercel News
P
Proofpoint News Feed
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
博客园 - 【当耐特】
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
V
Visual Studio Blog
Jina AI
Jina AI
Y
Y Combinator Blog
T
Tailwind CSS Blog
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
Last Week in AI
Last Week in AI

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(e2e): reap signaled PTY command trees · openclaw/open...
vincentkoc · 2026-06-20 · via Recent Commits to openclaw:main
11

#!/usr/bin/env node

2-

// Runs an E2E command under a pseudo-terminal.

2+

import { spawnSync } from "node:child_process";

33

import fs from "node:fs";

44

import process from "node:process";

5-

import { spawn } from "@lydell/node-pty";

5+

import { spawn as spawnPty } from "@lydell/node-pty";

66

import { readPositiveIntEnv } from "./env-limits.mjs";

7788

const [logPath, command, ...args] = process.argv.slice(2);

@@ -17,6 +17,9 @@ if (!logPath || !command) {

1717

let exiting = false;

1818

let forwardedSignal = null;

1919

let forceKillTimer = null;

20+

let terminationDrainTimer = null;

21+

let terminationPids = [];

22+

let pendingExitCode = null;

2023

let logFailed = false;

2124

const outputLimitMarker = `\n[run-with-pty output truncated after ${OUTPUT_MAX_BYTES} bytes]\n`;

2225

const outputState = {

@@ -25,7 +28,7 @@ const outputState = {

2528

};

26292730

const log = fs.createWriteStream(logPath, { flags: "w" });

28-

const pty = spawn(command, args, {

31+

const pty = spawnPty(command, args, {

2932

name: process.env.TERM || "xterm-256color",

3033

cols: readPositiveIntEnv("COLUMNS", 120),

3134

rows: readPositiveIntEnv("LINES", 40),

@@ -43,11 +46,7 @@ log.on("error", (error) => {

4346

process.exit(1);

4447

}

4548

if (!exiting) {

46-

pty.kill("SIGTERM");

47-

forceKillTimer ??= setTimeout(() => {

48-

pty.kill("SIGKILL");

49-

}, FORCE_KILL_MS);

50-

forceKillTimer.unref?.();

49+

terminatePtyTree("SIGTERM");

5150

}

5251

});

5352

@@ -86,18 +85,23 @@ pty.onData((data) => {

86858786

pty.onExit(({ exitCode, signal }) => {

8887

exiting = true;

89-

clearTimeout(forceKillTimer);

88+

if (terminationPids.length === 0) {

89+

clearTerminationTimers();

90+

}

9091

if (logFailed) {

91-

process.exit(1);

92+

exitWhenTerminationDrains(1);

93+

return;

9294

}

9395

log.end(() => {

9496

if (forwardedSignal) {

95-

process.exit(signalExitCode(forwardedSignal));

97+

exitWhenTerminationDrains(signalExitCode(forwardedSignal));

98+

return;

9699

}

97100

if (typeof exitCode === "number") {

98-

process.exit(exitCode);

101+

exitWhenTerminationDrains(exitCode);

102+

return;

99103

}

100-

process.exit(signal ? 128 + signal : 1);

104+

exitWhenTerminationDrains(signal ? 128 + signal : 1);

101105

});

102106

});

103107

@@ -109,15 +113,108 @@ for (const signal of ["SIGHUP", "SIGINT", "SIGTERM"]) {

109113

process.on(signal, () => {

110114

if (!exiting) {

111115

forwardedSignal ??= signal;

112-

pty.kill(signal);

113-

forceKillTimer ??= setTimeout(() => {

114-

pty.kill("SIGKILL");

115-

}, FORCE_KILL_MS);

116-

forceKillTimer.unref?.();

116+

terminatePtyTree(signal);

117+

}

118+

});

119+

}

120+121+

function terminatePtyTree(signal) {

122+

// node-pty kill() targets only pty.pid on Unix; wrapper-owned shutdowns

123+

// keep the captured child tree alive until ignored descendants drain.

124+

if (terminationPids.length === 0) {

125+

terminationPids = collectPtyProcessTreePids();

126+

}

127+

signalPtyProcessTree(signal);

128+

forceKillTimer ??= setTimeout(() => {

129+

signalPtyProcessTree("SIGKILL");

130+

}, FORCE_KILL_MS);

131+

forceKillTimer.unref?.();

132+

}

133+134+

function exitWhenTerminationDrains(exitCode) {

135+

pendingExitCode = exitCode;

136+

if (processTreeIsAlive(terminationPids)) {

137+

terminationDrainTimer ??= setInterval(finishIfTerminationDrained, 25);

138+

return;

139+

}

140+

finishIfTerminationDrained();

141+

}

142+143+

function finishIfTerminationDrained() {

144+

if (processTreeIsAlive(terminationPids)) {

145+

return;

146+

}

147+

clearTerminationTimers();

148+

process.exit(pendingExitCode ?? 1);

149+

}

150+151+

function clearTerminationTimers() {

152+

if (forceKillTimer) {

153+

clearTimeout(forceKillTimer);

154+

forceKillTimer = null;

155+

}

156+

if (terminationDrainTimer) {

157+

clearInterval(terminationDrainTimer);

158+

terminationDrainTimer = null;

159+

}

160+

}

161+162+

function collectPtyProcessTreePids() {

163+

if (process.platform === "win32" || typeof pty.pid !== "number") {

164+

return typeof pty.pid === "number" ? [pty.pid] : [];

165+

}

166+

const ps = spawnSync("ps", ["-axo", "pid=,ppid="], { encoding: "utf8" });

167+

if (ps.status !== 0) {

168+

return [pty.pid];

169+

}

170+

const childrenByParent = new Map();

171+

for (const line of ps.stdout.split("\n")) {

172+

const match = line.trim().match(/^(\d+)\s+(\d+)$/u);

173+

if (!match) {

174+

continue;

175+

}

176+

const pid = Number(match[1]);

177+

const ppid = Number(match[2]);

178+

const siblings = childrenByParent.get(ppid) ?? [];

179+

siblings.push(pid);

180+

childrenByParent.set(ppid, siblings);

181+

}

182+

const pids = [pty.pid];

183+

for (const parentPid of pids) {

184+

for (const pid of childrenByParent.get(parentPid) ?? []) {

185+

pids.push(pid);

186+

}

187+

}

188+

return [...new Set(pids)];

189+

}

190+191+

function processTreeIsAlive(pids) {

192+

return pids.some((pid) => {

193+

try {

194+

process.kill(pid, 0);

195+

return true;

196+

} catch (error) {

197+

return error?.code === "EPERM";

117198

}

118199

});

119200

}

120201202+

function signalPtyProcessTree(signal) {

203+

if (process.platform === "win32" || terminationPids.length === 0) {

204+

pty.kill(signal);

205+

return;

206+

}

207+

for (const pid of terminationPids.toReversed()) {

208+

try {

209+

process.kill(pid, signal);

210+

} catch (error) {

211+

if (error?.code !== "ESRCH") {

212+

throw error;

213+

}

214+

}

215+

}

216+

}

217+121218

function signalExitCode(signal) {

122219

switch (signal) {

123220

case "SIGHUP":