惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
WordPress大学
WordPress大学
人人都是产品经理
人人都是产品经理
Engineering at Meta
Engineering at Meta
小众软件
小众软件
I
InfoQ
有赞技术团队
有赞技术团队
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
Martin Fowler
Martin Fowler
月光博客
月光博客
雷峰网
雷峰网
aimingoo的专栏
aimingoo的专栏
云风的 BLOG
云风的 BLOG
Last Week in AI
Last Week in AI
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
S
SegmentFault 最新的问题
The GitHub Blog
The GitHub Blog
Y
Y Combinator Blog
V
Visual Studio Blog
博客园 - 叶小钗
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
GbyAI
GbyAI
P
Proofpoint News Feed
Apple Machine Learning Research
Apple Machine Learning Research

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(agents): cap exec reviewer timeout · openclaw/opencla...
steipete · 2026-05-30 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -1,5 +1,10 @@

11

import { describe, expect, it, vi } from "vitest";

2-

import { createModelExecAutoReviewer, parseExecAutoReviewResponse } from "./exec-auto-reviewer.js";

2+

import { MAX_TIMER_TIMEOUT_MS } from "../shared/number-coercion.js";

3+

import {

4+

createModelExecAutoReviewer,

5+

parseExecAutoReviewResponse,

6+

resolveExecReviewerTimeoutMs,

7+

} from "./exec-auto-reviewer.js";

38
49

const input = {

510

command: "git status",

@@ -304,6 +309,12 @@ describe("createModelExecAutoReviewer", () => {

304309

}

305310

});

306311
312+

it("caps oversized reviewer timeouts before scheduling timers", () => {

313+

expect(resolveExecReviewerTimeoutMs({ timeoutMs: Number.MAX_SAFE_INTEGER })).toBe(

314+

MAX_TIMER_TIMEOUT_MS,

315+

);

316+

});

317+
307318

it("gives reviewer completion a fresh timeout after slow model preparation", async () => {

308319

vi.useFakeTimers();

309320

try {

Original file line numberDiff line numberDiff line change

@@ -8,6 +8,7 @@ import {

88

type ExecAutoReviewInput,

99

type ExecAutoReviewer,

1010

} from "../infra/exec-auto-review.js";

11+

import { resolveTimerTimeoutMs } from "../shared/number-coercion.js";

1112

import { normalizeOptionalString } from "../shared/string-coerce.js";

1213

import { DEFAULT_EXEC_REVIEWER_SYSTEM_PROMPT } from "./exec-auto-reviewer.prompt.js";

1314

import {

@@ -186,10 +187,8 @@ function resolveReviewerModelRef(config?: ExecReviewerConfig): string | undefine

186187

return coerceToolModelConfig(config?.model).primary;

187188

}

188189
189-

function resolveReviewerTimeoutMs(config?: ExecReviewerConfig): number {

190-

return typeof config?.timeoutMs === "number" && Number.isFinite(config.timeoutMs)

191-

? Math.max(1_000, Math.floor(config.timeoutMs))

192-

: DEFAULT_EXEC_REVIEWER_TIMEOUT_MS;

190+

export function resolveExecReviewerTimeoutMs(config?: ExecReviewerConfig): number {

191+

return resolveTimerTimeoutMs(config?.timeoutMs, DEFAULT_EXEC_REVIEWER_TIMEOUT_MS, 1_000);

193192

}

194193
195194

function buildReviewerTimeoutDecision(timeoutMs: number): ExecAutoReviewDecision {

@@ -240,7 +239,7 @@ export function createModelExecAutoReviewer(params: {

240239

params.deps?.completeWithPreparedSimpleCompletionModel ??

241240

completeWithPreparedSimpleCompletionModel;

242241

const modelRef = resolveReviewerModelRef(params.reviewer);

243-

const timeoutMs = resolveReviewerTimeoutMs(params.reviewer);

242+

const timeoutMs = resolveExecReviewerTimeoutMs(params.reviewer);

244243

return async (input) => {

245244

let completionController: AbortController | undefined;

246245

try {