惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

月光博客
月光博客
Martin Fowler
Martin Fowler
Last Week in AI
Last Week in AI
罗磊的独立博客
阮一峰的网络日志
阮一峰的网络日志
博客园 - 【当耐特】
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
博客园 - 三生石上(FineUI控件)
S
SegmentFault 最新的问题
V
Visual Studio Blog
Hugging Face - Blog
Hugging Face - Blog
雷峰网
雷峰网
博客园_首页
人人都是产品经理
人人都是产品经理
量子位
美团技术团队
The Cloudflare Blog
小众软件
小众软件
WordPress大学
WordPress大学
有赞技术团队
有赞技术团队
M
MIT News - Artificial intelligence
Microsoft Security Blog
Microsoft Security Blog
D
DataBreaches.Net
博客园 - Franky

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
refactor: centralize config mutations · openclaw/openclaw...
steipete · 2026-05-13 · via Recent Commits to openclaw:main

@@ -1,28 +1,20 @@

11

import fs from "node:fs";

22

import path from "node:path";

33

import { normalizeOptionalString } from "openclaw/plugin-sdk/string-coerce-runtime";

4-

import type { BrowserProfileConfig } from "../config/config.js";

5-

import { getRuntimeConfig, mutateConfigFile } from "../config/config.js";

6-

import { deriveDefaultBrowserCdpPortRange } from "../config/port-defaults.js";

4+

import { getRuntimeConfig } from "../config/config.js";

75

import { formatErrorMessage } from "../infra/errors.js";

86

import { resolveUserPath } from "../utils.js";

97

import { assertCdpEndpointAllowed } from "./cdp.helpers.js";

108

import { resolveOpenClawUserDataDir } from "./chrome.js";

11-

import { parseHttpUrl, resolveBrowserConfig, resolveProfile } from "./config.js";

9+

import { createBrowserProfileConfig, deleteBrowserProfileConfig } from "./config-mutations.js";

10+

import { parseHttpUrl, resolveProfile } from "./config.js";

1211

import {

1312

BrowserConflictError,

1413

BrowserProfileNotFoundError,

15-

BrowserResourceExhaustedError,

1614

BrowserValidationError,

1715

} from "./errors.js";

1816

import { getBrowserProfileCapabilities } from "./profile-capabilities.js";

19-

import {

20-

allocateCdpPort,

21-

allocateColor,

22-

getUsedColors,

23-

getUsedPorts,

24-

isValidProfileName,

25-

} from "./profiles.js";

17+

import { isValidProfileName } from "./profiles.js";

2618

import type { BrowserRouteContext, ProfileStatus } from "./server-context.js";

2719

import { movePathToTrash } from "./trash.js";

2820

@@ -53,30 +45,6 @@ export type DeleteProfileResult = {

53455446

const HEX_COLOR_RE = /^#[0-9A-Fa-f]{6}$/;

554756-

const cdpPortRange = (resolved: {

57-

controlPort: number;

58-

cdpPortRangeStart?: number;

59-

cdpPortRangeEnd?: number;

60-

}): { start: number; end: number } => {

61-

const start = resolved.cdpPortRangeStart;

62-

const end = resolved.cdpPortRangeEnd;

63-

if (

64-

typeof start === "number" &&

65-

Number.isFinite(start) &&

66-

Number.isInteger(start) &&

67-

typeof end === "number" &&

68-

Number.isFinite(end) &&

69-

Number.isInteger(end) &&

70-

start > 0 &&

71-

end >= start &&

72-

end <= 65535

73-

) {

74-

return { start, end };

75-

}

76-77-

return deriveDefaultBrowserCdpPortRange(resolved.controlPort);

78-

};

79-8048

export function createBrowserProfilesService(ctx: BrowserRouteContext) {

8149

const listProfiles = async (): Promise<ProfileStatus[]> => {

8250

return await ctx.listProfiles();

@@ -138,76 +106,14 @@ export function createBrowserProfilesService(ctx: BrowserRouteContext) {

138106

parsedCdpUrl = parsed.normalized;

139107

}

140108141-

const mutation = await mutateConfigFile<BrowserProfileConfig>({

142-

afterWrite: { mode: "auto" },

143-

mutate: async (draft) => {

144-

const latestResolved = resolveBrowserConfig({

145-

...state.resolved,

146-

...draft.browser,

147-

profiles: draft.browser?.profiles ?? state.resolved.profiles,

148-

});

149-

const latestProfiles = draft.browser?.profiles ?? {};

150-

if (name in latestProfiles || name in latestResolved.profiles) {

151-

throw new BrowserConflictError(`profile "${name}" already exists`);

152-

}

153-154-

const profileColor =

155-

explicitProfileColor ?? allocateColor(getUsedColors(latestResolved.profiles));

156-157-

let nextProfileConfig: BrowserProfileConfig;

158-

if (parsedCdpUrl) {

159-

try {

160-

await assertCdpEndpointAllowed(parsedCdpUrl, latestResolved.ssrfPolicy);

161-

} catch (err) {

162-

throw new BrowserValidationError(formatErrorMessage(err));

163-

}

164-

nextProfileConfig = {

165-

cdpUrl: parsedCdpUrl,

166-

...(driver ? { driver } : {}),

167-

color: profileColor,

168-

};

169-

} else if (driver === "existing-session") {

170-

// existing-session uses Chrome MCP auto-connect; no CDP port needed.

171-

nextProfileConfig = {

172-

driver,

173-

attachOnly: true,

174-

...(normalizedUserDataDir ? { userDataDir: normalizedUserDataDir } : {}),

175-

color: profileColor,

176-

};

177-

} else {

178-

const usedPorts = getUsedPorts(latestResolved.profiles);

179-

const rangeStart = draft.browser?.cdpPortRangeStart ?? state.resolved.cdpPortRangeStart;

180-

const range = cdpPortRange({

181-

controlPort: state.resolved.controlPort,

182-

cdpPortRangeStart: rangeStart,

183-

cdpPortRangeEnd:

184-

draft.browser?.cdpPortRangeStart === undefined

185-

? state.resolved.cdpPortRangeEnd

186-

: latestResolved.cdpPortRangeEnd,

187-

});

188-

const cdpPort = allocateCdpPort(usedPorts, range);

189-

if (cdpPort === null) {

190-

throw new BrowserResourceExhaustedError("no available CDP ports in range");

191-

}

192-

nextProfileConfig = {

193-

cdpPort,

194-

...(driver ? { driver } : {}),

195-

color: profileColor,

196-

};

197-

}

198-199-

draft.browser = {

200-

...draft.browser,

201-

profiles: {

202-

...draft.browser?.profiles,

203-

[name]: nextProfileConfig,

204-

},

205-

};

206-

return nextProfileConfig;

207-

},

109+

const profileConfig = await createBrowserProfileConfig({

110+

name,

111+

resolved: state.resolved,

112+

...(explicitProfileColor ? { color: explicitProfileColor } : {}),

113+

...(parsedCdpUrl ? { parsedCdpUrl } : {}),

114+

...(normalizedUserDataDir ? { userDataDir: normalizedUserDataDir } : {}),

115+

...(driver ? { driver } : {}),

208116

});

209-210-

const profileConfig = mutation.result;

211117

if (!profileConfig) {

212118

throw new BrowserProfileNotFoundError(`profile "${name}" not found after creation`);

213119

}

@@ -270,22 +176,7 @@ export function createBrowserProfilesService(ctx: BrowserRouteContext) {

270176

}

271177

}

272178273-

await mutateConfigFile({

274-

afterWrite: { mode: "auto" },

275-

mutate: (draft) => {

276-

const { [name]: _removed, ...remainingProfiles } = draft.browser?.profiles ?? {};

277-

const nextBrowser = {

278-

...draft.browser,

279-

profiles: remainingProfiles,

280-

};

281-

if (nextBrowser.defaultProfile === name) {

282-

delete nextBrowser.defaultProfile;

283-

}

284-

draft.browser = {

285-

...nextBrowser,

286-

};

287-

},

288-

});

179+

await deleteBrowserProfileConfig(name);

289180290181

delete state.resolved.profiles[name];

291182

state.profiles.delete(name);