惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Apple Machine Learning Research
Apple Machine Learning Research
J
Java Code Geeks
博客园 - 聂微东
Microsoft Azure Blog
Microsoft Azure Blog
量子位
T
Tailwind CSS Blog
Vercel News
Vercel News
I
InfoQ
Stack Overflow Blog
Stack Overflow Blog
U
Unit 42
Engineering at Meta
Engineering at Meta
L
LangChain Blog
大猫的无限游戏
大猫的无限游戏
D
Docker
博客园_首页
P
Proofpoint News Feed
月光博客
月光博客
T
The Blog of Author Tim Ferriss
MyScale Blog
MyScale Blog
酷 壳 – CoolShell
酷 壳 – CoolShell
Martin Fowler
Martin Fowler
腾讯CDC
N
Netflix TechBlog - Medium
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix: bridge codex request user input · openclaw/openclaw@...
steipete · 2026-04-24 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -23,6 +23,7 @@ Docs: https://docs.openclaw.ai

2323
2424

### Fixes

2525
26+

- Codex harness: route native `request_user_input` prompts back to the originating chat, preserve queued follow-up answers, and honor newer app-server command approval amendment decisions.

2627

- Agents/replay: stop OpenAI/Codex transcript replay from synthesizing missing tool results while still preserving synthetic repair on Anthropic, Gemini, and Bedrock transport-owned sessions. (#61556) Thanks @VictorJeon and @vincentkoc.

2728

- Telegram/media replies: parse remote markdown image syntax into outbound media payloads on the final reply path, so Telegram group chats stop falling back to plain-text image URLs when the model or a tool emits `![...](...)` instead of a `MEDIA:` token. (#66191) Thanks @apezam and @vincentkoc.

2829

- Agents/WebChat: surface non-retryable provider failures such as billing, auth, and rate-limit errors from the embedded runner instead of logging `surface_error` and leaving webchat with no rendered error. Fixes #70124. (#70848) Thanks @truffle-dev.

Original file line numberDiff line numberDiff line change

@@ -546,8 +546,10 @@ continue through the normal OpenClaw delivery path.

546546
547547

Codex MCP tool approval elicitations are routed through OpenClaw's plugin

548548

approval flow when Codex marks `_meta.codex_approval_kind` as

549-

`"mcp_tool_call"`; other elicitation and free-form input requests still fail

550-

closed.

549+

`"mcp_tool_call"`. Codex `request_user_input` prompts are sent back to the

550+

originating chat, and the next queued follow-up message answers that native

551+

server request instead of being steered as extra context. Other MCP elicitation

552+

requests still fail closed.

551553
552554

When the selected model uses the Codex harness, native thread compaction is

553555

delegated to Codex app-server. OpenClaw keeps a transcript mirror for channel

Original file line numberDiff line numberDiff line change

@@ -79,6 +79,46 @@ describe("Codex app-server approval bridge", () => {

7979

);

8080

});

8181
82+

it("describes command approvals from parsed command actions when available", async () => {

83+

const params = createParams();

84+

mockCallGatewayTool.mockResolvedValueOnce({

85+

id: "plugin:approval-actions",

86+

decision: "allow-once",

87+

});

88+
89+

await handleCodexAppServerApprovalRequest({

90+

method: "item/commandExecution/requestApproval",

91+

requestParams: {

92+

threadId: "thread-1",

93+

turnId: "turn-1",

94+

itemId: "cmd-actions",

95+

command: "bash -lc 'pnpm test extensions/codex'",

96+

commandActions: [{ command: "pnpm test extensions/codex" }],

97+

},

98+

paramsForRun: params,

99+

threadId: "thread-1",

100+

turnId: "turn-1",

101+

});

102+
103+

const [, , requestPayload] = mockCallGatewayTool.mock.calls[0] ?? [];

104+

expect(requestPayload).toEqual(

105+

expect.objectContaining({

106+

description: expect.stringContaining("Command: pnpm test extensions/codex"),

107+

}),

108+

);

109+

expect(requestPayload).toEqual(

110+

expect.objectContaining({

111+

description: expect.not.stringContaining("bash -lc"),

112+

}),

113+

);

114+

expect(params.onAgentEvent).toHaveBeenCalledWith(

115+

expect.objectContaining({

116+

stream: "approval",

117+

data: expect.objectContaining({ command: "pnpm test extensions/codex" }),

118+

}),

119+

);

120+

});

121+
82122

it("fails closed when no approval route is available", async () => {

83123

const params = createParams();

84124

mockCallGatewayTool.mockResolvedValueOnce({

@@ -266,6 +306,57 @@ describe("Codex app-server approval bridge", () => {

266306

).toEqual({

267307

decision: "accept",

268308

});

309+

expect(

310+

buildApprovalResponse(

311+

"item/commandExecution/requestApproval",

312+

{

313+

availableDecisions: [

314+

"accept",

315+

{

316+

acceptWithExecpolicyAmendment: {

317+

execpolicy_amendment: {

318+

permissions: [{ permission: "allow", command: ["pnpm", "test"] }],

319+

},

320+

},

321+

},

322+

],

323+

},

324+

"approved-session",

325+

),

326+

).toEqual({

327+

decision: {

328+

acceptWithExecpolicyAmendment: {

329+

execpolicy_amendment: {

330+

permissions: [{ permission: "allow", command: ["pnpm", "test"] }],

331+

},

332+

},

333+

},

334+

});

335+

expect(

336+

buildApprovalResponse(

337+

"item/commandExecution/requestApproval",

338+

{

339+

availableDecisions: [

340+

{

341+

applyNetworkPolicyAmendment: {

342+

network_policy_amendment: {

343+

domain: "registry.npmjs.org",

344+

},

345+

},

346+

},

347+

],

348+

},

349+

"approved-session",

350+

),

351+

).toEqual({

352+

decision: {

353+

applyNetworkPolicyAmendment: {

354+

network_policy_amendment: {

355+

domain: "registry.npmjs.org",

356+

},

357+

},

358+

},

359+

});

269360

expect(buildApprovalResponse("item/fileChange/requestApproval", undefined, "denied")).toEqual({

270361

decision: "decline",

271362

});

Original file line numberDiff line numberDiff line change

@@ -161,7 +161,7 @@ function buildApprovalContext(params: {

161161

readString(params.requestParams, "itemId") ??

162162

readString(params.requestParams, "callId") ??

163163

readString(params.requestParams, "approvalId");

164-

const command = readCommand(params.requestParams);

164+

const command = readDisplayCommand(params.requestParams);

165165

const reason = readString(params.requestParams, "reason");

166166

const kind = approvalKindForMethod(params.method);

167167

const permissionLines =

@@ -220,8 +220,14 @@ function commandApprovalDecision(

220220

if (outcome === "denied" || outcome === "unavailable") {

221221

return "decline";

222222

}

223-

if (outcome === "approved-session" && hasAvailableDecision(requestParams, "acceptForSession")) {

224-

return "acceptForSession";

223+

if (outcome === "approved-session") {

224+

if (hasAvailableDecision(requestParams, "acceptForSession")) {

225+

return "acceptForSession";

226+

}

227+

const amendmentDecision = findAvailableCommandAmendmentDecision(requestParams);

228+

if (amendmentDecision) {

229+

return amendmentDecision;

230+

}

225231

}

226232

return "accept";

227233

}

@@ -459,6 +465,21 @@ function hasAvailableDecision(requestParams: JsonObject | undefined, decision: s

459465

return available.includes(decision);

460466

}

461467
468+

function findAvailableCommandAmendmentDecision(

469+

requestParams: JsonObject | undefined,

470+

): JsonValue | undefined {

471+

const available = requestParams?.availableDecisions;

472+

if (!Array.isArray(available)) {

473+

return undefined;

474+

}

475+

return available.find(

476+

(entry): entry is JsonObject =>

477+

isJsonObject(entry) &&

478+

(isJsonObject(entry.acceptWithExecpolicyAmendment) ||

479+

isJsonObject(entry.applyNetworkPolicyAmendment)),

480+

);

481+

}

482+
462483

function approvalResolutionMessage(outcome: AppServerApprovalOutcome): string {

463484

if (outcome === "approved-session") {

464485

return "Codex app-server approval granted for the session.";

@@ -510,6 +531,25 @@ function emitApprovalEvent(params: EmbeddedRunAttemptParams, data: AgentApproval

510531

params.onAgentEvent?.({ stream: "approval", data: data as unknown as Record<string, unknown> });

511532

}

512533
534+

function readDisplayCommand(record: JsonObject | undefined): string | undefined {

535+

const actionCommand = readCommandActions(record);

536+

if (actionCommand) {

537+

return actionCommand;

538+

}

539+

return readCommand(record);

540+

}

541+
542+

function readCommandActions(record: JsonObject | undefined): string | undefined {

543+

const actions = record?.commandActions;

544+

if (!Array.isArray(actions)) {

545+

return undefined;

546+

}

547+

const commands = actions

548+

.map((action) => (isJsonObject(action) ? readString(action, "command") : undefined))

549+

.filter((command): command is string => Boolean(command));

550+

return commands.length > 0 ? commands.join(" && ") : undefined;

551+

}

552+
513553

function readCommand(record: JsonObject | undefined): string | undefined {

514554

const command = record?.command;

515555

if (typeof command === "string") {

Original file line numberDiff line numberDiff line change

@@ -653,6 +653,97 @@ describe("runCodexAppServerAttempt", () => {

653653

await run;

654654

});

655655
656+

it("routes request_user_input prompts through the active run follow-up queue", async () => {

657+

let notify: (notification: CodexServerNotification) => Promise<void> = async () => undefined;

658+

let handleRequest:

659+

| ((request: { id: string; method: string; params?: unknown }) => Promise<unknown>)

660+

| undefined;

661+

const request = vi.fn(async (method: string) => {

662+

if (method === "thread/start") {

663+

return threadStartResult();

664+

}

665+

if (method === "turn/start") {

666+

return turnStartResult();

667+

}

668+

return {};

669+

});

670+

__testing.setCodexAppServerClientFactoryForTests(

671+

async () =>

672+

({

673+

request,

674+

addNotificationHandler: (handler: typeof notify) => {

675+

notify = handler;

676+

return () => undefined;

677+

},

678+

addRequestHandler: (

679+

handler: (request: {

680+

id: string;

681+

method: string;

682+

params?: unknown;

683+

}) => Promise<unknown>,

684+

) => {

685+

handleRequest = handler;

686+

return () => undefined;

687+

},

688+

}) as never,

689+

);

690+
691+

const params = createParams(

692+

path.join(tempDir, "session.jsonl"),

693+

path.join(tempDir, "workspace"),

694+

);

695+

params.onBlockReply = vi.fn();

696+

const run = runCodexAppServerAttempt(params);

697+

await vi.waitFor(

698+

() => expect(request.mock.calls.some(([method]) => method === "turn/start")).toBe(true),

699+

{ interval: 1 },

700+

);

701+

await vi.waitFor(() => expect(handleRequest).toBeTypeOf("function"), { interval: 1 });

702+
703+

const response = handleRequest?.({

704+

id: "request-input-1",

705+

method: "item/tool/requestUserInput",

706+

params: {

707+

threadId: "thread-1",

708+

turnId: "turn-1",

709+

itemId: "ask-1",

710+

questions: [

711+

{

712+

id: "mode",

713+

header: "Mode",

714+

question: "Pick a mode",

715+

isOther: false,

716+

isSecret: false,

717+

options: [

718+

{ label: "Fast", description: "Use less reasoning" },

719+

{ label: "Deep", description: "Use more reasoning" },

720+

],

721+

},

722+

],

723+

},

724+

});

725+
726+

await vi.waitFor(() => expect(params.onBlockReply).toHaveBeenCalledTimes(1), { interval: 1 });

727+

expect(queueAgentHarnessMessage("session-1", "2")).toBe(true);

728+

await expect(response).resolves.toEqual({

729+

answers: { mode: { answers: ["Deep"] } },

730+

});

731+

expect(request).not.toHaveBeenCalledWith(

732+

"turn/steer",

733+

expect.objectContaining({ expectedTurnId: "turn-1" }),

734+

);

735+
736+

await notify({

737+

method: "turn/completed",

738+

params: {

739+

threadId: "thread-1",

740+

turnId: "turn-1",

741+

turn: { id: "turn-1", status: "completed" },

742+

},

743+

});

744+

await run;

745+

});

746+
656747

it("does not leak unhandled rejections when shutdown closes before interrupt", async () => {

657748

const unhandledRejections: unknown[] = [];

658749

const onUnhandledRejection = (reason: unknown) => {

Original file line numberDiff line numberDiff line change

@@ -58,6 +58,7 @@ import {

5858

recordCodexTrajectoryContext,

5959

} from "./trajectory.js";

6060

import { mirrorCodexAppServerTranscript } from "./transcript-mirror.js";

61+

import { createCodexUserInputBridge } from "./user-input-bridge.js";

6162

import { filterToolsForVisionInputs } from "./vision-tools.js";

6263
6364

let clientFactory = defaultCodexAppServerClientFactory;

@@ -211,6 +212,7 @@ export async function runCodexAppServerAttempt(

211212

let projector: CodexAppServerEventProjector | undefined;

212213

let turnId: string | undefined;

213214

const pendingNotifications: CodexServerNotification[] = [];

215+

let userInputBridge: ReturnType<typeof createCodexUserInputBridge> | undefined;

214216

let completed = false;

215217

let timedOut = false;

216218

let resolveCompletion: (() => void) | undefined;

@@ -220,6 +222,7 @@ export async function runCodexAppServerAttempt(

220222

let notificationQueue: Promise<void> = Promise.resolve();

221223
222224

const handleNotification = async (notification: CodexServerNotification) => {

225+

userInputBridge?.handleNotification(notification);

223226

if (!projector || !turnId) {

224227

pendingNotifications.push(notification);

225228

return;

@@ -266,6 +269,12 @@ export async function runCodexAppServerAttempt(

266269

signal: runAbortController.signal,

267270

});

268271

}

272+

if (request.method === "item/tool/requestUserInput") {

273+

return userInputBridge?.handleRequest({

274+

id: request.id,

275+

params: request.params,

276+

});

277+

}

269278

if (request.method !== "item/tool/call") {

270279

if (isCodexAppServerApprovalRequest(request.method)) {

271280

return handleApprovalRequest({

@@ -382,6 +391,12 @@ export async function runCodexAppServerAttempt(

382391

}

383392

turnId = turn.turn.id;

384393

const activeTurnId = turn.turn.id;

394+

userInputBridge = createCodexUserInputBridge({

395+

paramsForRun: params,

396+

threadId: thread.threadId,

397+

turnId: activeTurnId,

398+

signal: runAbortController.signal,

399+

});

385400

trajectoryRecorder?.recordEvent("prompt.submitted", {

386401

threadId: thread.threadId,

387402

turnId: activeTurnId,

@@ -407,6 +422,9 @@ export async function runCodexAppServerAttempt(

407422

const handle = {

408423

kind: "embedded" as const,

409424

queueMessage: async (text: string) => {

425+

if (userInputBridge?.handleQueuedMessage(text)) {

426+

return;

427+

}

410428

await client.request("turn/steer", {

411429

threadId: thread.threadId,

412430

expectedTurnId: activeTurnId,

@@ -511,6 +529,7 @@ export async function runCodexAppServerAttempt(

511529

});

512530

}

513531

await trajectoryRecorder?.flush();

532+

userInputBridge?.cancelPending();

514533

clearTimeout(timeout);

515534

notificationCleanup();

516535

requestCleanup();