惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

月光博客
月光博客
MyScale Blog
MyScale Blog
博客园 - Franky
The Cloudflare Blog
IT之家
IT之家
Blog — PlanetScale
Blog — PlanetScale
博客园 - 聂微东
WordPress大学
WordPress大学
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
T
The Blog of Author Tim Ferriss
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
罗磊的独立博客
Google DeepMind News
Google DeepMind News
P
Proofpoint News Feed
Martin Fowler
Martin Fowler
aimingoo的专栏
aimingoo的专栏
J
Java Code Geeks
腾讯CDC
雷峰网
雷峰网
Microsoft Azure Blog
Microsoft Azure Blog
G
Google Developers Blog
博客园 - 【当耐特】
美团技术团队
云风的 BLOG
云风的 BLOG

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix: harden plugin install and uninstall transactions · o...
steipete · 2026-04-26 · via Recent Commits to openclaw:main

@@ -25,12 +25,12 @@ import {

2525

} from "../plugins/status.js";

2626

import type { PluginLogger } from "../plugins/types.js";

2727

import {

28+

applyPluginUninstallDirectoryRemoval,

2829

formatUninstallActionLabels,

2930

formatUninstallSlotResetPreview,

31+

planPluginUninstall,

3032

resolveUninstallChannelConfigKeys,

31-

resolveUninstallDirectoryTarget,

3233

UNINSTALL_ACTION_LABELS,

33-

uninstallPlugin,

3434

} from "../plugins/uninstall.js";

3535

import { defaultRuntime } from "../runtime.js";

3636

import { formatDocsLink } from "../terminal/links.js";

@@ -614,50 +614,51 @@ export function registerPluginsCli(program: Command) {

614614

return defaultRuntime.exit(1);

615615

}

616616617-

const install = cfg.plugins?.installs?.[pluginId];

618-

const isLinked = install?.source === "path";

617+

const channelIds = plugin?.status === "loaded" ? plugin.channelIds : undefined;

618+

const plan = planPluginUninstall({

619+

config: cfg,

620+

pluginId,

621+

channelIds,

622+

deleteFiles: !keepFiles,

623+

extensionsDir,

624+

});

625+

if (!plan.ok) {

626+

defaultRuntime.error(plan.error);

627+

return defaultRuntime.exit(1);

628+

}

629+619630

const preview: string[] = [];

620-

if (hasEntry) {

631+

if (plan.actions.entry) {

621632

preview.push(UNINSTALL_ACTION_LABELS.entry);

622633

}

623-

if (hasInstall) {

634+

if (plan.actions.install) {

624635

preview.push(UNINSTALL_ACTION_LABELS.install);

625636

}

626-

if (cfg.plugins?.allow?.includes(pluginId)) {

637+

if (plan.actions.allowlist) {

627638

preview.push(UNINSTALL_ACTION_LABELS.allowlist);

628639

}

629-

if (

630-

isLinked &&

631-

install?.sourcePath &&

632-

cfg.plugins?.load?.paths?.includes(install.sourcePath)

633-

) {

640+

if (plan.actions.denylist) {

641+

preview.push(UNINSTALL_ACTION_LABELS.denylist);

642+

}

643+

if (plan.actions.loadPath) {

634644

preview.push(UNINSTALL_ACTION_LABELS.loadPath);

635645

}

636-

if (cfg.plugins?.slots?.memory === pluginId) {

646+

if (plan.actions.memorySlot) {

637647

preview.push(formatUninstallSlotResetPreview("memory"));

638648

}

639-

if (cfg.plugins?.slots?.contextEngine === pluginId) {

649+

if (plan.actions.contextEngineSlot) {

640650

preview.push(formatUninstallSlotResetPreview("contextEngine"));

641651

}

642-

const channelIds = plugin?.status === "loaded" ? plugin.channelIds : undefined;

643652

const channels = cfg.channels as Record<string, unknown> | undefined;

644-

if (hasInstall && channels) {

653+

if (plan.actions.channelConfig && hasInstall && channels) {

645654

for (const key of resolveUninstallChannelConfigKeys(pluginId, { channelIds })) {

646655

if (Object.hasOwn(channels, key)) {

647656

preview.push(`${UNINSTALL_ACTION_LABELS.channelConfig} (channels.${key})`);

648657

}

649658

}

650659

}

651-

const deleteTarget = !keepFiles

652-

? resolveUninstallDirectoryTarget({

653-

pluginId,

654-

hasInstall,

655-

installRecord: install,

656-

extensionsDir,

657-

})

658-

: null;

659-

if (deleteTarget) {

660-

preview.push(`directory: ${shortenHomePath(deleteTarget)}`);

660+

if (plan.directoryRemoval) {

661+

preview.push(`directory: ${shortenHomePath(plan.directoryRemoval.target)}`);

661662

}

662663663664

const pluginName = plugin?.name || pluginId;

@@ -679,24 +680,8 @@ export function registerPluginsCli(program: Command) {

679680

}

680681

}

681682682-

const result = await uninstallPlugin({

683-

config: cfg,

684-

pluginId,

685-

channelIds,

686-

deleteFiles: !keepFiles,

687-

extensionsDir,

688-

});

689-690-

if (!result.ok) {

691-

defaultRuntime.error(result.error);

692-

return defaultRuntime.exit(1);

693-

}

694-

for (const warning of result.warnings) {

695-

defaultRuntime.log(theme.warn(warning));

696-

}

697-698683

const nextInstallRecords = removePluginInstallRecordFromRecords(installRecords, pluginId);

699-

const nextConfig = withoutPluginInstallRecords(result.config);

684+

const nextConfig = withoutPluginInstallRecords(plan.config);

700685

await commitPluginInstallRecordsWithConfig({

701686

previousInstallRecords: installRecords,

702687

nextInstallRecords,

@@ -711,8 +696,15 @@ export function registerPluginsCli(program: Command) {

711696

warn: (message) => defaultRuntime.log(theme.warn(message)),

712697

},

713698

});

699+

const directoryResult = await applyPluginUninstallDirectoryRemoval(plan.directoryRemoval);

700+

for (const warning of directoryResult.warnings) {

701+

defaultRuntime.log(theme.warn(warning));

702+

}

714703715-

const removed = formatUninstallActionLabels(result.actions);

704+

const removed = formatUninstallActionLabels({

705+

...plan.actions,

706+

directory: directoryResult.directoryRemoved,

707+

});

716708717709

defaultRuntime.log(

718710

`Uninstalled plugin "${pluginId}". Removed: ${removed.length > 0 ? removed.join(", ") : "nothing"}.`,