惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

云风的 BLOG
云风的 BLOG
The GitHub Blog
The GitHub Blog
Y
Y Combinator Blog
博客园 - 三生石上(FineUI控件)
T
The Blog of Author Tim Ferriss
宝玉的分享
宝玉的分享
Hugging Face - Blog
Hugging Face - Blog
WordPress大学
WordPress大学
V
Visual Studio Blog
小众软件
小众软件
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
MongoDB | Blog
MongoDB | Blog
V
V2EX
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
博客园 - 【当耐特】
Microsoft Azure Blog
Microsoft Azure Blog
The Cloudflare Blog
H
Hackread – Cybersecurity News, Data Breaches, AI and More
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
Engineering at Meta
Engineering at Meta
L
LangChain Blog
Martin Fowler
Martin Fowler
GbyAI
GbyAI
博客园 - 司徒正美

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(outbound): prevent partial-send recovery replay · ope...
obviyus · 2026-06-25 · via Recent Commits to openclaw:main
1-

// Integration test: real SQLite delivery queue + mock adapter.

2-

// Verifies the patch end-to-end at the queue layer: when a required-mode

3-

// batch send fails mid-batch after an earlier payload already succeeded,

4-

// the queue entry advances to recovery_state=unknown_after_send (not left

5-

// in send_attempt_started), so reconnect-drain routes it through

6-

// reconcileUnknownQueuedDelivery instead of blind replay.

71

import { describe, expect, it, vi, beforeAll, beforeEach } from "vitest";

82

import type { OpenClawConfig } from "../../config/config.js";

93

import { drainPendingDeliveries, type DeliverFn, loadPendingDeliveries } from "./delivery-queue.js";

@@ -14,7 +8,6 @@ import {

148159

let deliverOutboundPayloads: typeof import("./deliver.js").deliverOutboundPayloads;

161017-

// Minimal reconnect drain helper (no adapter → reconcileUnknownQueuedDelivery returns null).

1811

async function drainMatrixReconnect(opts: { deliver: DeliverFn; stateDir: string }): Promise<void> {

1912

await drainPendingDeliveries({

2013

drainKey: "matrix:reconnect-test",

@@ -27,6 +20,27 @@ async function drainMatrixReconnect(opts: { deliver: DeliverFn; stateDir: string

2720

});

2821

}

292223+

function createPartialSendFailure() {

24+

return vi

25+

.fn()

26+

.mockResolvedValueOnce({ messageId: "m1" })

27+

.mockRejectedValueOnce(new Error("second payload send failed"));

28+

}

29+30+

async function deliverPartialMatrixBatch(sendMatrix: ReturnType<typeof vi.fn>, tmpDir: string) {

31+

process.env.OPENCLAW_STATE_DIR = tmpDir;

32+

await expect(

33+

deliverOutboundPayloads({

34+

cfg: {} as OpenClawConfig,

35+

channel: "matrix",

36+

to: "!room:example",

37+

payloads: [{ text: "first" }, { text: "second" }],

38+

deps: { matrix: sendMatrix },

39+

queuePolicy: "required",

40+

}),

41+

).rejects.toThrow("second payload send failed");

42+

}

43+3044

describe("deliverOutboundPayloads queue integration: mid-batch failure with send evidence", () => {

3145

const fixtures = installDeliveryQueueTmpDirHooks();

3246

let tmpDir: string;

@@ -40,79 +54,36 @@ describe("deliverOutboundPayloads queue integration: mid-batch failure with send

4054

});

41554256

it("advances queued entry to unknown_after_send when a later payload fails after an earlier one succeeded", async () => {

43-

process.env.OPENCLAW_STATE_DIR = tmpDir;

44-

// First payload succeeds (send evidence), second payload throws.

45-

const sendMatrix = vi

46-

.fn()

47-

.mockResolvedValueOnce({ messageId: "m1" })

48-

.mockRejectedValueOnce(new Error("second payload send failed"));

57+

const sendMatrix = createPartialSendFailure();

495850-

await expect(

51-

deliverOutboundPayloads({

52-

cfg: {} as OpenClawConfig,

53-

channel: "matrix",

54-

to: "!room:example",

55-

payloads: [{ text: "first" }, { text: "second" }],

56-

deps: { matrix: sendMatrix },

57-

queuePolicy: "required",

58-

}),

59-

).rejects.toThrow("second payload send failed");

59+

await deliverPartialMatrixBatch(sendMatrix, tmpDir);

606061-

// The entry must exist in the real SQLite queue and be in unknown_after_send.

62-

const entries = await import("./delivery-queue.js").then((m) =>

63-

m.loadPendingDeliveries(tmpDir),

64-

);

61+

const entries = await loadPendingDeliveries(tmpDir);

6562

expect(entries).toHaveLength(1);

6663

const entry = entries[0];

6764

expect(entry.recoveryState).toBe("unknown_after_send");

6865

expect(entry.retryCount).toBe(0);

6966

expect(entry.lastError).toBeUndefined();

70-

// Sanity: the send actually happened for the first payload.

7167

expect(sendMatrix).toHaveBeenCalledTimes(2);

7268

});

73697470

it("drain does not replay an unknown_after_send entry when no adapter reconciliation is available", async () => {

75-

// Regression guard for the recovery/drain semantics: an entry in

76-

// unknown_after_send (written by the patch above) must NOT be blindly

77-

// replayed when the channel adapter cannot reconcile the unknown send.

78-

// Without the patch the entry would stay in send_attempt_started, which

79-

// has the same drain behaviour — but this test pins the contract so that

80-

// any future regression that accidentally advances the state in a way that

81-

// re-enables blind replay is caught.

82-

process.env.OPENCLAW_STATE_DIR = tmpDir;

83-

const sendMatrix = vi

84-

.fn()

85-

.mockResolvedValueOnce({ messageId: "m1" })

86-

.mockRejectedValueOnce(new Error("second payload send failed"));

71+

const sendMatrix = createPartialSendFailure();

877288-

// Drive the patch: entry lands in unknown_after_send.

89-

await expect(

90-

deliverOutboundPayloads({

91-

cfg: {} as OpenClawConfig,

92-

channel: "matrix",

93-

to: "!room:example",

94-

payloads: [{ text: "first" }, { text: "second" }],

95-

deps: { matrix: sendMatrix },

96-

queuePolicy: "required",

97-

}),

98-

).rejects.toThrow("second payload send failed");

73+

await deliverPartialMatrixBatch(sendMatrix, tmpDir);

997410075

const beforeDrain = await loadPendingDeliveries(tmpDir);

10176

expect(beforeDrain[0]?.recoveryState).toBe("unknown_after_send");

10277103-

// Reconnect drain with no adapter (cfg={}) — reconcileUnknownQueuedDelivery

104-

// returns null → "refusing blind replay" branch → deliver is never called.

10578

const deliver = vi.fn<DeliverFn>(async () => {});

10679

await drainMatrixReconnect({ deliver, stateDir: tmpDir });

1078010881

expect(deliver).not.toHaveBeenCalled();

109-

// The entry is moved to failed (not re-queued as pending), closing the drain loop.

11082

expect(await loadPendingDeliveries(tmpDir)).toHaveLength(0);

11183

});

11284113-

it("leaves entry for retry (failDelivery, recovery_state stays null) when no send evidence", async () => {

85+

it("leaves entry for retry in send_attempt_started when no send evidence exists", async () => {

11486

process.env.OPENCLAW_STATE_DIR = tmpDir;

115-

// First (and only) payload fails immediately — no send evidence.

11687

const sendMatrix = vi.fn().mockRejectedValueOnce(new Error("first payload send failed"));

1178811889

await expect(

@@ -131,7 +102,6 @@ describe("deliverOutboundPayloads queue integration: mid-batch failure with send

131102

);

132103

expect(entries).toHaveLength(1);

133104

const entry = entries[0];

134-

// No send evidence -> failDelivery path: retryCount bumped, recovery_state not advanced.

135105

expect(entry.retryCount).toBe(1);

136106

expect(entry.recoveryState).toBe("send_attempt_started");

137107

expect(entry.lastError).toContain("first payload send failed");