惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

V
Visual Studio Blog
I
InfoQ
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
博客园 - 【当耐特】
小众软件
小众软件
B
Blog RSS Feed
大猫的无限游戏
大猫的无限游戏
博客园 - 三生石上(FineUI控件)
Engineering at Meta
Engineering at Meta
人人都是产品经理
人人都是产品经理
Microsoft Security Blog
Microsoft Security Blog
Last Week in AI
Last Week in AI
H
Help Net Security
爱范儿
爱范儿
云风的 BLOG
云风的 BLOG
博客园 - 司徒正美
Y
Y Combinator Blog
H
Hackread – Cybersecurity News, Data Breaches, AI and More
Microsoft Azure Blog
Microsoft Azure Blog
L
LangChain Blog
WordPress大学
WordPress大学
GbyAI
GbyAI
Google DeepMind News
Google DeepMind News
腾讯CDC

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
test(agent-runner): regression — createReplyMediaPathNorm...
ayeshakhalid · 2026-04-23 · via Recent Commits to openclaw:main

@@ -17,6 +17,7 @@ const enqueueFollowupRunMock = vi.fn();

1717

const scheduleFollowupDrainMock = vi.fn();

1818

const refreshQueuedFollowupSessionMock = vi.fn();

1919

const resolveOutboundAttachmentFromUrlMock = vi.fn();

20+

const createReplyMediaPathNormalizerRuntimeMock = vi.fn();

20212122

vi.mock("../../agents/model-fallback.js", () => ({

2223

runWithModelFallback: (params: {

@@ -52,6 +53,18 @@ vi.mock("../../media/outbound-attachment.js", () => ({

5253

resolveOutboundAttachmentFromUrlMock(...args),

5354

}));

545556+

// Spy on the .runtime import path used by agent-runner-execution.ts so we can assert

57+

// that the fix prevents a second normalizer from being created inside runAgentTurnWithFallback.

58+

vi.mock("./reply-media-paths.runtime.js", async (importOriginal) => {

59+

const mod = await importOriginal<typeof import("./reply-media-paths.runtime.js")>();

60+

return {

61+

createReplyMediaPathNormalizer: (...args: Parameters<typeof mod.createReplyMediaPathNormalizer>) => {

62+

createReplyMediaPathNormalizerRuntimeMock(...args);

63+

return mod.createReplyMediaPathNormalizer(...args);

64+

},

65+

};

66+

});

67+5568

let runReplyAgent: typeof import("./agent-runner.js").runReplyAgent;

56695770

describe("runReplyAgent media path normalization", () => {

@@ -73,6 +86,7 @@ describe("runReplyAgent media path normalization", () => {

7386

scheduleFollowupDrainMock.mockReset();

7487

refreshQueuedFollowupSessionMock.mockReset();

7588

resolveOutboundAttachmentFromUrlMock.mockReset();

89+

createReplyMediaPathNormalizerRuntimeMock.mockReset();

7690

vi.stubEnv("OPENCLAW_TEST_FAST", "1");

7791

resolveOutboundAttachmentFromUrlMock.mockImplementation(async (mediaUrl: string) => ({

7892

path: path.join("/tmp/outbound-media", path.basename(mediaUrl)),

@@ -160,4 +174,69 @@ describe("runReplyAgent media path normalization", () => {

160174

}),

161175

);

162176

});

177+178+

it("does not create a second normalizer inside runAgentTurnWithFallback when onBlockReply is provided", async () => {

179+

// Regression test for openclaw/openclaw#68056.

180+

// Before the fix, runAgentTurnWithFallback always called createReplyMediaPathNormalizer

181+

// from reply-media-paths.runtime.js to build its own normalizer instance — separate from

182+

// the one agent-runner.ts created and passed to buildReplyPayloads. Two separate

183+

// persistedMediaBySource caches meant the same source could be persisted twice (two UUID

184+

// outbound files, two WhatsApp sends).

185+

//

186+

// After the fix, agent-runner.ts passes its normalizer into runAgentTurnWithFallback, so

187+

// the .runtime import path is never called from inside that function.

188+

runEmbeddedPiAgentMock.mockResolvedValue({

189+

payloads: [],

190+

meta: {

191+

agentMeta: {

192+

sessionId: "session",

193+

provider: "anthropic",

194+

model: "claude",

195+

},

196+

},

197+

});

198+199+

await runReplyAgent({

200+

commandBody: "generate chart",

201+

followupRun: createMockFollowupRun({

202+

prompt: "generate chart",

203+

run: {

204+

agentId: "main",

205+

agentDir: "/tmp/agent",

206+

messageProvider: "whatsapp",

207+

workspaceDir: "/tmp/workspace",

208+

},

209+

}) as unknown as FollowupRun,

210+

queueKey: "main",

211+

resolvedQueue: { mode: "interrupt" } as QueueSettings,

212+

shouldSteer: false,

213+

shouldFollowup: false,

214+

isActive: false,

215+

isStreaming: false,

216+

typing: createMockTypingController(),

217+

sessionCtx: {

218+

Provider: "whatsapp",

219+

Surface: "whatsapp",

220+

To: "chat-1",

221+

OriginatingTo: "chat-1",

222+

AccountId: "default",

223+

MessageSid: "msg-1",

224+

} as unknown as TemplateContext,

225+

defaultModel: "anthropic/claude",

226+

resolvedVerboseLevel: "off",

227+

isNewSession: false,

228+

blockStreamingEnabled: false,

229+

resolvedBlockStreamingBreak: "message_end",

230+

shouldInjectGroupIntro: false,

231+

typingMode: "instant",

232+

opts: {

233+

onBlockReply: vi.fn(),

234+

},

235+

});

236+237+

// The .runtime import is only used by agent-runner-execution.ts. After the fix,

238+

// runAgentTurnWithFallback receives the normalizer from the caller and never

239+

// calls createReplyMediaPathNormalizer itself.

240+

expect(createReplyMediaPathNormalizerRuntimeMock).not.toHaveBeenCalled();

241+

});

163242

});