fix: address realtime voice review feedback · openclaw/op...

Recent Commits to openclaw:main

Solvely-Coli · 2026-05-10 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -243,10 +243,11 @@ export function buildRealtimeVoiceLaunchOptions(params: {`
`243`	`243`	`requested: RealtimeVoiceLaunchOptionInput;`
`244`	`244`	`defaults: RealtimeVoiceLaunchOptions;`
`245`	`245`	`}): RealtimeVoiceLaunchOptions {`
`246`		`-return withRealtimeBrowserOverrides(`
`247`		`-params.defaults,`
`248`		`-params.requested,`
`249`		`-) as RealtimeVoiceLaunchOptions;`
	`246`	`+const options = pickRealtimeVoiceLaunchOptions(params.defaults);`
	`247`	`+return {`
	`248`	`+ ...options,`
	`249`	`+ ...pickRealtimeVoiceLaunchOptions(params.requested),`
	`250`	`+};`
`250`	`251`	`}`
`251`	`252`
`252`	`253`	`export function withRealtimeBrowserOverrides(`
`@@ -278,6 +279,34 @@ export function withRealtimeBrowserOverrides(`
`278`	`279`	`return Object.keys(overrides).length > 0 ? { ...providerConfig, ...overrides } : providerConfig;`
`279`	`280`	`}`
`280`	`281`
	`282`	`+function pickRealtimeVoiceLaunchOptions(`
	`283`	`+params: RealtimeVoiceLaunchOptionInput,`
	`284`	`+): RealtimeVoiceLaunchOptions {`
	`285`	`+const options: RealtimeVoiceLaunchOptions = {};`
	`286`	`+const model = normalizeOptionalString(params.model);`
	`287`	`+const voice = normalizeOptionalString(params.voice);`
	`288`	`+const reasoningEffort = normalizeOptionalString(params.reasoningEffort);`
	`289`	`+if (model) {`
	`290`	`+options.model = model;`
	`291`	`+}`
	`292`	`+if (voice) {`
	`293`	`+options.voice = voice;`
	`294`	`+}`
	`295`	`+if (typeof params.vadThreshold === "number" && Number.isFinite(params.vadThreshold)) {`
	`296`	`+options.vadThreshold = params.vadThreshold;`
	`297`	`+}`
	`298`	`+if (typeof params.silenceDurationMs === "number" && Number.isFinite(params.silenceDurationMs)) {`
	`299`	`+options.silenceDurationMs = params.silenceDurationMs;`
	`300`	`+}`
	`301`	`+if (typeof params.prefixPaddingMs === "number" && Number.isFinite(params.prefixPaddingMs)) {`
	`302`	`+options.prefixPaddingMs = params.prefixPaddingMs;`
	`303`	`+}`
	`304`	`+if (reasoningEffort) {`
	`305`	`+options.reasoningEffort = reasoningEffort;`
	`306`	`+}`
	`307`	`+return options;`
	`308`	`+}`
	`309`	`+`
`281`	`310`	`export function isUnsupportedBrowserWebRtcSession(session: RealtimeVoiceBrowserSession): boolean {`
`282`	`311`	`const provider = normalizeLowercaseStringOrEmpty(session.provider);`
`283`	`312`	`const transport = (session as { transport?: string }).transport ?? "webrtc";`

Original file line number	Diff line number	Diff line change
`@@ -1199,7 +1199,7 @@ describe("talk.client.create handler", () => {`
`1199`	`1199`	`});`
`1200`	`1200`
`1201`	`1201`	`it("uses talk.realtime provider, model, voice, and instructions without reading speech provider config", async () => {`
`1202`		`-const createBrowserSession = vi.fn(async () => ({`
	`1202`	`+const createBrowserSession = vi.fn(async (_input: unknown) => ({`
`1203`	`1203`	`provider: "openai",`
`1204`	`1204`	`transport: "webrtc" as const,`
`1205`	`1205`	`clientSecret: "secret",`
`@@ -1264,6 +1264,10 @@ describe("talk.client.create handler", () => {`
`1264`	`1264`	`reasoningEffort: "low",`
`1265`	`1265`	`}),`
`1266`	`1266`	`);`
	`1267`	`+const createInput = createBrowserSession.mock.calls[0]?.[0] as Record<string, unknown>;`
	`1268`	`+expect(createInput).not.toHaveProperty("provider");`
	`1269`	`+expect(createInput).not.toHaveProperty("providers");`
	`1270`	`+expect(createInput).not.toHaveProperty("transport");`
`1267`	`1271`	`expect(respond).toHaveBeenCalledWith(`
`1268`	`1272`	`true,`
`1269`	`1273`	`expect.objectContaining({ provider: "openai", transport: "webrtc" }),`

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ export class GatewayRelayRealtimeTalkTransport implements RealtimeTalkTransport`
`142`	`142`	`"error",`
`143`	`143`	`error instanceof Error ? error.message : String(error),`
`144`	`144`	`);`
`145`		`-this.stopLocal();`
	`145`	`+this.stop();`
`146`	`146`	`}`
`147`	`147`	`});`
`148`	`148`	`};`

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,8 @@ describe("GatewayRelayRealtimeTalkTransport", () => {`
`247`	`247`	`.mocked(client.request)`
`248`	`248`	`.mock.calls.filter(([method]) => method === "talk.session.close");`
`249`	`249`	`expect(appendCalls).toHaveLength(1);`
`250`		`-expect(closeCalls).toHaveLength(0);`
	`250`	`+expect(closeCalls).toHaveLength(1);`
	`251`	`+expect(closeCalls[0]?.[1]).toEqual({ sessionId: "relay-1" });`
`251`	`252`	`});`
`252`	`253`
`253`	`254`	`it("treats relay close events as local shutdown", async () => {`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main