惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Last Week in AI
Last Week in AI
有赞技术团队
有赞技术团队
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
人人都是产品经理
人人都是产品经理
博客园 - 司徒正美
博客园 - 聂微东
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
博客园 - 叶小钗
罗磊的独立博客
IT之家
IT之家
博客园 - 三生石上(FineUI控件)
V
Visual Studio Blog
T
Tailwind CSS Blog
大猫的无限游戏
大猫的无限游戏
Hugging Face - Blog
Hugging Face - Blog
H
Hackread – Cybersecurity News, Data Breaches, AI and More
N
Netflix TechBlog - Medium
MyScale Blog
MyScale Blog
J
Java Code Geeks
L
LangChain Blog
S
SegmentFault 最新的问题
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
Apple Machine Learning Research
Apple Machine Learning Research
G
Google Developers Blog

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
test: tighten exec approval forwarder assertions · opencl...
steipete · 2026-05-11 · via Recent Commits to openclaw:main

@@ -199,6 +199,31 @@ function getFirstDeliveryText(deliver: ReturnType<typeof vi.fn>): string {

199199

return firstCall?.payloads?.[0]?.text ?? "";

200200

}

201201202+

function requireRecord(value: unknown, label: string): Record<string, unknown> {

203+

if (!value || typeof value !== "object") {

204+

throw new Error(`expected ${label} to be an object`);

205+

}

206+

return value as Record<string, unknown>;

207+

}

208+209+

function requireFirstCallArg(

210+

mock: ReturnType<typeof vi.fn>,

211+

label: string,

212+

): Record<string, unknown> {

213+

return requireRecord(mock.mock.calls[0]?.[0], label);

214+

}

215+216+

function requireFirstPayload(deliver: ReturnType<typeof vi.fn>): ReplyPayload {

217+

const delivery = requireFirstCallArg(deliver, "delivery params") as {

218+

payloads?: ReplyPayload[];

219+

};

220+

const payload = delivery.payloads?.[0];

221+

if (!payload) {

222+

throw new Error("expected first delivery payload");

223+

}

224+

return payload;

225+

}

226+202227

function makeTargetsCfg(targets: Array<{ channel: string; to: string }>): OpenClawConfig {

203228

return {

204229

approvals: {

@@ -435,12 +460,11 @@ describe("exec approval forwarder", () => {

435460

await expect(forwarder.handleRequested(baseRequest)).resolves.toBe(true);

436461

await flushPendingDelivery();

437462

expect(deliver).toHaveBeenCalled();

438-

expect(beforeDeliverPayload).toHaveBeenCalledWith(

439-

expect.objectContaining({

440-

hint: { kind: "approval-pending", approvalKind: "exec" },

441-

target: expect.objectContaining({ channel: "slack", to: "U123" }),

442-

}),

443-

);

463+

const hookParams = requireFirstCallArg(beforeDeliverPayload, "beforeDeliverPayload params");

464+

expect(hookParams.hint).toEqual({ kind: "approval-pending", approvalKind: "exec" });

465+

const target = requireRecord(hookParams.target, "delivery target");

466+

expect(target.channel).toBe("slack");

467+

expect(target.to).toBe("U123");

444468

});

445469446470

it("skips telegram forwarding when telegram exec approvals handler is enabled", async () => {

@@ -502,45 +526,35 @@ describe("exec approval forwarder", () => {

502526

).resolves.toBe(true);

503527504528

expect(deliver).toHaveBeenCalledTimes(1);

505-

expect(deliver).toHaveBeenCalledWith(

506-

expect.objectContaining({

507-

channel: "telegram",

508-

to: "123",

509-

payloads: [

510-

expect.objectContaining({

511-

channelData: expect.objectContaining({

512-

execApproval: expect.objectContaining({

513-

approvalId: "req-1",

514-

}),

515-

}),

516-

interactive: expect.objectContaining({

517-

blocks: [

518-

{

519-

type: "buttons",

520-

buttons: [

521-

{

522-

label: "Allow Once",

523-

value: "/approve req-1 allow-once",

524-

style: "success",

525-

},

526-

{

527-

label: "Allow Always",

528-

value: "/approve req-1 allow-always",

529-

style: "primary",

530-

},

531-

{

532-

label: "Deny",

533-

value: "/approve req-1 deny",

534-

style: "danger",

535-

},

536-

],

537-

},

538-

],

539-

}),

540-

}),

541-

],

542-

}),

543-

);

529+

const delivery = requireFirstCallArg(deliver, "delivery params");

530+

expect(delivery.channel).toBe("telegram");

531+

expect(delivery.to).toBe("123");

532+

const payload = requireFirstPayload(deliver);

533+

expect(payload.channelData?.execApproval).toEqual({ approvalId: "req-1" });

534+

expect(payload.interactive).toEqual({

535+

blocks: [

536+

{

537+

type: "buttons",

538+

buttons: [

539+

{

540+

label: "Allow Once",

541+

value: "/approve req-1 allow-once",

542+

style: "success",

543+

},

544+

{

545+

label: "Allow Always",

546+

value: "/approve req-1 allow-always",

547+

style: "primary",

548+

},

549+

{

550+

label: "Deny",

551+

value: "/approve req-1 deny",

552+

style: "danger",

553+

},

554+

],

555+

},

556+

],

557+

});

544558

});

545559546560

it("stores exec metadata on generic forwarded fallback payloads", async () => {

@@ -550,22 +564,12 @@ describe("exec approval forwarder", () => {

550564

await expect(forwarder.handleRequested(baseRequest)).resolves.toBe(true);

551565552566

expect(deliver).toHaveBeenCalledTimes(1);

553-

expect(deliver.mock.calls[0]?.[0]).toEqual(

554-

expect.objectContaining({

555-

payloads: [

556-

expect.objectContaining({

557-

channelData: expect.objectContaining({

558-

execApproval: expect.objectContaining({

559-

approvalId: "req-1",

560-

approvalKind: "exec",

561-

agentId: "main",

562-

sessionKey: "agent:main:main",

563-

}),

564-

}),

565-

}),

566-

],

567-

}),

568-

);

567+

const payload = requireFirstPayload(deliver);

568+

const execApproval = requireRecord(payload.channelData?.execApproval, "exec approval metadata");

569+

expect(execApproval.approvalId).toBe("req-1");

570+

expect(execApproval.approvalKind).toBe("exec");

571+

expect(execApproval.agentId).toBe("main");

572+

expect(execApproval.sessionKey).toBe("agent:main:main");

569573

});

570574571575

it("formats single-line commands as inline code", async () => {