惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

I
InfoQ
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
Apple Machine Learning Research
Apple Machine Learning Research
月光博客
月光博客
B
Blog
罗磊的独立博客
GbyAI
GbyAI
博客园 - 三生石上(FineUI控件)
雷峰网
雷峰网
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
Microsoft Security Blog
Microsoft Security Blog
宝玉的分享
宝玉的分享
The GitHub Blog
The GitHub Blog
人人都是产品经理
人人都是产品经理
博客园 - Franky
有赞技术团队
有赞技术团队
WordPress大学
WordPress大学
博客园 - 聂微东
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
V
Visual Studio Blog
MyScale Blog
MyScale Blog
Google DeepMind News
Google DeepMind News
G
Google Developers Blog
aimingoo的专栏
aimingoo的专栏

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
Fix brew-only skill installs in Docker (#82845) · opencla...
amknight · 2026-05-17 · via Recent Commits to openclaw:main

@@ -1,4 +1,4 @@

1-

import { describe, expect, it, vi } from "vitest";

1+

import { afterEach, describe, expect, it, vi } from "vitest";

22

import type { OpenClawConfig } from "../config/config.js";

33

import type { RuntimeEnv } from "../runtime.js";

44

import type { WizardPrompter } from "../wizard/prompts.js";

@@ -7,6 +7,8 @@ const mocks = vi.hoisted(() => ({

77

buildWorkspaceSkillStatus: vi.fn(),

88

installSkill: vi.fn(),

99

detectBinary: vi.fn(),

10+

isContainerEnvironment: vi.fn(),

11+

resolveBrewExecutable: vi.fn(),

1012

resolveNodeManagerOptions: vi.fn(() => [

1113

{ value: "npm", label: "npm" },

1214

{ value: "pnpm", label: "pnpm" },

@@ -21,6 +23,12 @@ vi.mock("../agents/skills-status.js", () => ({

2123

vi.mock("../agents/skills-install.js", () => ({

2224

installSkill: mocks.installSkill,

2325

}));

26+

vi.mock("../infra/container-environment.js", () => ({

27+

isContainerEnvironment: mocks.isContainerEnvironment,

28+

}));

29+

vi.mock("../infra/brew.js", () => ({

30+

resolveBrewExecutable: mocks.resolveBrewExecutable,

31+

}));

2432

vi.mock("./onboard-helpers.js", () => ({

2533

detectBinary: mocks.detectBinary,

2634

resolveNodeManagerOptions: mocks.resolveNodeManagerOptions,

@@ -78,6 +86,7 @@ function createBundledSkill(params: {

78867987

function mockMissingBrewStatus(skills: Array<ReturnType<typeof createBundledSkill>>): void {

8088

mocks.detectBinary.mockResolvedValue(false);

89+

mocks.resolveBrewExecutable.mockReturnValue(undefined);

8190

mocks.installSkill.mockResolvedValue({

8291

ok: true,

8392

message: "Installed",

@@ -134,6 +143,66 @@ const runtime: RuntimeEnv = {

134143

};

135144136145

describe("setupSkills", () => {

146+

afterEach(() => {

147+

mocks.isContainerEnvironment.mockReset();

148+

mocks.resolveBrewExecutable.mockReset();

149+

});

150+151+

it("hides brew-only installs in Linux containers when brew is missing", async () => {

152+

const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, "platform")!;

153+

Object.defineProperty(process, "platform", { value: "linux", configurable: true });

154+

try {

155+

mockMissingBrewStatus([

156+

createBundledSkill({

157+

name: "video-frames",

158+

description: "ffmpeg",

159+

bins: ["ffmpeg"],

160+

installLabel: "Install ffmpeg (brew)",

161+

}),

162+

]);

163+

mocks.isContainerEnvironment.mockReturnValue(true);

164+165+

const { prompter, notes } = createPrompter({});

166+

await setupSkills({} as OpenClawConfig, "/tmp/ws", runtime, prompter);

167+168+

expect(prompter.multiselect).not.toHaveBeenCalled();

169+

expect(mocks.installSkill).not.toHaveBeenCalled();

170+

expect(notes.find((n) => n.title === "Container skill installs")).toBeDefined();

171+

expect(notes.find((n) => n.title === "Homebrew recommended")).toBeUndefined();

172+

} finally {

173+

Object.defineProperty(process, "platform", originalPlatformDescriptor);

174+

}

175+

});

176+177+

it("keeps brew-only installs visible when Linuxbrew is resolved off PATH", async () => {

178+

const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, "platform")!;

179+

Object.defineProperty(process, "platform", { value: "linux", configurable: true });

180+

try {

181+

mockMissingBrewStatus([

182+

createBundledSkill({

183+

name: "video-frames",

184+

description: "ffmpeg",

185+

bins: ["ffmpeg"],

186+

installLabel: "Install ffmpeg (brew)",

187+

}),

188+

]);

189+

mocks.isContainerEnvironment.mockReturnValue(true);

190+

mocks.resolveBrewExecutable.mockReturnValue("/home/linuxbrew/.linuxbrew/bin/brew");

191+192+

const { prompter, notes } = createPrompter({ multiselect: ["video-frames"] });

193+

await setupSkills({} as OpenClawConfig, "/tmp/ws", runtime, prompter);

194+195+

expect(prompter.multiselect).toHaveBeenCalled();

196+

expect(mocks.installSkill).toHaveBeenCalledWith(

197+

expect.objectContaining({ skillName: "video-frames", installId: "brew" }),

198+

);

199+

expect(notes.find((n) => n.title === "Container skill installs")).toBeUndefined();

200+

expect(notes.find((n) => n.title === "Homebrew recommended")).toBeUndefined();

201+

} finally {

202+

Object.defineProperty(process, "platform", originalPlatformDescriptor);

203+

}

204+

});

205+137206

it("does not recommend Homebrew when user skips installing brew-backed deps", async () => {

138207

if (process.platform === "win32") {

139208

return;