惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

D
DataBreaches.Net
B
Blog
博客园_首页
C
Check Point Blog
Microsoft Security Blog
Microsoft Security Blog
MyScale Blog
MyScale Blog
P
Proofpoint News Feed
Engineering at Meta
Engineering at Meta
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
B
Blog RSS Feed
M
MIT News - Artificial intelligence
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
WordPress大学
WordPress大学
宝玉的分享
宝玉的分享
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
The Cloudflare Blog
量子位
V
V2EX
Y
Y Combinator Blog
Hugging Face - Blog
Hugging Face - Blog
Martin Fowler
Martin Fowler
Recent Announcements
Recent Announcements
I
InfoQ
博客园 - 【当耐特】

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix: prevent duplicate chat attachment send races · openc...
steipete · 2026-04-26 · via Recent Commits to openclaw:main

@@ -5,9 +5,11 @@ import { afterAll, beforeAll, describe, expect, test, vi } from "vitest";

55

import type { GetReplyOptions } from "../auto-reply/get-reply-options.types.js";

66

import { clearConfigCache } from "../config/config.js";

77

import { __setMaxChatHistoryMessagesBytesForTest } from "./server-constants.js";

8+

import type { GatewayRequestContext, RespondFn } from "./server-methods/shared-types.js";

89

import {

910

connectOk,

1011

createGatewaySuiteHarness,

12+

dispatchInboundMessageMock,

1113

getReplyFromConfig,

1214

installGatewayTestHooks,

1315

mockGetReplyFromConfigOnce,

@@ -47,6 +49,16 @@ const sendReq = (

4749

);

4850

};

495152+

function createDeferred<T>() {

53+

let resolve!: (value: T | PromiseLike<T>) => void;

54+

let reject!: (reason?: unknown) => void;

55+

const promise = new Promise<T>((res, rej) => {

56+

resolve = res;

57+

reject = rej;

58+

});

59+

return { promise, resolve, reject };

60+

}

61+5062

async function withGatewayChatHarness(

5163

run: (ctx: { ws: GatewaySocket; createSessionDir: () => Promise<string> }) => Promise<void>,

5264

) {

@@ -123,6 +135,130 @@ async function prepareMainHistoryHarness(params: {

123135

}

124136125137

describe("gateway server chat", () => {

138+

test("chat.send returns in_flight when duplicate attachment send wins parsing race", async () => {

139+

const sessionDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-gw-"));

140+

const dispatchRelease = createDeferred<void>();

141+

try {

142+

testState.sessionStorePath = path.join(sessionDir, "sessions.json");

143+

await writeSessionStore({

144+

entries: {

145+

main: {

146+

sessionId: "sess-main",

147+

modelProvider: "test-provider",

148+

model: "vision-model",

149+

updatedAt: Date.now(),

150+

},

151+

},

152+

});

153+154+

const firstCatalog =

155+

createDeferred<Awaited<ReturnType<GatewayRequestContext["loadGatewayModelCatalog"]>>>();

156+

const responses: Array<{ id: string; ok: boolean; payload?: unknown; error?: unknown }> = [];

157+

const context = {

158+

loadGatewayModelCatalog: vi

159+

.fn<GatewayRequestContext["loadGatewayModelCatalog"]>()

160+

.mockImplementationOnce(() => firstCatalog.promise)

161+

.mockResolvedValue([

162+

{

163+

id: "vision-model",

164+

name: "Vision Model",

165+

provider: "test-provider",

166+

input: ["text", "image"],

167+

},

168+

]),

169+

logGateway: {

170+

info: vi.fn(),

171+

warn: vi.fn(),

172+

error: vi.fn(),

173+

debug: vi.fn(),

174+

},

175+

agentRunSeq: new Map<string, number>(),

176+

chatAbortControllers: new Map(),

177+

chatAbortedRuns: new Map(),

178+

chatRunBuffers: new Map(),

179+

chatDeltaSentAt: new Map(),

180+

chatDeltaLastBroadcastLen: new Map(),

181+

addChatRun: vi.fn(),

182+

removeChatRun: vi.fn(),

183+

broadcast: vi.fn(),

184+

nodeSendToSession: vi.fn(),

185+

registerToolEventRecipient: vi.fn(),

186+

dedupe: new Map(),

187+

} as unknown as GatewayRequestContext;

188+

dispatchInboundMessageMock.mockImplementation(async () => dispatchRelease.promise);

189+190+

const pngB64 =

191+

"iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/woAAn8B9FD5fHAAAAAASUVORK5CYII=";

192+

const params = {

193+

sessionKey: "main",

194+

message: "see image",

195+

idempotencyKey: "idem-attachment-race",

196+

attachments: [

197+

{

198+

type: "image",

199+

mimeType: "image/png",

200+

fileName: "dot.png",

201+

content: pngB64,

202+

},

203+

],

204+

};

205+

const { chatHandlers } = await import("./server-methods/chat.js");

206+

const callSend = (id: string) =>

207+

chatHandlers["chat.send"]({

208+

req: { type: "req", id, method: "chat.send", params },

209+

params,

210+

client: null,

211+

isWebchatConnect: () => false,

212+

respond: ((ok, payload, error) => {

213+

responses.push({ id, ok, payload, error });

214+

}) as RespondFn,

215+

context,

216+

});

217+218+

const first = Promise.resolve(callSend("first"));

219+

await vi.waitFor(() => {

220+

expect(context.loadGatewayModelCatalog).toHaveBeenCalledTimes(1);

221+

}, FAST_WAIT_OPTS);

222+223+

await callSend("duplicate");

224+

expect(responses).toContainEqual({

225+

id: "duplicate",

226+

ok: true,

227+

payload: { runId: "idem-attachment-race", status: "started" },

228+

error: undefined,

229+

});

230+231+

firstCatalog.resolve([

232+

{

233+

id: "vision-model",

234+

name: "Vision Model",

235+

provider: "test-provider",

236+

input: ["text", "image"],

237+

},

238+

]);

239+

await first;

240+241+

expect(responses).toContainEqual({

242+

id: "first",

243+

ok: true,

244+

payload: { runId: "idem-attachment-race", status: "in_flight" },

245+

error: undefined,

246+

});

247+

expect(dispatchInboundMessageMock).toHaveBeenCalledTimes(1);

248+

expect(context.addChatRun).toHaveBeenCalledTimes(1);

249+

dispatchRelease.resolve();

250+

await vi.waitFor(() => {

251+

expect(context.removeChatRun).toHaveBeenCalledTimes(1);

252+

}, FAST_WAIT_OPTS);

253+

} finally {

254+

dispatchRelease.resolve();

255+

dispatchInboundMessageMock.mockReset();

256+

testState.sessionStorePath = undefined;

257+

clearConfigCache();

258+

await fs.rm(sessionDir, { recursive: true, force: true });

259+

}

260+

});

261+126262

test("chat.history backfills claude-cli sessions from Claude project files", async () => {

127263

await withGatewayChatHarness(async ({ ws, createSessionDir }) => {

128264

await connectOk(ws);