fix(ci): address review sweep regressions · openclaw/openclaw@6a48258
steipete
·
2026-05-24
·
via Recent Commits to openclaw:main
| Original file line number | Diff line number | Diff line change |
|---|
@@ -62,7 +62,7 @@ function waitForNativePreferenceGrace(
|
62 | 62 | return new Promise((resolve) => { |
63 | 63 | const timer = setTimeout(() => resolve({ ok: false }), NATIVE_PREFERENCE_GRACE_MS); |
64 | 64 | timer.unref?.(); |
65 | | -nativeResultPromise.then((result) => { |
| 65 | +void nativeResultPromise.then((result) => { |
66 | 66 | clearTimeout(timer); |
67 | 67 | resolve(result); |
68 | 68 | }); |
|
| Original file line number | Diff line number | Diff line change |
|---|
@@ -49,7 +49,12 @@ export class TwitchClientManager {
|
49 | 49 | ); |
50 | 50 | this.logger.info(`Added user ${userId} to RefreshingAuthProvider for ${account.username}`); |
51 | 51 | } catch (err) { |
52 | | -throw new Error(`Failed to add user to RefreshingAuthProvider: ${formatErrorMessage(err)}`); |
| 52 | +throw new Error( |
| 53 | +`Failed to add user to RefreshingAuthProvider: ${formatErrorMessage(err)}`, |
| 54 | +{ |
| 55 | +cause: err, |
| 56 | +}, |
| 57 | +); |
53 | 58 | } |
54 | 59 | |
55 | 60 | authProvider.onRefresh((userId, token) => { |
|
| Original file line number | Diff line number | Diff line change |
|---|
@@ -49,7 +49,7 @@ function fishWords(values: readonly string[]): string {
|
49 | 49 | |
50 | 50 | function fishOptionFlags(options: Command["options"], wantsValue: boolean): string[] { |
51 | 51 | return options.flatMap((option) => { |
52 | | -if (Boolean(option.required || option.optional) !== wantsValue) { |
| 52 | +if ((option.required || option.optional) !== wantsValue) { |
53 | 53 | return []; |
54 | 54 | } |
55 | 55 | return splitOptionFlags(option.flags).filter((flag) => flag.startsWith("-")); |
|
| Original file line number | Diff line number | Diff line change |
|---|
@@ -254,15 +254,17 @@ export function registerCronEditCommand(cron: Command) {
|
254 | 254 | typeof opts.channel === "string" || typeof opts.to === "string" || hasDeliveryThreadId; |
255 | 255 | const hasDeliveryAccount = typeof opts.account === "string"; |
256 | 256 | const hasBestEffort = typeof opts.bestEffortDeliver === "boolean"; |
257 | | -const hasAgentTurnPatch = |
| 257 | +const hasAgentTurnPayloadField = |
258 | 258 | typeof opts.message === "string" || |
259 | 259 | Boolean(model) || |
260 | 260 | Boolean(thinking) || |
261 | 261 | hasTimeoutSeconds || |
262 | 262 | typeof opts.lightContext === "boolean" || |
263 | 263 | typeof opts.tools === "string" || |
264 | 264 | Array.isArray(opts.tools) || |
265 | | -opts.clearTools || |
| 265 | +opts.clearTools; |
| 266 | +const hasAgentTurnPatch = |
| 267 | +hasAgentTurnPayloadField || |
266 | 268 | hasDeliveryModeFlag || |
267 | 269 | hasDeliveryTarget || |
268 | 270 | hasDeliveryAccount || |
@@ -299,8 +301,11 @@ export function registerCronEditCommand(cron: Command) {
|
299 | 301 | const delivery: Record<string, unknown> = {}; |
300 | 302 | if (hasDeliveryModeFlag) { |
301 | 303 | delivery.mode = opts.announce || opts.deliver === true ? "announce" : "none"; |
302 | | -} else if (opts.bestEffortDeliver === true) { |
303 | | -// Back-compat: toggling best-effort alone has historically implied announce mode. |
| 304 | +} else if ( |
| 305 | +opts.bestEffortDeliver === true || |
| 306 | +(hasAgentTurnPayloadField && hasBestEffort) |
| 307 | +) { |
| 308 | +// Back-compat: best-effort true and payload edits historically implied announce mode. |
304 | 309 | delivery.mode = "announce"; |
305 | 310 | } |
306 | 311 | if (typeof opts.channel === "string") { |
|
此内容由惯性聚合(RSS阅读器)自动聚合整理,仅供阅读参考。 原文来自 — 版权归原作者所有。