test: guard plugin object helpers · openclaw/openclaw@860...

Recent Commits to openclaw:main

steipete · 2026-05-12 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,9 @@ function createAutoEnabledCliFixture() {`
`103`	`103`
`104`	`104`	`function getMockCallObject(mock: ReturnType<typeof vi.fn>, callIndex = 0, argIndex = 0) {`
`105`	`105`	`const value = mock.mock.calls[callIndex]?.[argIndex];`
`106`		`-expect(typeof value).toBe("object");`
`107`		`-expect(value).not.toBeNull();`
	`106`	`+if (!value \|\| typeof value !== "object") {`
	`107`	+throw new Error(`expected mock call ${callIndex} arg ${argIndex} object`);
	`108`	`+}`
`108`	`109`	`return value as Record<string, unknown>;`
`109`	`110`	`}`
`110`	`111`

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,9 @@ function collectSchemaPaths(schema: unknown, prefix = ""): string[] {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`function asRecord(value: unknown): Record<string, unknown> {`
`56`		`-expect(value).not.toBeNull();`
`57`		`-expect(typeof value).toBe("object");`
	`56`	`+if (!value \|\| typeof value !== "object") {`
	`57`	`+throw new Error("expected record");`
	`58`	`+}`
`58`	`59`	`expect(Array.isArray(value)).toBe(false);`
`59`	`60`	`return value as Record<string, unknown>;`
`60`	`61`	`}`

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,9 @@ import { createPluginRecord } from "../status.test-helpers.js";`
`18`	`18`	`import { runTrustedToolPolicies } from "../trusted-tool-policy.js";`
`19`	`19`
`20`	`20`	`function requireRecord(value: unknown, label: string): Record<string, unknown> {`
`21`		`-expect(value, label).toBeTypeOf("object");`
`22`		`-expect(value, label).not.toBeNull();`
	`21`	`+if (!value \|\| typeof value !== "object") {`
	`22`	+throw new Error(`expected ${label}`);
	`23`	`+}`
`23`	`24`	`return value as Record<string, unknown>;`
`24`	`25`	`}`
`25`	`26`

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ function expectedGitRepoDir(params: { gitDir: string; normalizedSpec: string }):`
`35`	`35`
`36`	`36`	`function expectParsedGitSpec(spec: string) {`
`37`	`37`	`const parsed = parseGitPluginSpec(spec);`
`38`		`-expect(parsed).not.toBeNull();`
`39`	`38`	`if (!parsed) {`
`40`	`39`	throw new Error(`Expected ${spec} to parse as a git plugin spec`);
`41`	`40`	`}`

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ function createCandidate(rootDir: string, options: { id?: string } = {}): Plugin`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`function requirePersisted(index: InstalledPluginIndex \| null): InstalledPluginIndex {`
`83`		`-expect(index).not.toBeNull();`
`84`	`83`	`if (!index) {`
`85`	`84`	`throw new Error("Expected persisted installed plugin index");`
`86`	`85`	`}`

Original file line number	Diff line number	Diff line change
`@@ -156,15 +156,17 @@ async function expectRemoteMarketplaceError(params: { manifest: unknown; expecte`
`156`	`156`
`157`	`157`	`function installPluginInput(callIndex = 0): Record<string, unknown> {`
`158`	`158`	`const input = installPluginFromPathMock.mock.calls[callIndex]?.[0];`
`159`		`-expect(typeof input).toBe("object");`
`160`		`-expect(input).not.toBeNull();`
	`159`	`+if (!input \|\| typeof input !== "object") {`
	`160`	+throw new Error(`expected install plugin input ${callIndex}`);
	`161`	`+}`
`161`	`162`	`return input as Record<string, unknown>;`
`162`	`163`	`}`
`163`	`164`
`164`	`165`	`function fetchGuardInput(callIndex = 0): Record<string, unknown> {`
`165`	`166`	`const input = fetchWithSsrFGuardMock.mock.calls[callIndex]?.[0];`
`166`		`-expect(typeof input).toBe("object");`
`167`		`-expect(input).not.toBeNull();`
	`167`	`+if (!input \|\| typeof input !== "object") {`
	`168`	+throw new Error(`expected fetch guard input ${callIndex}`);
	`169`	`+}`
`168`	`170`	`return input as Record<string, unknown>;`
`169`	`171`	`}`
`170`	`172`
`@@ -176,8 +178,9 @@ function expectMarketplaceInstallSuccess(`
`176`	`178`	`marketplaceSource?: string;`
`177`	`179`	`},`
`178`	`180`	`) {`
`179`		`-expect(typeof result).toBe("object");`
`180`		`-expect(result).not.toBeNull();`
	`181`	`+if (!result \|\| typeof result !== "object") {`
	`182`	`+throw new Error("expected marketplace install result");`
	`183`	`+}`
`181`	`184`	`const record = result as Record<string, unknown>;`
`182`	`185`	`expect(record.ok).toBe(true);`
`183`	`186`	`expect(record.pluginId).toBe(params.pluginId ?? "frontend-design");`

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,9 @@ function asPluginModuleLoaderFactory(factory: unknown): PluginModuleLoaderFactor`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`function requireRecord(value: unknown, label: string): Record<string, unknown> {`
`38`		`-expect(value, label).toBeTypeOf("object");`
`39`		`-expect(value, label).not.toBeNull();`
	`38`	`+if (!value \|\| typeof value !== "object") {`
	`39`	+throw new Error(`expected ${label}`);
	`40`	`+}`
`40`	`41`	`return value as Record<string, unknown>;`
`41`	`42`	`}`
`42`	`43`

Original file line number	Diff line number	Diff line change
`@@ -150,8 +150,9 @@ function createIndex(`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`function requireRecord(value: unknown, label: string): Record<string, unknown> {`
`153`		`-expect(typeof value, label).toBe("object");`
`154`		`-expect(value, label).not.toBeNull();`
	`153`	`+if (!value \|\| typeof value !== "object") {`
	`154`	+throw new Error(`expected ${label}`);
	`155`	`+}`
`155`	`156`	`return value as Record<string, unknown>;`
`156`	`157`	`}`
`157`	`158`
`@@ -838,7 +839,6 @@ describe("plugin registry facade", () => {`
`838`	`839`	`});`
`839`	`840`
`840`	`841`	`const persisted = await readPersistedInstalledPluginIndex({ stateDir });`
`841`		`-expect(persisted).not.toBeNull();`
`842`	`842`	`if (!persisted) {`
`843`	`843`	`throw new Error("Expected persisted plugin index");`
`844`	`844`	`}`

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@ function createCodexCredentials(extra: Record<string, unknown> = {}) {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`function expectFields(value: unknown, expected: Record<string, unknown>): void {`
`68`		`-expect(value).toBeTypeOf("object");`
`69`		`-expect(value).not.toBeNull();`
	`68`	`+if (!value \|\| typeof value !== "object") {`
	`69`	`+throw new Error("expected fields object");`
	`70`	`+}`
`70`	`71`	`const record = value as Record<string, unknown>;`
`71`	`72`	`for (const [key, expectedValue] of Object.entries(expected)) {`
`72`	`73`	`expect(record[key], key).toEqual(expectedValue);`

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@ type MockCalls = {`
`65`	`65`	`};`
`66`	`66`
`67`	`67`	`function requireRecord(value: unknown, label: string): Record<string, unknown> {`
`68`		`-expect(typeof value, label).toBe("object");`
`69`		`-expect(value, label).not.toBeNull();`
	`68`	`+if (!value \|\| typeof value !== "object") {`
	`69`	+throw new Error(`expected ${label}`);
	`70`	`+}`
`70`	`71`	`return value as Record<string, unknown>;`
`71`	`72`	`}`
`72`	`73`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main