惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

爱范儿
爱范儿
WordPress大学
WordPress大学
博客园 - 【当耐特】
The Cloudflare Blog
B
Blog
Last Week in AI
Last Week in AI
小众软件
小众软件
量子位
S
SegmentFault 最新的问题
V
Visual Studio Blog
博客园 - 叶小钗
美团技术团队
阮一峰的网络日志
阮一峰的网络日志
Hugging Face - Blog
Hugging Face - Blog
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
宝玉的分享
宝玉的分享
A
About on SuperTechFans
雷峰网
雷峰网
J
Java Code Geeks
Microsoft Azure Blog
Microsoft Azure Blog
腾讯CDC
MongoDB | Blog
MongoDB | Blog
酷 壳 – CoolShell
酷 壳 – CoolShell
Martin Fowler
Martin Fowler

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(canvas): reject invalid snapshot formats · openclaw/o...
steipete · 2026-05-26 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -113,4 +113,21 @@ describe("canvas CLI", () => {

113113

).rejects.toThrow(/invalid canvas\.snapshot payload/i);

114114

expect(writtenFiles).toHaveLength(0);

115115

});

116+
117+

it("rejects unsupported snapshot formats before invoking the node", async () => {

118+

const program = new Command();

119+

program.exitOverride();

120+

const nodes = program.command("nodes");

121+

const { deps, writtenFiles } = createCanvasCliDeps();

122+
123+

registerNodesCanvasCommands(nodes, deps);

124+
125+

await expect(

126+

program.parseAsync(["nodes", "canvas", "snapshot", "--node", "ios-node", "--format", "gif"], {

127+

from: "user",

128+

}),

129+

).rejects.toThrow(/invalid format: gif/i);

130+

expect(deps.callGatewayCli).not.toHaveBeenCalled();

131+

expect(writtenFiles).toHaveLength(0);

132+

});

116133

});

Original file line numberDiff line numberDiff line change

@@ -68,6 +68,20 @@ export type CanvasCliDependencies = {

6868

};

6969
7070

type CanvasNodeCandidate = NodeMatchCandidate;

71+

type CanvasSnapshotRequestFormat = "png" | "jpeg";

72+
73+

function parseCanvasSnapshotRequestFormat(raw: unknown): CanvasSnapshotRequestFormat {

74+

const format = normalizeLowercaseStringOrEmpty(normalizeOptionalString(raw) ?? "jpg");

75+

switch (format) {

76+

case "png":

77+

return "png";

78+

case "jpg":

79+

case "jpeg":

80+

return "jpeg";

81+

default:

82+

throw new Error(`invalid format: ${String(raw)} (expected png|jpg|jpeg)`);

83+

}

84+

}

7185
7286

function parseTimeoutMs(raw: unknown): number | undefined {

7387

if (raw === undefined || raw === null) {

@@ -234,19 +248,11 @@ export function registerNodesCanvasCommands(nodes: Command, deps: CanvasCliDepen

234248

.option("--invoke-timeout <ms>", "Node invoke timeout in ms (default 20000)", "20000")

235249

.action(async (opts: CanvasNodesRpcOpts) => {

236250

await deps.runNodesCommand("canvas snapshot", async () => {

237-

const formatOpt = normalizeLowercaseStringOrEmpty(

238-

normalizeOptionalString(opts.format) ?? "jpg",

239-

);

240-

const formatForParams =

241-

formatOpt === "jpg" ? "jpeg" : formatOpt === "jpeg" ? "jpeg" : "png";

242-

if (formatForParams !== "png" && formatForParams !== "jpeg") {

243-

throw new Error(`invalid format: ${String(opts.format)} (expected png|jpg|jpeg)`);

244-

}

245-
251+

const format = parseCanvasSnapshotRequestFormat(opts.format);

246252

const maxWidth = opts.maxWidth ? Number.parseInt(opts.maxWidth, 10) : undefined;

247253

const quality = opts.quality ? Number.parseFloat(opts.quality) : undefined;

248254

const raw = await invokeCanvas(deps, opts, "canvas.snapshot", {

249-

format: formatForParams,

255+

format,

250256

maxWidth: Number.isFinite(maxWidth) ? maxWidth : undefined,

251257

quality: Number.isFinite(quality) ? quality : undefined,

252258

});