惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

博客园_首页
博客园 - Franky
大猫的无限游戏
大猫的无限游戏
博客园 - 三生石上(FineUI控件)
量子位
博客园 - 聂微东
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
S
SegmentFault 最新的问题
Apple Machine Learning Research
Apple Machine Learning Research
爱范儿
爱范儿
V
Visual Studio Blog
雷峰网
雷峰网
T
Tailwind CSS Blog
宝玉的分享
宝玉的分享
Blog — PlanetScale
Blog — PlanetScale
有赞技术团队
有赞技术团队
博客园 - 叶小钗
Microsoft Azure Blog
Microsoft Azure Blog
T
The Blog of Author Tim Ferriss
U
Unit 42
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
小众软件
小众软件
阮一峰的网络日志
阮一峰的网络日志
Y
Y Combinator Blog

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(canvas): validate CLI numeric options · openclaw/open...
rohitjavvadi · 2026-06-14 · via Recent Commits to openclaw:main
11

// Canvas tests cover cli plugin behavior.

22

import { Command } from "commander";

33

import { describe, expect, it, vi } from "vitest";

4-

import { registerNodesCanvasCommands, type CanvasCliDependencies } from "./cli.js";

4+

import {

5+

createDefaultCanvasCliDependencies,

6+

registerNodesCanvasCommands,

7+

type CanvasCliDependencies,

8+

} from "./cli.js";

59610

function createCanvasCliDeps() {

711

const writtenFiles: Array<{ filePath: string; base64: string }> = [];

@@ -47,6 +51,26 @@ function createCanvasCliDeps() {

4751

return { deps, runtime, writtenFiles };

4852

}

495354+

function createCanvasCliDepsWithDefaultParsers() {

55+

const baseDeps = createDefaultCanvasCliDependencies();

56+

const harness = createCanvasCliDeps();

57+

return {

58+

...harness,

59+

deps: {

60+

...baseDeps,

61+

defaultRuntime: harness.runtime,

62+

nodesCallOpts: harness.deps.nodesCallOpts,

63+

runNodesCommand: harness.deps.runNodesCommand,

64+

getNodesTheme: harness.deps.getNodesTheme,

65+

resolveNodeId: harness.deps.resolveNodeId,

66+

buildNodeInvokeParams: harness.deps.buildNodeInvokeParams,

67+

callGatewayCli: harness.deps.callGatewayCli,

68+

writeBase64ToFile: harness.deps.writeBase64ToFile,

69+

shortenHomePath: harness.deps.shortenHomePath,

70+

},

71+

};

72+

}

73+5074

describe("canvas CLI", () => {

5175

it("registers under nodes and captures a snapshot media path", async () => {

5276

const program = new Command();

@@ -135,6 +159,8 @@ describe("canvas CLI", () => {

135159

it.each([

136160

["--max-width", "640px", "--max-width must be a positive integer."],

137161

["--quality", "0.8x", "--quality must be a number."],

162+

["--quality", "-0.1", "--quality must be between 0 and 1."],

163+

["--quality", "5", "--quality must be between 0 and 1."],

138164

])("rejects partial numeric snapshot %s values", async (flag, value, message) => {

139165

const program = new Command();

140166

program.exitOverride();

@@ -151,6 +177,62 @@ describe("canvas CLI", () => {

151177

expect(deps.callGatewayCli).not.toHaveBeenCalled();

152178

});

153179180+

it.each(["0", "1"])("accepts snapshot --quality boundary value %s", async (quality) => {

181+

const program = new Command();

182+

program.exitOverride();

183+

const nodes = program.command("nodes");

184+

const { deps } = createCanvasCliDeps();

185+186+

registerNodesCanvasCommands(nodes, deps);

187+188+

await program.parseAsync(

189+

["nodes", "canvas", "snapshot", "--node", "ios-node", "--quality", quality],

190+

{

191+

from: "user",

192+

},

193+

);

194+

expect(deps.callGatewayCli).toHaveBeenCalledWith(

195+

"node.invoke",

196+

expect.any(Object),

197+

expect.objectContaining({

198+

params: expect.objectContaining({

199+

quality: Number(quality),

200+

}),

201+

}),

202+

);

203+

});

204+205+

it.each([

206+

["snapshot"],

207+

["present"],

208+

["hide"],

209+

["navigate", "https://example.com"],

210+

["eval", "1 + 1"],

211+

["a2ui", "push", "--text", "hello"],

212+

["a2ui", "reset"],

213+

])("rejects invalid %s invoke timeouts before invoking the node", async (...args) => {

214+

const program = new Command();

215+

program.exitOverride();

216+

const nodes = program.command("nodes");

217+

const { deps } = createCanvasCliDepsWithDefaultParsers();

218+

deps.resolveNodeId = vi.fn(async () => {

219+

throw new Error("resolveNodeId should not be called");

220+

});

221+222+

registerNodesCanvasCommands(nodes, deps);

223+224+

await expect(

225+

program.parseAsync(

226+

["nodes", "canvas", ...args, "--node", "ios-node", "--invoke-timeout", "20ms"],

227+

{

228+

from: "user",

229+

},

230+

),

231+

).rejects.toThrow("--invoke-timeout must be a positive integer.");

232+

expect(deps.resolveNodeId).not.toHaveBeenCalled();

233+

expect(deps.callGatewayCli).not.toHaveBeenCalled();

234+

});

235+154236

it.each([

155237

["--x", "1x"],

156238

["--y", "2px"],