惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

月光博客
月光博客
雷峰网
雷峰网
S
SegmentFault 最新的问题
博客园 - 【当耐特】
博客园_首页
量子位
爱范儿
爱范儿
博客园 - 叶小钗
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
Jina AI
Jina AI
V
V2EX
美团技术团队
V
Visual Studio Blog
博客园 - 三生石上(FineUI控件)
IT之家
IT之家
Hugging Face - Blog
Hugging Face - Blog
Apple Machine Learning Research
Apple Machine Learning Research
小众软件
小众软件
博客园 - 聂微东
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
The Cloudflare Blog
宝玉的分享
宝玉的分享
WordPress大学
WordPress大学
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix: redact denied exec failure params (#85140) · opencla...
joshavant · 2026-05-22 · via Recent Commits to openclaw:main

@@ -110,6 +110,165 @@ describe("pi tool definition adapter logging", () => {

110110

);

111111

});

112112113+

it("omits raw exec commands and env values from failure logs", async () => {

114+

const commandSecret = "issue85049-xai-cleartext-token-ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";

115+

const envSecret = "issue85049-env-cleartext-token-ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";

116+

const baseTool = {

117+

name: "exec",

118+

label: "exec",

119+

description: "runs commands",

120+

parameters: Type.Object({

121+

command: Type.String(),

122+

env: Type.Optional(Type.Record(Type.String(), Type.String())),

123+

timeout: Type.Optional(Type.Number()),

124+

}),

125+

execute: async () => {

126+

throw new Error("exec denied: allowlist miss");

127+

},

128+

} satisfies AgentTool;

129+

const [def] = toToolDefinitions([baseTool]);

130+

if (!def) {

131+

throw new Error("missing tool definition");

132+

}

133+134+

await def.execute(

135+

"call-exec-denied",

136+

{

137+

command: `export XAI_API_KEY=\\"${commandSecret}\\" && echo blocked`,

138+

env: {

139+

OPENAI_API_KEY: envSecret,

140+

},

141+

timeout: 5,

142+

},

143+

undefined,

144+

undefined,

145+

extensionContext,

146+

);

147+148+

const message = String(firstLogErrorMessage());

149+

expect(message).toContain("[tools] exec failed: exec denied: allowlist miss");

150+

expect(message).toContain('"command":{"omitted":true');

151+

expect(message).toContain('"reason":"exec command may contain credentials"');

152+

expect(message).toContain('"chars":');

153+

expect(message).toMatch(/"sha256":"[a-f0-9]{16}"/u);

154+

expect(message).toContain('"env":{"OPENAI_API_KEY":"[omitted exec env value]"}');

155+

expect(message).toContain('"timeout":5');

156+

expect(message).not.toContain(commandSecret);

157+

expect(message).not.toContain(envSecret);

158+

expect(message).not.toContain("export XAI_API_KEY");

159+

});

160+161+

it("omits raw exec commands from JSON-string failure params", async () => {

162+

const commandSecret = "issue85049-json-cleartext-token-ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";

163+

const baseTool = {

164+

name: "exec",

165+

label: "exec",

166+

description: "runs commands",

167+

parameters: Type.Any(),

168+

execute: async () => {

169+

throw new Error("exec denied: allowlist miss");

170+

},

171+

} satisfies AgentTool;

172+

const [def] = toToolDefinitions([baseTool]);

173+

if (!def) {

174+

throw new Error("missing tool definition");

175+

}

176+177+

await def.execute(

178+

"call-exec-denied-json-string",

179+

JSON.stringify({

180+

command: `export XAI_API_KEY=\\"${commandSecret}\\" && echo blocked`,

181+

timeout: 5,

182+

}),

183+

undefined,

184+

undefined,

185+

extensionContext,

186+

);

187+188+

const message = String(firstLogErrorMessage());

189+

expect(message).toContain('"command":{"omitted":true');

190+

expect(message).toContain('"reason":"exec command may contain credentials"');

191+

expect(message).toContain('"timeout":5');

192+

expect(message).not.toContain(commandSecret);

193+

expect(message).not.toContain("export XAI_API_KEY");

194+

});

195+196+

it("omits malformed exec command and env values from failure logs", async () => {

197+

const commandSecret =

198+

"issue85049-malformed-command-cleartext-token-ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";

199+

const envSecret =

200+

"issue85049-malformed-env-cleartext-token-ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";

201+

const baseTool = {

202+

name: "exec",

203+

label: "exec",

204+

description: "runs commands",

205+

parameters: Type.Any(),

206+

execute: async () => {

207+

throw new Error("exec denied: allowlist miss");

208+

},

209+

} satisfies AgentTool;

210+

const [def] = toToolDefinitions([baseTool]);

211+

if (!def) {

212+

throw new Error("missing tool definition");

213+

}

214+215+

await def.execute(

216+

"call-exec-denied-malformed",

217+

{

218+

command: [`export XAI_API_KEY=\\"${commandSecret}\\" && echo blocked`],

219+

env: `OPENAI_API_KEY=${envSecret}`,

220+

},

221+

undefined,

222+

undefined,

223+

extensionContext,

224+

);

225+226+

const message = String(firstLogErrorMessage());

227+

expect(message).toContain('"command":{"omitted":true');

228+

expect(message).toContain('"type":"array"');

229+

expect(message).toContain('"env":"[omitted exec env]"');

230+

expect(message).not.toContain(commandSecret);

231+

expect(message).not.toContain(envSecret);

232+

expect(message).not.toContain("export XAI_API_KEY");

233+

});

234+235+

it("omits cmd-style exec payloads from normalized bash failure logs", async () => {

236+

const commandSecret =

237+

"issue85049-cmd-alias-cleartext-token-ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";

238+

const baseTool = {

239+

name: "bash",

240+

label: "Bash",

241+

description: "runs commands",

242+

parameters: Type.Any(),

243+

execute: async () => {

244+

throw new Error("exec denied: allowlist miss");

245+

},

246+

} satisfies AgentTool;

247+

const [def] = toToolDefinitions([baseTool]);

248+

if (!def) {

249+

throw new Error("missing tool definition");

250+

}

251+252+

await def.execute(

253+

"call-bash-denied-cmd-alias",

254+

{

255+

cmd: `export XAI_API_KEY=\\"${commandSecret}\\" && echo blocked`,

256+

timeout: 5,

257+

},

258+

undefined,

259+

undefined,

260+

extensionContext,

261+

);

262+263+

const message = String(firstLogErrorMessage());

264+

expect(message).toContain("[tools] exec failed: exec denied: allowlist miss");

265+

expect(message).toContain('"cmd":{"omitted":true');

266+

expect(message).toContain('"reason":"exec command may contain credentials"');

267+

expect(message).toContain('"timeout":5');

268+

expect(message).not.toContain(commandSecret);

269+

expect(message).not.toContain("export XAI_API_KEY");

270+

});

271+113272

it("logs provider AbortError failures when the agent run was not aborted", async () => {

114273

const baseTool = {

115274

name: "web_search",