惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Hugging Face - Blog
Hugging Face - Blog
Google DeepMind News
Google DeepMind News
云风的 BLOG
云风的 BLOG
WordPress大学
WordPress大学
Vercel News
Vercel News
Apple Machine Learning Research
Apple Machine Learning Research
T
Tailwind CSS Blog
I
InfoQ
小众软件
小众软件
Recent Announcements
Recent Announcements
博客园 - 【当耐特】
The GitHub Blog
The GitHub Blog
大猫的无限游戏
大猫的无限游戏
美团技术团队
T
The Blog of Author Tim Ferriss
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
酷 壳 – CoolShell
酷 壳 – CoolShell
MongoDB | Blog
MongoDB | Blog
V
V2EX
J
Java Code Geeks
有赞技术团队
有赞技术团队
博客园 - 聂微东
B
Blog RSS Feed
博客园 - 司徒正美

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(github-copilot): validate oauth expiry values · openc...
steipete · 2026-05-30 · via Recent Commits to openclaw:main

@@ -2,6 +2,10 @@

22

* GitHub Copilot OAuth flow

33

*/

445+

import {

6+

parseStrictNonNegativeInteger,

7+

parseStrictPositiveInteger,

8+

} from "../../../infra/parse-finite-number.js";

59

import type { Model } from "../../types.js";

610

import type { OAuthCredentials, OAuthLoginCallbacks, OAuthProviderInterface } from "./types.js";

711

@@ -28,8 +32,8 @@ type DeviceCodeResponse = {

2832

device_code: string;

2933

user_code: string;

3034

verification_uri: string;

31-

interval: number;

32-

expires_in: number;

35+

intervalMs: number;

36+

expiresAt: number;

3337

};

34383539

type DeviceTokenSuccessResponse = {

@@ -56,6 +60,42 @@ type CopilotRequestOptions = {

5660

timeoutMs?: number;

5761

};

586263+

function secondsToSafeMilliseconds(value: unknown): number | undefined {

64+

const seconds = parseStrictPositiveInteger(value);

65+

if (seconds === undefined) {

66+

return undefined;

67+

}

68+

const milliseconds = seconds * 1000;

69+

return Number.isSafeInteger(milliseconds) ? milliseconds : undefined;

70+

}

71+72+

function nonNegativeSecondsToSafeMilliseconds(value: unknown): number | undefined {

73+

const seconds = parseStrictNonNegativeInteger(value);

74+

if (seconds === undefined) {

75+

return undefined;

76+

}

77+

const milliseconds = seconds * 1000;

78+

return Number.isSafeInteger(milliseconds) ? milliseconds : undefined;

79+

}

80+81+

function resolveExpiresAtFromDurationSeconds(value: unknown): number | undefined {

82+

const durationMs = secondsToSafeMilliseconds(value);

83+

if (durationMs === undefined) {

84+

return undefined;

85+

}

86+

const expiresAt = Date.now() + durationMs;

87+

return Number.isSafeInteger(expiresAt) ? expiresAt : undefined;

88+

}

89+90+

function resolveExpiresAtFromEpochSeconds(value: unknown): number | undefined {

91+

const epochMs = secondsToSafeMilliseconds(value);

92+

if (epochMs === undefined) {

93+

return undefined;

94+

}

95+

const expiresAt = epochMs - 5 * 60 * 1000;

96+

return Number.isSafeInteger(expiresAt) ? expiresAt : undefined;

97+

}

98+5999

export function normalizeDomain(input: string): string | null {

60100

const trimmed = input.trim();

61101

if (!trimmed) {

@@ -203,14 +243,17 @@ async function startDeviceFlow(

203243

const userCode = (data as Record<string, unknown>).user_code;

204244

const verificationUri = (data as Record<string, unknown>).verification_uri;

205245

const interval = (data as Record<string, unknown>).interval;

206-

const expiresIn = (data as Record<string, unknown>).expires_in;

246+

const intervalMs = nonNegativeSecondsToSafeMilliseconds(interval);

247+

const expiresAt = resolveExpiresAtFromDurationSeconds(

248+

(data as Record<string, unknown>).expires_in,

249+

);

207250208251

if (

209252

typeof deviceCode !== "string" ||

210253

typeof userCode !== "string" ||

211254

typeof verificationUri !== "string" ||

212-

typeof interval !== "number" ||

213-

typeof expiresIn !== "number"

255+

intervalMs === undefined ||

256+

expiresAt === undefined

214257

) {

215258

throw new Error("Invalid device code response fields");

216259

}

@@ -219,8 +262,8 @@ async function startDeviceFlow(

219262

device_code: deviceCode,

220263

user_code: userCode,

221264

verification_uri: verificationUri,

222-

interval,

223-

expires_in: expiresIn,

265+

intervalMs,

266+

expiresAt,

224267

};

225268

}

226269

@@ -250,13 +293,12 @@ function abortableSleep(ms: number, signal?: AbortSignal): Promise<void> {

250293

async function pollForGitHubAccessToken(

251294

domain: string,

252295

deviceCode: string,

253-

intervalSeconds: number,

254-

expiresIn: number,

296+

intervalMs: number,

297+

deadline: number,

255298

signal?: AbortSignal,

256299

) {

257300

const urls = getUrls(domain);

258-

const deadline = Date.now() + expiresIn * 1000;

259-

let intervalMs = Math.max(1000, Math.floor(intervalSeconds * 1000));

301+

let pollingIntervalMs = Math.max(1000, intervalMs);

260302

let intervalMultiplier = INITIAL_POLL_INTERVAL_MULTIPLIER;

261303

let slowDownResponses = 0;

262304

@@ -266,7 +308,7 @@ async function pollForGitHubAccessToken(

266308

}

267309268310

const remainingMs = deadline - Date.now();

269-

const waitMs = Math.min(Math.ceil(intervalMs * intervalMultiplier), remainingMs);

311+

const waitMs = Math.min(Math.ceil(pollingIntervalMs * intervalMultiplier), remainingMs);

270312

await abortableSleep(waitMs, signal);

271313272314

const raw = await fetchJson(

@@ -308,10 +350,11 @@ async function pollForGitHubAccessToken(

308350309351

if (error === "slow_down") {

310352

slowDownResponses += 1;

311-

intervalMs =

312-

typeof interval === "number" && interval > 0

313-

? interval * 1000

314-

: Math.max(1000, intervalMs + 5000);

353+

const slowDownIntervalMs = secondsToSafeMilliseconds(interval);

354+

pollingIntervalMs =

355+

slowDownIntervalMs === undefined

356+

? Math.max(1000, pollingIntervalMs + 5000)

357+

: Math.max(1000, slowDownIntervalMs);

315358

intervalMultiplier = SLOW_DOWN_POLL_INTERVAL_MULTIPLIER;

316359

continue;

317360

}

@@ -359,16 +402,16 @@ export async function refreshGitHubCopilotToken(

359402

}

360403361404

const token = (raw as Record<string, unknown>).token;

362-

const expiresAt = (raw as Record<string, unknown>).expires_at;

405+

const expires = resolveExpiresAtFromEpochSeconds((raw as Record<string, unknown>).expires_at);

363406364-

if (typeof token !== "string" || typeof expiresAt !== "number") {

407+

if (typeof token !== "string" || expires === undefined) {

365408

throw new Error("Invalid Copilot token response fields");

366409

}

367410368411

return {

369412

refresh: refreshToken,

370413

access: token,

371-

expires: expiresAt * 1000 - 5 * 60 * 1000,

414+

expires,

372415

enterpriseUrl: enterpriseDomain,

373416

};

374417

}

@@ -514,8 +557,8 @@ export async function loginGitHubCopilot(options: {

514557

const githubAccessToken = await pollForGitHubAccessToken(

515558

domain,

516559

device.device_code,

517-

device.interval,

518-

device.expires_in,

560+

device.intervalMs,

561+

device.expiresAt,

519562

options.signal,

520563

);

521564

const credentials = await refreshGitHubCopilotToken(