惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Y
Y Combinator Blog
The GitHub Blog
The GitHub Blog
Vercel News
Vercel News
D
DataBreaches.Net
MongoDB | Blog
MongoDB | Blog
H
Help Net Security
小众软件
小众软件
美团技术团队
T
The Blog of Author Tim Ferriss
爱范儿
爱范儿
D
Docker
Martin Fowler
Martin Fowler
大猫的无限游戏
大猫的无限游戏
博客园 - 聂微东
Blog — PlanetScale
Blog — PlanetScale
H
Hackread – Cybersecurity News, Data Breaches, AI and More
罗磊的独立博客
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
V
V2EX
S
SegmentFault 最新的问题
云风的 BLOG
云风的 BLOG
B
Blog
雷峰网
雷峰网
The Cloudflare Blog

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(browser): manage isolated downloads · openclaw/opencl...
steipete · 2026-04-25 · via Recent Commits to openclaw:main

@@ -1,5 +1,8 @@

1+

import fs from "node:fs/promises";

2+

import path from "node:path";

13

import type { Page } from "playwright-core";

2-

import { describe, expect, it, vi } from "vitest";

4+

import { afterEach, describe, expect, it, vi } from "vitest";

5+

import { DEFAULT_DOWNLOAD_DIR } from "./paths.js";

36

import {

47

ensurePageState,

58

refLocator,

@@ -8,6 +11,16 @@ import {

811

} from "./pw-session.js";

912

import { BROWSER_REF_MARKER_ATTRIBUTE } from "./pw-session.page-cdp.js";

101314+

type MutableDownload = {

15+

suggestedFilename: () => string;

16+

saveAs: ReturnType<typeof vi.fn>;

17+

path?: () => Promise<string>;

18+

};

19+20+

afterEach(() => {

21+

vi.restoreAllMocks();

22+

});

23+1124

function fakePage(): {

1225

page: Page;

1326

handlers: Map<string, Array<(...args: unknown[]) => void>>;

@@ -123,6 +136,80 @@ describe("pw-session role refs cache", () => {

123136

});

124137125138

describe("pw-session ensurePageState", () => {

139+

it("stores unmanaged downloads under unique managed paths", async () => {

140+

const { page, handlers } = fakePage();

141+

const mkdirSpy = vi.spyOn(fs, "mkdir").mockResolvedValue(undefined);

142+

ensurePageState(page);

143+144+

const saveAsA = vi.fn(async () => {});

145+

const saveAsB = vi.fn(async () => {});

146+

const downloadA: MutableDownload = {

147+

suggestedFilename: () => "report.pdf",

148+

saveAs: saveAsA,

149+

};

150+

const downloadB: MutableDownload = {

151+

suggestedFilename: () => "report.pdf",

152+

saveAs: saveAsB,

153+

};

154+155+

handlers.get("download")?.[0]?.(downloadA);

156+

handlers.get("download")?.[0]?.(downloadB);

157+158+

const managedPathA = await downloadA.path?.();

159+

const managedPathB = await downloadB.path?.();

160+161+

expect(managedPathA).not.toBe(managedPathB);

162+

expect(path.dirname(managedPathA ?? "")).toBe(DEFAULT_DOWNLOAD_DIR);

163+

expect(path.dirname(managedPathB ?? "")).toBe(DEFAULT_DOWNLOAD_DIR);

164+

expect(path.basename(managedPathA ?? "")).toMatch(/-report\.pdf$/);

165+

expect(path.basename(managedPathB ?? "")).toMatch(/-report\.pdf$/);

166+

expect(saveAsA).toHaveBeenCalledWith(managedPathA);

167+

expect(saveAsB).toHaveBeenCalledWith(managedPathB);

168+

expect(mkdirSpy).toHaveBeenCalledWith(DEFAULT_DOWNLOAD_DIR, { recursive: true });

169+

});

170+171+

it("suppresses unmanaged download save rejections until path is awaited", async () => {

172+

const { page, handlers } = fakePage();

173+

vi.spyOn(fs, "mkdir").mockResolvedValue(undefined);

174+

ensurePageState(page);

175+

const unhandled: unknown[] = [];

176+

const onUnhandled = (reason: unknown) => unhandled.push(reason);

177+

process.on("unhandledRejection", onUnhandled);

178+179+

const err = new Error("save failed");

180+

const download: MutableDownload = {

181+

suggestedFilename: () => "report.pdf",

182+

saveAs: vi.fn(async () => {

183+

throw err;

184+

}),

185+

};

186+187+

try {

188+

handlers.get("download")?.[0]?.(download);

189+

await new Promise((resolve) => setImmediate(resolve));

190+191+

expect(unhandled).toEqual([]);

192+

await expect(download.path?.()).rejects.toThrow("save failed");

193+

} finally {

194+

process.off("unhandledRejection", onUnhandled);

195+

}

196+

});

197+198+

it("leaves unmanaged download handling to explicit waiters while armed", () => {

199+

const { page, handlers } = fakePage();

200+

const state = ensurePageState(page);

201+

state.downloadWaiterDepth = 1;

202+

const download = {

203+

suggestedFilename: () => "report.pdf",

204+

saveAs: vi.fn(async () => {}),

205+

};

206+207+

handlers.get("download")?.[0]?.(download);

208+209+

expect(download).not.toHaveProperty("path");

210+

expect(download.saveAs).not.toHaveBeenCalled();

211+

});

212+126213

it("tracks page errors and network requests (best-effort)", () => {

127214

const { page, handlers } = fakePage();

128215

const state = ensurePageState(page);