fix: validate feishu chat page size · openclaw/openclaw@d...

Recent Commits to openclaw:main

steipete · 2026-05-29 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+import { optionalPositiveIntegerSchema } from "openclaw/plugin-sdk/channel-actions";`
`1`	`2`	`import { Type, type Static } from "typebox";`
`2`	`3`
`3`	`4`	`const CHAT_ACTION_VALUES = ["members", "info", "member_info"] as const;`
`@@ -11,7 +12,10 @@ export const FeishuChatSchema = Type.Object({`
`11`	`12`	`}),`
`12`	`13`	`chat_id: Type.Optional(Type.String({ description: "Chat ID (from URL or event payload)" })),`
`13`	`14`	`member_id: Type.Optional(Type.String({ description: "Member ID for member_info lookups" })),`
`14`		`-page_size: Type.Optional(Type.Number({ description: "Page size (1-100, default 50)" })),`
	`15`	`+page_size: optionalPositiveIntegerSchema({`
	`16`	`+maximum: 100,`
	`17`	`+description: "Page size (1-100, default 50)",`
	`18`	`+}),`
`15`	`19`	`page_token: Type.Optional(Type.String({ description: "Pagination token" })),`
`16`	`20`	`member_id_type: Type.Optional(`
`17`	`21`	`Type.Unsafe<(typeof MEMBER_ID_TYPE_VALUES)[number]>({`

Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,60 @@ describe("registerFeishuChatTools", () => {`
`167`	`167`	`});`
`168`	`168`	`});`
`169`	`169`
	`170`	`+it("advertises and validates member page_size as a positive integer", async () => {`
	`171`	`+const registerTool = vi.fn();`
	`172`	`+registerFeishuChatTools(`
	`173`	`+createChatToolApi({`
	`174`	`+config: {`
	`175`	`+channels: {`
	`176`	`+feishu: {`
	`177`	`+enabled: true,`
	`178`	`+appId: "app_id",`
	`179`	`+appSecret: "app_secret", // pragma: allowlist secret`
	`180`	`+tools: { chat: true },`
	`181`	`+},`
	`182`	`+},`
	`183`	`+},`
	`184`	`+ registerTool,`
	`185`	`+}),`
	`186`	`+);`
	`187`	`+`
	`188`	`+const tool = registerTool.mock.calls[0]?.[0];`
	`189`	`+expect(tool?.parameters.properties.page_size).toMatchObject({`
	`190`	`+type: "integer",`
	`191`	`+minimum: 1,`
	`192`	`+maximum: 100,`
	`193`	`+});`
	`194`	`+`
	`195`	`+chatMembersGetMock.mockResolvedValueOnce({`
	`196`	`+code: 0,`
	`197`	`+data: { has_more: false, items: [] },`
	`198`	`+});`
	`199`	`+await tool.execute("tc_page_size_string", {`
	`200`	`+action: "members",`
	`201`	`+chat_id: "oc_1",`
	`202`	`+page_size: "25",`
	`203`	`+});`
	`204`	`+expect(chatMembersGetMock).toHaveBeenLastCalledWith({`
	`205`	`+path: { chat_id: "oc_1" },`
	`206`	`+params: {`
	`207`	`+page_size: 25,`
	`208`	`+page_token: undefined,`
	`209`	`+member_id_type: "open_id",`
	`210`	`+},`
	`211`	`+});`
	`212`	`+`
	`213`	`+const invalidResult = await tool.execute("tc_page_size_invalid", {`
	`214`	`+action: "members",`
	`215`	`+chat_id: "oc_1",`
	`216`	`+page_size: 0,`
	`217`	`+});`
	`218`	`+expect(invalidResult.details.error).toContain(`
	`219`	`+"page_size must be a positive integer between 1 and 100",`
	`220`	`+);`
	`221`	`+expect(chatMembersGetMock).toHaveBeenCalledTimes(1);`
	`222`	`+});`
	`223`	`+`
`170`	`224`	`it("skips registration when chat tool is disabled", () => {`
`171`	`225`	`const registerTool = vi.fn();`
`172`	`226`	`registerFeishuChatTools(`

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import type * as Lark from "@larksuiteoapi/node-sdk";`
	`2`	`+import { readPositiveIntegerParam } from "openclaw/plugin-sdk/param-readers";`
`2`	`3`	`import type { OpenClawPluginApi } from "../runtime-api.js";`
`3`	`4`	`import { listEnabledFeishuAccounts } from "./accounts.js";`
`4`	`5`	`import { FeishuChatSchema, type FeishuChatParams } from "./chat-schema.js";`
`@@ -13,6 +14,13 @@ function json(data: unknown) {`
`13`	`14`	`};`
`14`	`15`	`}`
`15`	`16`
	`17`	`+function readChatPageSize(params: Record<string, unknown>): number \| undefined {`
	`18`	`+return readPositiveIntegerParam(params, "page_size", {`
	`19`	`+max: 100,`
	`20`	`+message: "page_size must be a positive integer between 1 and 100",`
	`21`	`+});`
	`22`	`+}`
	`23`	`+`
`16`	`24`	`export async function getChatInfo(client: Lark.Client, chatId: string) {`
`17`	`25`	`const res = await client.im.chat.get({ path: { chat_id: chatId } });`
`18`	`26`	`if (res.code !== 0) {`
`@@ -146,6 +154,7 @@ export function registerFeishuChatTools(api: OpenClawPluginApi) {`
`146`	`154`	`description: "Feishu chat operations. Actions: members, info, member_info",`
`147`	`155`	`parameters: FeishuChatSchema,`
`148`	`156`	`async execute(_toolCallId, params) {`
	`157`	`+const rawParams = params as Record<string, unknown>;`
`149`	`158`	`const p = params as FeishuChatParams;`
`150`	`159`	`try {`
`151`	`160`	`const client = getClient();`
`@@ -158,7 +167,7 @@ export function registerFeishuChatTools(api: OpenClawPluginApi) {`
`158`	`167`	`await getChatMembers(`
`159`	`168`	`client,`
`160`	`169`	`p.chat_id,`
`161`		`-p.page_size,`
	`170`	`+readChatPageSize(rawParams),`
`162`	`171`	`p.page_token,`
`163`	`172`	`p.member_id_type,`
`164`	`173`	`),`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main