惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

量子位
WordPress大学
WordPress大学
小众软件
小众软件
云风的 BLOG
云风的 BLOG
IT之家
IT之家
人人都是产品经理
人人都是产品经理
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
Last Week in AI
Last Week in AI
博客园 - 【当耐特】
T
Tailwind CSS Blog
阮一峰的网络日志
阮一峰的网络日志
V
V2EX
宝玉的分享
宝玉的分享
博客园 - Franky
F
Fortinet All Blogs
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
GbyAI
GbyAI
Hugging Face - Blog
Hugging Face - Blog
Jina AI
Jina AI
D
Docker
博客园 - 聂微东
C
Check Point Blog
H
Help Net Security

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(slack): ignore no_reaction in remove helpers (#76320)...
clawsweeper · 2026-05-03 · via Recent Commits to openclaw:main

@@ -1,15 +1,29 @@

11

import type { WebClient } from "@slack/web-api";

22

import { describe, expect, it, vi } from "vitest";

3-

import { reactSlackMessage } from "./actions.js";

3+

import { reactSlackMessage, removeOwnSlackReactions, removeSlackReaction } from "./actions.js";

4455

function createClient() {

66

return {

7+

auth: {

8+

test: vi.fn(async () => ({ user_id: "UBOT" })),

9+

},

710

reactions: {

811

add: vi.fn(async () => ({})),

12+

get: vi.fn(async () => ({

13+

message: {

14+

reactions: [],

15+

},

16+

})),

17+

remove: vi.fn(async () => ({})),

918

},

1019

} as unknown as WebClient & {

20+

auth: {

21+

test: ReturnType<typeof vi.fn>;

22+

};

1123

reactions: {

1224

add: ReturnType<typeof vi.fn>;

25+

get: ReturnType<typeof vi.fn>;

26+

remove: ReturnType<typeof vi.fn>;

1327

};

1428

};

1529

}

@@ -58,3 +72,76 @@ describe("reactSlackMessage", () => {

5872

});

5973

});

6074

});

75+76+

describe("removeSlackReaction", () => {

77+

it("treats no_reaction as idempotent success", async () => {

78+

const client = createClient();

79+

client.reactions.remove.mockRejectedValueOnce(slackPlatformError("no_reaction"));

80+81+

await expect(

82+

removeSlackReaction("C1", "123.456", ":white_check_mark:", {

83+

client,

84+

token: "xoxb-test",

85+

}),

86+

).resolves.toBeUndefined();

87+88+

expect(client.reactions.remove).toHaveBeenCalledWith({

89+

channel: "C1",

90+

timestamp: "123.456",

91+

name: "white_check_mark",

92+

});

93+

});

94+95+

it("propagates unrelated reaction remove errors", async () => {

96+

const client = createClient();

97+

client.reactions.remove.mockRejectedValueOnce(slackPlatformError("invalid_name"));

98+99+

await expect(

100+

removeSlackReaction("C1", "123.456", "not-an-emoji", {

101+

client,

102+

token: "xoxb-test",

103+

}),

104+

).rejects.toMatchObject({

105+

data: {

106+

error: "invalid_name",

107+

},

108+

});

109+

});

110+

});

111+112+

describe("removeOwnSlackReactions", () => {

113+

it("removes own reactions through the idempotent remove helper", async () => {

114+

const client = createClient();

115+

client.reactions.get.mockResolvedValueOnce({

116+

message: {

117+

reactions: [

118+

{ name: "thumbsup", users: ["UBOT", "U1"] },

119+

{ name: "eyes", users: ["U2", "UBOT"] },

120+

{ name: "wave", users: ["U2"] },

121+

],

122+

},

123+

});

124+

client.reactions.remove

125+

.mockRejectedValueOnce(slackPlatformError("no_reaction"))

126+

.mockResolvedValueOnce({});

127+128+

await expect(

129+

removeOwnSlackReactions("C1", "123.456", {

130+

client,

131+

token: "xoxb-test",

132+

}),

133+

).resolves.toEqual(["thumbsup", "eyes"]);

134+135+

expect(client.reactions.remove).toHaveBeenCalledTimes(2);

136+

expect(client.reactions.remove).toHaveBeenNthCalledWith(1, {

137+

channel: "C1",

138+

timestamp: "123.456",

139+

name: "thumbsup",

140+

});

141+

expect(client.reactions.remove).toHaveBeenNthCalledWith(2, {

142+

channel: "C1",

143+

timestamp: "123.456",

144+

name: "eyes",

145+

});

146+

});

147+

});