fix(telegram): ignore unsafe cached message ids · openclaw/openclaw@656c238

Recent Commits to openclaw:main

steipete · 2026-05-29 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -405,6 +405,30 @@ describe("telegram message cache", () => {`
`405`	`405`	`expect(recent.map((entry) => entry.messageId)).toEqual(["9122", "9123", "9124"]);`
`406`	`406`	`});`
`407`	`407`
	`408`	`+it("does not use unsafe message ids as recent-before cutoffs", async () => {`
	`409`	`+const cache = createTelegramMessageCache();`
	`410`	`+await cache.record({`
	`411`	`+accountId: "default",`
	`412`	`+chatId: 7,`
	`413`	`+msg: {`
	`414`	`+chat: { id: 7, type: "private", first_name: "Nora" },`
	`415`	`+message_id: 9124,`
	`416`	`+date: 1736380700,`
	`417`	`+text: "State message",`
	`418`	`+from: { id: 1, is_bot: false, first_name: "Nora" },`
	`419`	`+} as Message,`
	`420`	`+});`
	`421`	`+`
	`422`	`+const recent = await cache.recentBefore({`
	`423`	`+accountId: "default",`
	`424`	`+chatId: 7,`
	`425`	`+messageId: "9007199254740992",`
	`426`	`+limit: 10,`
	`427`	`+});`
	`428`	`+`
	`429`	`+expect(recent).toEqual([]);`
	`430`	`+});`
	`431`	`+`
`408`	`432`	`it("reads legacy sidecar records as a persistent-store fallback", async () => {`
`409`	`433`	const storePath = `/tmp/openclaw-telegram-message-cache-state-migrate-${process.pid}-${Date.now()}.json`;
`410`	`434`	`const persistedPath = resolveTelegramMessageCachePath(storePath);`

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ import { createHash } from "node:crypto";`
`2`	`2`	`import fs from "node:fs";`
`3`	`3`	`import type { Message } from "grammy/types";`
`4`	`4`	`import { formatLocationText } from "openclaw/plugin-sdk/channel-inbound";`
	`5`	`+import { parseStrictPositiveInteger } from "openclaw/plugin-sdk/number-runtime";`
`5`	`6`	`import type { MsgContext } from "openclaw/plugin-sdk/reply-runtime";`
`6`	`7`	`import { logVerbose } from "openclaw/plugin-sdk/runtime-env";`
`7`	`8`	`import { appendRegularFileSync, replaceFileAtomicSync } from "openclaw/plugin-sdk/security-runtime";`
`@@ -240,6 +241,10 @@ function readOptionalString(record: Record<string, unknown>, key: string): strin`
`240`	`241`	`return isString(value) ? value : undefined;`
`241`	`242`	`}`
`242`	`243`
	`244`	`+function parseSafeMessageId(value: string \| undefined): number \| undefined {`
	`245`	`+return value === undefined ? undefined : parseStrictPositiveInteger(value);`
	`246`	`+}`
	`247`	`+`
`243`	`248`	`function isTelegramSourceMessage(value: unknown): value is Message {`
`244`	`249`	`return (`
`245`	`250`	`isRecord(value) &&`
`@@ -788,14 +793,14 @@ export function createTelegramMessageCache(params?: {`
`788`	`793`	`if (!messageId \|\| limit <= 0) {`
`789`	`794`	`return [];`
`790`	`795`	`}`
`791`		`-const targetId = Number(messageId);`
`792`		`-if (!Number.isFinite(targetId)) {`
	`796`	`+const targetId = parseSafeMessageId(messageId);`
	`797`	`+if (targetId === undefined) {`
`793`	`798`	`return [];`
`794`	`799`	`}`
`795`	`800`	`return (await listChatMessages({ accountId, chatId, threadId }))`
`796`	`801`	`.filter((entry) => {`
`797`		`-const entryId = Number(entry.messageId);`
`798`		`-return Number.isFinite(entryId) && entryId < targetId;`
	`802`	`+const entryId = parseSafeMessageId(entry.messageId);`
	`803`	`+return entryId !== undefined && entryId < targetId;`
`799`	`804`	`})`
`800`	`805`	`.slice(-limit);`
`801`	`806`	`},`
`@@ -820,9 +825,9 @@ function compareCachedMessageNodes(`
`820`	`825`	`left: TelegramCachedMessageNode,`
`821`	`826`	`right: TelegramCachedMessageNode,`
`822`	`827`	`) {`
`823`		`-const leftId = Number(left.messageId);`
`824`		`-const rightId = Number(right.messageId);`
`825`		`-if (Number.isFinite(leftId) && Number.isFinite(rightId)) {`
	`828`	`+const leftId = parseSafeMessageId(left.messageId);`
	`829`	`+const rightId = parseSafeMessageId(right.messageId);`
	`830`	`+if (leftId !== undefined && rightId !== undefined) {`
`826`	`831`	`return leftId - rightId;`
`827`	`832`	`}`
`828`	`833`	`return (left.messageId ?? "").localeCompare(right.messageId ?? "");`
`@@ -845,9 +850,9 @@ function isAfterSessionBoundary(`
`845`	`850`	`if (!boundary) {`
`846`	`851`	`return true;`
`847`	`852`	`}`
`848`		`-const nodeId = Number(node.messageId);`
`849`		`-const boundaryId = Number(boundary.messageId);`
`850`		`-if (Number.isFinite(nodeId) && Number.isFinite(boundaryId)) {`
	`853`	`+const nodeId = parseSafeMessageId(node.messageId);`
	`854`	`+const boundaryId = parseSafeMessageId(boundary.messageId);`
	`855`	`+if (nodeId !== undefined && boundaryId !== undefined) {`
`851`	`856`	`return nodeId > boundaryId;`
`852`	`857`	`}`
`853`	`858`	`if (`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main