fix: reject blank cron payloads · openclaw/openclaw@45b5f87

Recent Commits to openclaw:main

steipete · 2026-06-01 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -195,6 +195,42 @@ describe("normalizeCronJobCreate", () => {`
`195`	`195`	`expectAnnounceDeliveryTarget(delivery, { channel: "telegram", to: "7200373102" });`
`196`	`196`	`});`
`197`	`197`
	`198`	`+it("normalizes whitespace-only payload text to empty strings so validation rejects it", () => {`
	`199`	`+const agentTurn = normalizeCronJobCreate({`
	`200`	`+name: "blank agent turn",`
	`201`	`+enabled: true,`
	`202`	`+schedule: { kind: "every", everyMs: 60_000 },`
	`203`	`+sessionTarget: "isolated",`
	`204`	`+wakeMode: "now",`
	`205`	`+payload: {`
	`206`	`+kind: "agentTurn",`
	`207`	`+message: " ",`
	`208`	`+},`
	`209`	`+}) as unknown as Record<string, unknown>;`
	`210`	`+expect(agentTurn.payload).toEqual({ kind: "agentTurn", message: "" });`
	`211`	`+expect(validateCronAddParams(agentTurn)).toBe(false);`
	`212`	`+`
	`213`	`+const systemEvent = normalizeCronJobCreate({`
	`214`	`+name: "blank system event",`
	`215`	`+enabled: true,`
	`216`	`+schedule: { kind: "every", everyMs: 60_000 },`
	`217`	`+sessionTarget: "main",`
	`218`	`+wakeMode: "now",`
	`219`	`+payload: {`
	`220`	`+kind: "systemEvent",`
	`221`	`+text: " ",`
	`222`	`+},`
	`223`	`+}) as unknown as Record<string, unknown>;`
	`224`	`+expect(systemEvent.payload).toEqual({ kind: "systemEvent", text: "" });`
	`225`	`+expect(validateCronAddParams(systemEvent)).toBe(false);`
	`226`	`+`
	`227`	`+const update = normalizeCronJobPatch({`
	`228`	`+payload: { kind: "agentTurn", message: " " },`
	`229`	`+}) as unknown as Record<string, unknown>;`
	`230`	`+expect(update.payload).toEqual({ kind: "agentTurn", message: "" });`
	`231`	`+expect(validateCronUpdateParams({ id: "job-1", patch: update })).toBe(false);`
	`232`	`+});`
	`233`	`+`
`198`	`234`	`it("normalizes delivery accountId and strips blanks", () => {`
`199`	`235`	`const normalized = normalizeIsolatedAgentTurnCreateJob({`
`200`	`236`	`name: "delivery account",`

Original file line number	Diff line number	Diff line change
`@@ -128,12 +128,16 @@ function coercePayload(payload: UnknownRecord) {`
`128`	`128`	`const trimmed = normalizeOptionalString(next.message) ?? "";`
`129`	`129`	`if (trimmed) {`
`130`	`130`	`next.message = trimmed;`
	`131`	`+} else {`
	`132`	`+next.message = "";`
`131`	`133`	`}`
`132`	`134`	`}`
`133`	`135`	`if (typeof next.text === "string") {`
`134`	`136`	`const trimmed = normalizeOptionalString(next.text) ?? "";`
`135`	`137`	`if (trimmed) {`
`136`	`138`	`next.text = trimmed;`
	`139`	`+} else {`
	`140`	`+next.text = "";`
`137`	`141`	`}`
`138`	`142`	`}`
`139`	`143`	`if ("model" in next) {`

Original file line number	Diff line number	Diff line change
`@@ -404,6 +404,28 @@ describe("cron method validation", () => {`
`404`	`404`	`expectResponseError(respond, { code: "INVALID_REQUEST" });`
`405`	`405`	`});`
`406`	`406`
	`407`	`+it("rejects whitespace-only cron payloads before calling add", async () => {`
	`408`	`+const agentTurn = await invokeCronAdd(`
	`409`	`+agentTurnCronParams({`
	`410`	`+name: "blank agent turn",`
	`411`	`+payload: { kind: "agentTurn", message: " " },`
	`412`	`+}),`
	`413`	`+);`
	`414`	`+expect(agentTurn.context.cron.add).not.toHaveBeenCalled();`
	`415`	`+expectResponseError(agentTurn.respond, { code: "INVALID_REQUEST", messageIncludes: "message" });`
	`416`	`+`
	`417`	`+const systemEvent = await invokeCronAdd({`
	`418`	`+name: "blank system event",`
	`419`	`+enabled: true,`
	`420`	`+schedule: { kind: "every", everyMs: 60_000 },`
	`421`	`+sessionTarget: "main",`
	`422`	`+wakeMode: "next-heartbeat",`
	`423`	`+payload: { kind: "systemEvent", text: " " },`
	`424`	`+});`
	`425`	`+expect(systemEvent.context.cron.add).not.toHaveBeenCalled();`
	`426`	`+expectResponseError(systemEvent.respond, { code: "INVALID_REQUEST", messageIncludes: "text" });`
	`427`	`+});`
	`428`	`+`
`407`	`429`	`it("rejects ambiguous announce delivery on add when multiple channels are configured", async () => {`
`408`	`430`	`setRuntimeConfig(telegramSlackConfig({ includeMainSession: true }));`
`409`	`431`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main