fix: reject invalid browser tab indexes · openclaw/openclaw@afb56ea

Recent Commits to openclaw:main

steipete · 2026-05-29 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -261,6 +261,30 @@ describe("browser manage output", () => {`
`261`	`261`	`expect(output).not.toContain("supersecrettokenvalue1234567890");`
`262`	`262`	`});`
`263`	`263`
	`264`	`+it("rejects non-integer tab indexes without calling browser actions", async () => {`
	`265`	`+const program = createBrowserManageProgram();`
	`266`	`+`
	`267`	`+await expect(`
	`268`	`+program.parseAsync(["browser", "tab", "select", "1.9"], { from: "user" }),`
	`269`	`+).rejects.toThrow("__exit__:1");`
	`270`	`+expect(getBrowserCliRuntimeCapture().runtimeErrors.at(-1)).toContain(`
	`271`	`+"index must be a positive integer",`
	`272`	`+);`
	`273`	`+`
	`274`	`+getBrowserCliRuntimeCapture().resetRuntimeCapture();`
	`275`	`+await expect(`
	`276`	`+program.parseAsync(["browser", "tab", "close", "abc"], { from: "user" }),`
	`277`	`+).rejects.toThrow("__exit__:1");`
	`278`	`+expect(getBrowserCliRuntimeCapture().runtimeErrors.at(-1)).toContain(`
	`279`	`+"index must be a positive integer",`
	`280`	`+);`
	`281`	`+expect(getBrowserManageCallBrowserRequestMock()).not.toHaveBeenCalledWith(`
	`282`	`+expect.anything(),`
	`283`	`+expect.objectContaining({ path: "/tabs/action" }),`
	`284`	`+expect.anything(),`
	`285`	`+);`
	`286`	`+});`
	`287`	`+`
`264`	`288`	`it("prints a readable browser doctor report", async () => {`
`265`	`289`	`getBrowserManageCallBrowserRequestMock().mockImplementation(async (_opts: unknown, req) => {`
`266`	`290`	`if (req.path === "/") {`

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,11 @@ function runBrowserCommand(action: () => Promise<void>) {`
`112`	`112`	`});`
`113`	`113`	`}`
`114`	`114`
	`115`	`+function parseTabIndex(value: string): number {`
	`116`	`+const trimmed = value.trim();`
	`117`	`+return /^\d+$/.test(trimmed) ? Number(trimmed) : Number.NaN;`
	`118`	`+}`
	`119`	`+`
`115`	`120`	`function logBrowserTabs(tabs: BrowserTab[], json?: boolean) {`
`116`	`121`	`if (json) {`
`117`	`122`	`defaultRuntime.writeJson({ tabs });`
`@@ -490,41 +495,40 @@ export function registerBrowserManageCommands(`
`490`	`495`	`tab`
`491`	`496`	`.command("select")`
`492`	`497`	`.description("Focus tab by index (1-based)")`
`493`		`-.argument("<index>", "Tab index (1-based)", (v: string) => Number(v))`
	`498`	`+.argument("<index>", "Tab index (1-based)", parseTabIndex)`
`494`	`499`	`.action(async (index: number, _opts, cmd) => {`
`495`	`500`	`const parent = parentOpts(cmd);`
`496`	`501`	`const profile = parent?.browserProfile;`
`497`		`-if (!Number.isFinite(index) \|\| index < 1) {`
`498`		`-defaultRuntime.error(danger("index must be a positive number"));`
	`502`	`+if (!Number.isSafeInteger(index) \|\| index < 1) {`
	`503`	`+defaultRuntime.error(danger("index must be a positive integer"));`
`499`	`504`	`defaultRuntime.exit(1);`
`500`	`505`	`return;`
`501`	`506`	`}`
`502`	`507`	`await runBrowserCommand(async () => {`
`503`	`508`	`const result = await callTabAction(parent, profile, {`
`504`	`509`	`action: "select",`
`505`		`-index: Math.floor(index) - 1,`
	`510`	`+index: index - 1,`
`506`	`511`	`});`
`507`	`512`	`if (printJsonResult(parent, result)) {`
`508`	`513`	`return;`
`509`	`514`	`}`
`510`		-defaultRuntime.log(`selected tab ${Math.floor(index)}`);
	`515`	+defaultRuntime.log(`selected tab ${index}`);
`511`	`516`	`});`
`512`	`517`	`});`
`513`	`518`
`514`	`519`	`tab`
`515`	`520`	`.command("close")`
`516`	`521`	`.description("Close tab by index (1-based); default: first tab")`
`517`		`-.argument("[index]", "Tab index (1-based)", (v: string) => Number(v))`
	`522`	`+.argument("[index]", "Tab index (1-based)", parseTabIndex)`
`518`	`523`	`.action(async (index: number \| undefined, _opts, cmd) => {`
`519`	`524`	`const parent = parentOpts(cmd);`
`520`	`525`	`const profile = parent?.browserProfile;`
`521`		`-const idx =`
`522`		`-typeof index === "number" && Number.isFinite(index) ? Math.floor(index) - 1 : undefined;`
`523`		`-if (typeof idx === "number" && idx < 0) {`
`524`		`-defaultRuntime.error(danger("index must be >= 1"));`
	`526`	`+if (typeof index === "number" && (!Number.isSafeInteger(index) \|\| index < 1)) {`
	`527`	`+defaultRuntime.error(danger("index must be a positive integer"));`
`525`	`528`	`defaultRuntime.exit(1);`
`526`	`529`	`return;`
`527`	`530`	`}`
	`531`	`+const idx = typeof index === "number" ? index - 1 : undefined;`
`528`	`532`	`await runBrowserCommand(async () => {`
`529`	`533`	`const result = await callTabAction(parent, profile, { action: "close", index: idx });`
`530`	`534`	`if (printJsonResult(parent, result)) {`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main