fix: address code review findings · openclaw/openclaw@b3ef14d

Recent Commits to openclaw:main

jimdawdy-hub · 2026-05-13 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -2355,6 +2355,7 @@ export async function runEmbeddedPiAgent(`
`2355`	`2355`	`failoverFailure,`
`2356`	`2356`	`failoverReason: assistantFailoverReason,`
`2357`	`2357`	`timedOut,`
	`2358`	`+ idleTimedOut,`
`2358`	`2359`	`timedOutDuringCompaction,`
`2359`	`2360`	`timedOutDuringToolExecution,`
`2360`	`2361`	`profileRotated: false,`

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,8 @@ export async function handleAssistantFailover(params: {`
`98`	`98`
`99`	`99`	`if (decision.action === "rotate_profile") {`
`100`	`100`	`const failedProfileId = params.lastProfileId;`
`101`		`-const failureReason = params.timedOut ? "timeout" : params.assistantProfileFailureReason;`
	`101`	`+const failureReason =`
	`102`	`+params.timedOut \|\| params.idleTimedOut ? "timeout" : params.assistantProfileFailureReason;`
`102`	`103`	`const markFailedProfile = async () => {`
`103`	`104`	`if (!failedProfileId \|\| !failureReason \|\| failureReason === "timeout") {`
`104`	`105`	`return;`
`@@ -157,6 +158,9 @@ export async function handleAssistantFailover(params: {`
`157`	`158`	`if (params.timedOut && !params.isProbeSession && failedProfileId) {`
`158`	`159`	params.warn(`Profile ${failedProfileId} timed out. Trying next account...`);
`159`	`160`	`}`
	`161`	`+if (params.idleTimedOut && !params.isProbeSession && failedProfileId) {`
	`162`	+params.warn(`Profile ${failedProfileId} idle timeout (model silent). Trying next account...`);
	`163`	`+}`
`160`	`164`	`if (params.cloudCodeAssistFormatError && failedProfileId) {`
`161`	`165`	`params.warn(`
`162`	`166`	`Profile ${failedProfileId} hit Cloud Code Assist format error. Tool calls will be sanitized on retry.`,
`@@ -280,6 +284,7 @@ function resolveAssistantFailoverErrorMessage(params: {`
`280`	`284`	`sessionKey?: string;`
`281`	`285`	`activeErrorContext: { provider: string; model: string };`
`282`	`286`	`timedOut: boolean;`
	`287`	`+idleTimedOut: boolean;`
`283`	`288`	`rateLimitFailure: boolean;`
`284`	`289`	`billingFailure: boolean;`
`285`	`290`	`authFailure: boolean;`
`@@ -294,7 +299,7 @@ function resolveAssistantFailoverErrorMessage(params: {`
`294`	`299`	`})`
`295`	`300`	`: undefined) \|\|`
`296`	`301`	`params.lastAssistant?.errorMessage?.trim() \|\|`
`297`		`-(params.timedOut`
	`302`	`+(params.timedOut \|\| params.idleTimedOut`
`298`	`303`	`? "LLM request timed out."`
`299`	`304`	`: params.rateLimitFailure`
`300`	`305`	`? "LLM request rate limited."`

Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,7 @@ describe("resolveRunFailoverDecision", () => {`
`127`	`127`	`failoverFailure: true,`
`128`	`128`	`failoverReason: "format",`
`129`	`129`	`timedOut: false,`
	`130`	`+idleTimedOut: false,`
`130`	`131`	`timedOutDuringCompaction: false,`
`131`	`132`	`timedOutDuringToolExecution: false,`
`132`	`133`	`profileRotated: false,`
`@@ -148,6 +149,7 @@ describe("resolveRunFailoverDecision", () => {`
`148`	`149`	`failoverFailure: true,`
`149`	`150`	`failoverReason: "format",`
`150`	`151`	`timedOut: false,`
	`152`	`+idleTimedOut: false,`
`151`	`153`	`timedOutDuringCompaction: false,`
`152`	`154`	`timedOutDuringToolExecution: false,`
`153`	`155`	`profileRotated: false,`
`@@ -297,7 +299,6 @@ describe("resolveRunFailoverDecision", () => {`
`297`	`299`	`reason: null,`
`298`	`300`	`});`
`299`	`301`	`});`
`300`		`-});`
`301`	`302`
`302`	`303`	`it("rotates profile on LLM idle timeout before falling back", () => {`
`303`	`304`	`// idleTimedOut = model produced no tokens; no provider API error was classified.`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main