fix: track message attachment aliases · openclaw/openclaw...

Recent Commits to openclaw:main

steipete · 2026-05-15 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -320,6 +320,45 @@ describe("createCodexDynamicToolBridge", () => {`
`320`	`320`	`]);`
`321`	`321`	`});`
`322`	`322`
	`323`	`+it("records message tool media attachment aliases as delivery evidence", async () => {`
	`324`	`+const toolResult = {`
	`325`	`+content: [{ type: "text", text: "Sent." }],`
	`326`	`+details: { messageId: "message-1" },`
	`327`	`+} satisfies AgentToolResult<unknown>;`
	`328`	`+const tool = createTool({`
	`329`	`+name: "message",`
	`330`	`+execute: vi.fn(async () => toolResult),`
	`331`	`+});`
	`332`	`+const bridge = createCodexDynamicToolBridge({`
	`333`	`+tools: [tool],`
	`334`	`+signal: new AbortController().signal,`
	`335`	`+});`
	`336`	`+`
	`337`	`+const result = await handleMessageToolCall(bridge, {`
	`338`	`+action: "send",`
	`339`	`+text: "song attached",`
	`340`	`+media: "/tmp/generated-song.mp3",`
	`341`	`+attachments: [{ filePath: "/tmp/generated-cover.png" }],`
	`342`	`+});`
	`343`	`+`
	`344`	`+expect(result).toEqual(expectInputText("Sent."));`
	`345`	`+expect(bridge.telemetry.didSendViaMessagingTool).toBe(true);`
	`346`	`+expect(bridge.telemetry.messagingToolSentMediaUrls).toEqual([`
	`347`	`+"/tmp/generated-song.mp3",`
	`348`	`+"/tmp/generated-cover.png",`
	`349`	`+]);`
	`350`	`+expect(bridge.telemetry.messagingToolSentTargets).toEqual([`
	`351`	`+{`
	`352`	`+tool: "message",`
	`353`	`+provider: "message",`
	`354`	`+to: undefined,`
	`355`	`+threadId: undefined,`
	`356`	`+text: "song attached",`
	`357`	`+mediaUrls: ["/tmp/generated-song.mp3", "/tmp/generated-cover.png"],`
	`358`	`+},`
	`359`	`+]);`
	`360`	`+});`
	`361`	`+`
`323`	`362`	`it("records internal UI source replies separately from outbound messaging evidence", async () => {`
`324`	`363`	`const toolResult = textToolResult("Sent to current chat.", {`
`325`	`364`	`status: "ok",`

Original file line number	Diff line number	Diff line change
`@@ -417,21 +417,46 @@ function readFirstString(record: Record<string, unknown>, keys: string[]): strin`
`417`	`417`
`418`	`418`	`function collectMediaUrls(record: Record<string, unknown>): string[] {`
`419`	`419`	`const urls: string[] = [];`
`420`		`-for (const key of ["mediaUrl", "media_url", "imageUrl", "image_url"]) {`
`421`		`-const value = record[key];`
	`420`	`+const pushMediaUrl = (value: unknown) => {`
`422`	`421`	`if (typeof value === "string" && value.trim()) {`
`423`	`422`	`urls.push(value.trim());`
`424`	`423`	`}`
	`424`	`+};`
	`425`	`+const pushAttachment = (value: unknown) => {`
	`426`	`+if (!value \|\| typeof value !== "object" \|\| Array.isArray(value)) {`
	`427`	`+return;`
	`428`	`+}`
	`429`	`+const attachment = value as Record<string, unknown>;`
	`430`	`+for (const key of ["media", "mediaUrl", "path", "filePath", "fileUrl"]) {`
	`431`	`+pushMediaUrl(attachment[key]);`
	`432`	`+}`
	`433`	`+};`
	`434`	`+for (const key of [`
	`435`	`+"media",`
	`436`	`+"mediaUrl",`
	`437`	`+"media_url",`
	`438`	`+"path",`
	`439`	`+"filePath",`
	`440`	`+"fileUrl",`
	`441`	`+"imageUrl",`
	`442`	`+"image_url",`
	`443`	`+]) {`
	`444`	`+const value = record[key];`
	`445`	`+pushMediaUrl(value);`
`425`	`446`	`}`
`426`	`447`	`for (const key of ["mediaUrls", "media_urls", "imageUrls", "image_urls"]) {`
`427`	`448`	`const value = record[key];`
`428`	`449`	`if (!Array.isArray(value)) {`
`429`	`450`	`continue;`
`430`	`451`	`}`
`431`	`452`	`for (const entry of value) {`
`432`		`-if (typeof entry === "string" && entry.trim()) {`
`433`		`-urls.push(entry.trim());`
`434`		`-}`
	`453`	`+pushMediaUrl(entry);`
	`454`	`+}`
	`455`	`+}`
	`456`	`+const attachments = record.attachments;`
	`457`	`+if (Array.isArray(attachments)) {`
	`458`	`+for (const attachment of attachments) {`
	`459`	`+pushAttachment(attachment);`
`435`	`460`	`}`
`436`	`461`	`}`
`437`	`462`	`return urls;`

Original file line number	Diff line number	Diff line change
`@@ -1187,6 +1187,43 @@ describe("messaging tool media URL tracking", () => {`
`1187`	`1187`	`expect(ctx.state.pendingMessagingMediaUrls.has("tool-upload-file")).toBe(false);`
`1188`	`1188`	`});`
`1189`	`1189`
	`1190`	`+it("commits message attachment aliases as delivery evidence", async () => {`
	`1191`	`+const { ctx } = createTestContext();`
	`1192`	`+`
	`1193`	`+const startEvt: ToolExecutionStartEvent = {`
	`1194`	`+type: "tool_execution_start",`
	`1195`	`+toolName: "message",`
	`1196`	`+toolCallId: "tool-attachment-aliases",`
	`1197`	`+args: {`
	`1198`	`+action: "send",`
	`1199`	`+to: "channel:123",`
	`1200`	`+content: "track ready",`
	`1201`	`+media: "/tmp/generated-song.mp3",`
	`1202`	`+attachments: [{ filePath: "/tmp/generated-cover.png" }],`
	`1203`	`+},`
	`1204`	`+};`
	`1205`	`+await handleToolExecutionStart(ctx, startEvt);`
	`1206`	`+`
	`1207`	`+const endEvt: ToolExecutionEndEvent = {`
	`1208`	`+type: "tool_execution_end",`
	`1209`	`+toolName: "message",`
	`1210`	`+toolCallId: "tool-attachment-aliases",`
	`1211`	`+isError: false,`
	`1212`	`+result: { ok: true },`
	`1213`	`+};`
	`1214`	`+await handleToolExecutionEnd(ctx, endEvt);`
	`1215`	`+`
	`1216`	`+expect(ctx.state.messagingToolSentMediaUrls).toEqual([`
	`1217`	`+"/tmp/generated-song.mp3",`
	`1218`	`+"/tmp/generated-cover.png",`
	`1219`	`+]);`
	`1220`	`+expectRecordFields(requireSingleMessagingTarget(ctx), "messaging target", {`
	`1221`	`+to: "channel:123",`
	`1222`	`+text: "track ready",`
	`1223`	`+mediaUrls: ["/tmp/generated-song.mp3", "/tmp/generated-cover.png"],`
	`1224`	`+});`
	`1225`	`+});`
	`1226`	`+`
`1190`	`1227`	`it("commits sendAttachment args as message delivery evidence", async () => {`
`1191`	`1228`	`const { ctx } = createTestContext();`
`1192`	`1229`

Original file line number	Diff line number	Diff line change
`@@ -341,18 +341,36 @@ function pushUniqueMediaUrl(urls: string[], seen: Set<string>, value: unknown):`
`341`	`341`	`function collectMessagingMediaUrlsFromRecord(record: Record<string, unknown>): string[] {`
`342`	`342`	`const urls: string[] = [];`
`343`	`343`	`const seen = new Set<string>();`
	`344`	`+const pushAttachment = (value: unknown) => {`
	`345`	`+if (!value \|\| typeof value !== "object" \|\| Array.isArray(value)) {`
	`346`	`+return;`
	`347`	`+}`
	`348`	`+const attachment = value as Record<string, unknown>;`
	`349`	`+pushUniqueMediaUrl(urls, seen, attachment.media);`
	`350`	`+pushUniqueMediaUrl(urls, seen, attachment.mediaUrl);`
	`351`	`+pushUniqueMediaUrl(urls, seen, attachment.path);`
	`352`	`+pushUniqueMediaUrl(urls, seen, attachment.filePath);`
	`353`	`+pushUniqueMediaUrl(urls, seen, attachment.fileUrl);`
	`354`	`+};`
`344`	`355`
`345`	`356`	`pushUniqueMediaUrl(urls, seen, record.media);`
`346`	`357`	`pushUniqueMediaUrl(urls, seen, record.mediaUrl);`
`347`	`358`	`pushUniqueMediaUrl(urls, seen, record.path);`
`348`	`359`	`pushUniqueMediaUrl(urls, seen, record.filePath);`
	`360`	`+pushUniqueMediaUrl(urls, seen, record.fileUrl);`
`349`	`361`
`350`	`362`	`const mediaUrls = record.mediaUrls;`
`351`	`363`	`if (Array.isArray(mediaUrls)) {`
`352`	`364`	`for (const mediaUrl of mediaUrls) {`
`353`	`365`	`pushUniqueMediaUrl(urls, seen, mediaUrl);`
`354`	`366`	`}`
`355`	`367`	`}`
	`368`	`+const attachments = record.attachments;`
	`369`	`+if (Array.isArray(attachments)) {`
	`370`	`+for (const attachment of attachments) {`
	`371`	`+pushAttachment(attachment);`
	`372`	`+}`
	`373`	`+}`
`356`	`374`
`357`	`375`	`return urls;`
`358`	`376`	`}`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main