惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

L
LangChain Blog
博客园_首页
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
月光博客
月光博客
S
SegmentFault 最新的问题
量子位
Apple Machine Learning Research
Apple Machine Learning Research
博客园 - 司徒正美
博客园 - Franky
Google DeepMind News
Google DeepMind News
Recent Announcements
Recent Announcements
B
Blog RSS Feed
C
Check Point Blog
The Cloudflare Blog
M
MIT News - Artificial intelligence
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
F
Fortinet All Blogs
Hugging Face - Blog
Hugging Face - Blog
博客园 - 叶小钗
V
Visual Studio Blog
V
V2EX
Microsoft Azure Blog
Microsoft Azure Blog
博客园 - 聂微东
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(mattermost): wrap malformed interaction json · opencl...
vincentkoc · 2026-05-14 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -64,6 +64,7 @@ Docs: https://docs.openclaw.ai

6464

- QQBot: report malformed access-token JSON with provider-owned errors instead of leaking raw parser failures.

6565

- OpenAI embeddings: report malformed batch output JSONL with provider-owned errors instead of leaking raw parser failures.

6666

- Synology Chat: report malformed JSON webhook payloads with stable channel-owned parser errors.

67+

- Mattermost: report malformed interaction callback JSON with stable channel-owned parser errors.

6768

- Models config/auth: stop inferring provider env-var markers from broad `^[A-Z_][A-Z0-9_]*$` strings, and resolve config-backed provider `apiKey` values only through structured env SecretRefs (`secrets.providers[id]` / `secrets.defaults`), so unrelated env vars cannot accidentally become provider credentials. Thanks @sallyom.

6869

- Media fetch: skip allocating and buffering the response body for bodyless media responses (HEAD probes and 204-style empty bodies), avoiding wasted heap on streams that carry no payload. Thanks @shakkernerd.

6970

- CLI/onboarding: forward provider-specific auth flags (e.g. `--openai-api-key`) through the onboarding wizard so they reach provider auth methods via `ctx.opts`, letting `--openai-api-key "$OPENAI_API_KEY"` skip the redundant "use existing env var?" prompt in non-interactive harnesses. (#81669) Thanks @sjf.

Original file line numberDiff line numberDiff line change

@@ -499,7 +499,12 @@ describe("createMattermostInteractionHandler", () => {

499499

remoteAddress?: string;

500500

headers?: Record<string, string>;

501501

}): IncomingMessage {

502-

const body = params.body === undefined ? "" : JSON.stringify(params.body);

502+

const body =

503+

params.body === undefined

504+

? ""

505+

: typeof params.body === "string"

506+

? params.body

507+

: JSON.stringify(params.body);

503508

const listeners = new Map<string, Array<(...args: unknown[]) => void>>();

504509
505510

const req = {

@@ -717,6 +722,26 @@ describe("createMattermostInteractionHandler", () => {

717722

expectSuccessfulApprovalUpdate(res, requestLog);

718723

});

719724
725+

it("rejects malformed JSON callback requests with a stable parser error", async () => {

726+

const log = vi.fn();

727+

const handler = createMattermostInteractionHandler({

728+

client: createMattermostClientMock(async () => {

729+

throw new Error("unexpected client request");

730+

}),

731+

botUserId: "bot",

732+

accountId: "acct",

733+

log,

734+

});

735+
736+

const res = await runHandler(handler, { body: "{not json" });

737+
738+

expect(res.statusCode).toBe(400);

739+

expect(res.body).toBe(JSON.stringify({ error: "Invalid request body" }));

740+

expect(log).toHaveBeenCalledWith(

741+

"mattermost interaction: failed to parse body: Error: Mattermost interaction body was malformed JSON",

742+

);

743+

});

744+
720745

it("accepts forwarded Mattermost source IPs from a trusted proxy", async () => {

721746

const { res } = await runApproveInteraction({

722747

allowedSourceIps: ["198.51.100.8"],

Original file line numberDiff line numberDiff line change

@@ -405,6 +405,14 @@ export function createMattermostInteractionHandler(params: {

405405

const { client, accountId, log } = params;

406406

const core = getMattermostRuntime();

407407
408+

function parseInteractionPayload(raw: string): MattermostInteractionPayload {

409+

try {

410+

return JSON.parse(raw) as MattermostInteractionPayload;

411+

} catch {

412+

throw new Error("Mattermost interaction body was malformed JSON");

413+

}

414+

}

415+
408416

return async (req: IncomingMessage, res: ServerResponse) => {

409417

// Only accept POST

410418

if (req.method !== "POST") {

@@ -435,7 +443,7 @@ export function createMattermostInteractionHandler(params: {

435443

let payload: MattermostInteractionPayload;

436444

try {

437445

const raw = await readInteractionBody(req);

438-

payload = JSON.parse(raw) as MattermostInteractionPayload;

446+

payload = parseInteractionPayload(raw);

439447

} catch (err) {

440448

log?.(`mattermost interaction: failed to parse body: ${String(err)}`);

441449

res.statusCode = 400;