fix(scripts): reject short flag values in release docs parsers · openclaw/openclaw@82f43f0

Recent Commits to openclaw:main

vincentkoc · 2026-06-22 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ function parseArgs(argv) {`
`83`	`83`
`84`	`84`	`function readOptionValue(argv, index, option) {`
`85`	`85`	`const value = argv[index + 1] ?? "";`
`86`		`-if (!value \|\| value.startsWith("--")) {`
	`86`	`+if (!value \|\| value.startsWith("-")) {`
`87`	`87`	throw new Error(`Missing value for ${option}.`);
`88`	`88`	`}`
`89`	`89`	`return value;`

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ function parsePositiveIntegerArg(raw, label) {`
`94`	`94`
`95`	`95`	`function readRequiredValue(argv, index, label) {`
`96`	`96`	`const value = argv[index + 1];`
`97`		`-if (!value \|\| value.startsWith("--")) {`
	`97`	`+if (!value \|\| value.startsWith("-")) {`
`98`	`98`	throw new Error(`${label} requires a value`);
`99`	`99`	`}`
`100`	`100`	`return value;`
`@@ -116,7 +116,10 @@ export function parseArgs(argv) {`
`116`	`116`	`continue;`
`117`	`117`	`}`
`118`	`118`	`if (part === "--max-errors") {`
`119`		`-maxErrors = parsePositiveIntegerArg(argv[index + 1], "--max-errors");`
	`119`	`+maxErrors = parsePositiveIntegerArg(`
	`120`	`+readRequiredValue(argv, index, "--max-errors"),`
	`121`	`+"--max-errors",`
	`122`	`+);`
`120`	`123`	`index += 1;`
`121`	`124`	`continue;`
`122`	`125`	`}`

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ function parseArgs(argv) {`
`59`	`59`
`60`	`60`	`function readOptionValue(argv, index, option) {`
`61`	`61`	`const value = argv[index + 1] ?? "";`
`62`		`-if (!value \|\| value.startsWith("--")) {`
	`62`	`+if (!value \|\| value.startsWith("-")) {`
`63`	`63`	throw new Error(`Missing value for ${option}.`);
`64`	`64`	`}`
`65`	`65`	`return value;`

Original file line number	Diff line number	Diff line change
`@@ -30,12 +30,19 @@ function runNode(args: string[], env: NodeJS.ProcessEnv = {}) {`
`30`	`30`	`const e = error as { stdout?: unknown; stderr?: unknown };`
`31`	`31`	`return {`
`32`	`32`	`ok: false,`
`33`		`-stdout: Buffer.isBuffer(e.stdout) ? e.stdout.toString("utf8") : String(e.stdout ?? ""),`
`34`		`-stderr: Buffer.isBuffer(e.stderr) ? e.stderr.toString("utf8") : String(e.stderr ?? ""),`
	`33`	`+stdout: formatProcessOutput(e.stdout),`
	`34`	`+stderr: formatProcessOutput(e.stderr),`
`35`	`35`	`};`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
	`39`	`+function formatProcessOutput(value: unknown): string {`
	`40`	`+if (Buffer.isBuffer(value)) {`
	`41`	`+return value.toString("utf8");`
	`42`	`+}`
	`43`	`+return typeof value === "string" ? value : "";`
	`44`	`+}`
	`45`	`+`
`39`	`46`	`function runGit(args: string[], cwd?: string, env: NodeJS.ProcessEnv = {}) {`
`40`	`47`	`execFileSync("git", args, {`
`41`	`48`	`cwd,`
`@@ -127,11 +134,17 @@ describe("scripts/android-release-signing.mjs", () => {`
`127`	`134`	`it.each([`
`128`	`135`	`["--mode"],`
`129`	`136`	`["--mode", "--manifest"],`
	`137`	`+["--mode", "-h"],`
`130`	`138`	`["--manifest"],`
	`139`	`+["--manifest", "-h"],`
`131`	`140`	`["--workspace", "--mode"],`
	`141`	`+["--workspace", "-h"],`
`132`	`142`	`["--materialized-dir", "--mode"],`
	`143`	`+["--materialized-dir", "-h"],`
`133`	`144`	`["--keystore", "--mode"],`
	`145`	`+["--keystore", "-h"],`
`134`	`146`	`["--properties", "--mode"],`
	`147`	`+["--properties", "-h"],`
`135`	`148`	`])("rejects missing values for %s before release signing work", (...args) => {`
`136`	`149`	`const result = runNode(args);`
`137`	`150`

Original file line number	Diff line number	Diff line change
`@@ -20,11 +20,13 @@ describe("scripts/check-docs-mdx", () => {`
`20`	`20`	`expect(() => parseArgs(["--max-errors", "0"])).toThrow(`
`21`	`21`	`"--max-errors must be a positive integer",`
`22`	`22`	`);`
`23`		`-expect(() => parseArgs(["--max-errors"])).toThrow("--max-errors must be a positive integer");`
	`23`	`+expect(() => parseArgs(["--max-errors"])).toThrow("--max-errors requires a value");`
	`24`	`+expect(() => parseArgs(["--max-errors", "-h"])).toThrow("--max-errors requires a value");`
`24`	`25`	`});`
`25`	`26`
`26`	`27`	`it("rejects missing JSON report output paths", () => {`
`27`	`28`	`expect(() => parseArgs(["--json-out"])).toThrow("--json-out requires a value");`
	`29`	`+expect(() => parseArgs(["--json-out", "-h"])).toThrow("--json-out requires a value");`
`28`	`30`	`expect(() => parseArgs(["--json-out", "--max-errors", "3"])).toThrow(`
`29`	`31`	`"--json-out requires a value",`
`30`	`32`	`);`

Original file line number	Diff line number	Diff line change
`@@ -16,12 +16,19 @@ function runSigningResult(args: string[]): { ok: boolean; stdout: string; stderr`
`16`	`16`	`const e = error as { stdout?: unknown; stderr?: unknown };`
`17`	`17`	`return {`
`18`	`18`	`ok: false,`
`19`		`-stdout: Buffer.isBuffer(e.stdout) ? e.stdout.toString("utf8") : String(e.stdout ?? ""),`
`20`		`-stderr: Buffer.isBuffer(e.stderr) ? e.stderr.toString("utf8") : String(e.stderr ?? ""),`
	`19`	`+stdout: formatProcessOutput(e.stdout),`
	`20`	`+stderr: formatProcessOutput(e.stderr),`
`21`	`21`	`};`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`
	`25`	`+function formatProcessOutput(value: unknown): string {`
	`26`	`+if (Buffer.isBuffer(value)) {`
	`27`	`+return value.toString("utf8");`
	`28`	`+}`
	`29`	`+return typeof value === "string" ? value : "";`
	`30`	`+}`
	`31`	`+`
`25`	`32`	`function runSigning(mode: string): string {`
`26`	`33`	`return execFileSync(process.execPath, [SCRIPT, "--mode", mode], {`
`27`	`34`	`encoding: "utf8",`
`@@ -33,7 +40,9 @@ describe("scripts/ios-release-signing.mjs", () => {`
`33`	`40`	`it.each([`
`34`	`41`	`["--mode"],`
`35`	`42`	`["--mode", "--manifest"],`
	`43`	`+["--mode", "-h"],`
`36`	`44`	`["--manifest"],`
	`45`	`+["--manifest", "-h"],`
`37`	`46`	`])("rejects missing values for %s before reading signing manifests", (...args) => {`
`38`	`47`	`const result = runSigningResult(args);`
`39`	`48`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main