fix: validate slack action limits · openclaw/openclaw@7932a4a

Recent Commits to openclaw:main

steipete · 2026-05-29 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -1117,4 +1117,11 @@ describe("handleSlackAction", () => {`
`1117`	`1117`	`},`
`1118`	`1118`	`});`
`1119`	`1119`	`});`
	`1120`	`+`
	`1121`	`+it("rejects fractional emoji-list limits before reading emojis", async () => {`
	`1122`	`+await expect(`
	`1123`	`+handleSlackAction({ action: "emojiList", limit: 2.5 }, slackConfig()),`
	`1124`	`+).rejects.toThrow("limit must be a positive integer.");`
	`1125`	`+expect(listSlackEmojis).not.toHaveBeenCalled();`
	`1126`	`+});`
`1120`	`1127`	`});`

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ import {`
`11`	`11`	`createActionGate,`
`12`	`12`	`imageResultFromFile,`
`13`	`13`	`jsonResult,`
`14`		`-readNumberParam,`
	`14`	`+readPositiveIntegerParam,`
`15`	`15`	`readReactionParams,`
`16`	`16`	`readStringParam,`
`17`	`17`	`type OpenClawConfig,`
`@@ -572,10 +572,12 @@ export async function handleSlackAction(`
`572`	`572`	`if (!isActionEnabled("emojiList")) {`
`573`	`573`	`throw new Error("Slack emoji list is disabled.");`
`574`	`574`	`}`
	`575`	`+const limit = readPositiveIntegerParam(params, "limit", {`
	`576`	`+message: "limit must be a positive integer.",`
	`577`	`+});`
`575`	`578`	`const result = readOpts`
`576`	`579`	`? await slackActionRuntime.listSlackEmojis(readOpts)`
`577`	`580`	`: await slackActionRuntime.listSlackEmojis();`
`578`		`-const limit = readNumberParam(params, "limit", { integer: true });`
`579`	`581`	`if (limit != null && limit > 0 && result.emoji != null) {`
`580`	`582`	`const entries = Object.entries(result.emoji).toSorted(([a], [b]) => a.localeCompare(b));`
`581`	`583`	`if (entries.length > limit) {`

Original file line number	Diff line number	Diff line change
`@@ -383,6 +383,26 @@ describe("handleSlackMessageAction", () => {`
`383`	`383`	`expect(firstInvokeCall(invoke)[1]).toEqual({});`
`384`	`384`	`});`
`385`	`385`
	`386`	`+it("rejects fractional read limits before invoking Slack actions", async () => {`
	`387`	`+const invoke = createInvokeSpy();`
	`388`	`+`
	`389`	`+await expect(`
	`390`	`+handleSlackMessageAction({`
	`391`	`+providerId: "slack",`
	`392`	`+ctx: {`
	`393`	`+action: "read",`
	`394`	`+cfg: {},`
	`395`	`+params: {`
	`396`	`+channelId: "C1",`
	`397`	`+limit: 2.5,`
	`398`	`+},`
	`399`	`+} as never,`
	`400`	`+invoke: invoke as never,`
	`401`	`+}),`
	`402`	`+).rejects.toThrow("limit must be a positive integer.");`
	`403`	`+expect(invoke).not.toHaveBeenCalled();`
	`404`	`+});`
	`405`	`+`
`386`	`406`	`it("requires filePath, path, or media for upload-file", async () => {`
`387`	`407`	`await expect(`
`388`	`408`	`handleSlackMessageAction({`

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import {`
`5`	`5`	`normalizeInteractiveReply,`
`6`	`6`	`normalizeMessagePresentation,`
`7`	`7`	`} from "openclaw/plugin-sdk/interactive-runtime";`
`8`		`-import { readNumberParam, readStringParam } from "openclaw/plugin-sdk/param-readers";`
	`8`	`+import { readPositiveIntegerParam, readStringParam } from "openclaw/plugin-sdk/param-readers";`
`9`	`9`	`import {`
`10`	`10`	`buildSlackInteractiveBlocks,`
`11`	`11`	`buildSlackPresentationBlocks,`
`@@ -107,7 +107,9 @@ export async function handleSlackMessageAction(params: {`
`107`	`107`	`const messageId = readStringParam(actionParams, "messageId", {`
`108`	`108`	`required: true,`
`109`	`109`	`});`
`110`		`-const limit = readNumberParam(actionParams, "limit", { integer: true });`
	`110`	`+const limit = readPositiveIntegerParam(actionParams, "limit", {`
	`111`	`+message: "limit must be a positive integer.",`
	`112`	`+});`
`111`	`113`	`return await invoke(`
`112`	`114`	`{`
`113`	`115`	`action: "reactions",`
`@@ -121,7 +123,9 @@ export async function handleSlackMessageAction(params: {`
`121`	`123`	`}`
`122`	`124`
`123`	`125`	`if (action === "read") {`
`124`		`-const limit = readNumberParam(actionParams, "limit", { integer: true });`
	`126`	`+const limit = readPositiveIntegerParam(actionParams, "limit", {`
	`127`	`+message: "limit must be a positive integer.",`
	`128`	`+});`
`125`	`129`	`const readAction: Record<string, unknown> = {`
`126`	`130`	`action: "readMessages",`
`127`	`131`	`channelId: resolveChannelId(),`
`@@ -197,7 +201,9 @@ export async function handleSlackMessageAction(params: {`
`197`	`201`	`}`
`198`	`202`
`199`	`203`	`if (action === "emoji-list") {`
`200`		`-const limit = readNumberParam(actionParams, "limit", { integer: true });`
	`204`	`+const limit = readPositiveIntegerParam(actionParams, "limit", {`
	`205`	`+message: "limit must be a positive integer.",`
	`206`	`+});`
`201`	`207`	`return await invoke({ action: "emojiList", limit, accountId }, cfg);`
`202`	`208`	`}`
`203`	`209`

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ export {`
`26`	`26`	`imageResultFromFile,`
`27`	`27`	`jsonResult,`
`28`	`28`	`readNumberParam,`
	`29`	`+readPositiveIntegerParam,`
`29`	`30`	`readReactionParams,`
`30`	`31`	`readStringParam,`
`31`	`32`	`withNormalizedTimestamp,`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main